From patchwork Mon May 8 02:28:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 9715703 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EFFF060380 for ; Mon, 8 May 2017 02:28:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE7BB24560 for ; Mon, 8 May 2017 02:28:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CFE5C2521E; Mon, 8 May 2017 02:28:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D33124560 for ; Mon, 8 May 2017 02:28:31 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id EB7F1266BA4; Mon, 8 May 2017 04:28:27 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 7B8B6266BA6; Mon, 8 May 2017 04:28:26 +0200 (CEST) Received: from relmlie4.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa0.perex.cz (Postfix) with ESMTP id C8725266483 for ; Mon, 8 May 2017 04:28:19 +0200 (CEST) Received: from unknown (HELO relmlir3.idc.renesas.com) ([10.200.68.153]) by relmlie4.idc.renesas.com with ESMTP; 08 May 2017 11:28:16 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir3.idc.renesas.com (Postfix) with ESMTP id 48F2145940; Mon, 8 May 2017 11:28:16 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.38,306,1491231600"; d="scan'208";a="242936407" Received: from mail-hk2apc01lp0216.outbound.protection.outlook.com (HELO APC01-HK2-obe.outbound.protection.outlook.com) ([65.55.88.216]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 08 May 2017 11:28:15 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Hhyvp+xcVXcjUNcxrOq/wryZJ3Prbf8I2L6YVLx9wl0=; b=dgMvZdKZseKm8zPzY0Kd/siGymsbDMYiJfHdwxR9vwL7IlNxIl+GpQrYwOieHOtDpjroSLObJ6PFfuk2uS4UgfHh8RWXd7RBy+ping+QxLfSmSVmHtlrfnkGjaOcdZinylEKCNcIjAkA/CfDNCWFjnRtz40zuiiE6VGCdSiHToA= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none; kernel.org; dmarc=none action=none header.from=renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.144) by SG2PR0601MB1885.apcprd06.prod.outlook.com (10.170.132.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1075.11; Mon, 8 May 2017 02:28:13 +0000 Message-ID: <87o9v4ccid.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Mon, 8 May 2017 02:28:13 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: SG2PR06CA0002.apcprd06.prod.outlook.com (10.163.105.12) To SG2PR0601MB1885.apcprd06.prod.outlook.com (10.170.132.146) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ed398d5-744a-4535-fd70-08d495b9e10f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(201703131423075)(201703031133081); SRVR:SG2PR0601MB1885; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 3:kAFD73vJ98thsezW/uNOXjOy/pVAozyVo45Onl0mf0UHKf7eAA19incS7ZAZLVWaXWg3XvcXOVDczgOns38M1/8S0aNwSgH0MGcH55Wv+p6HTjUTJ8eI/Hw86mXpjrKtinFx9uNHPoK5O0+AoyQN8QKNB2pVkhgeIhZikQmAg7PjBselEe4zNzZJ5NKOsrpT3s+OpItwe5yC63Txfa2QjTYmNAWVXIT+whCYRvFhcKz6xxy4y7X/5QEQVcNUH2CowwlA3zDpx7hPW/pmu80uWjh8mfH3lTCFBiqfS65qZ84w8lSTe2mQRVkrC/oMH9hEWD5NzRGjhAXcfZeS0kWaGQSL0RwQt0l2nGe1pHXjJ10=; 25:ie/aw95oyIu2+yBq8aOR2fkk9p6Ib8PB00vPnYHeWan4PEdWPigBaIan+CzHFGsMzXMCxaH2W7Nvjyeretx9RIrd/po/BdefE4DkRXqoolaJyQ7zHJA4C5i10TxhK59FwFsIoMHy8fp8eBGBX5qfqztO03xD2vH5A+QW6y/9nkUj0Yen+XE5ox376xfE0UrQCnsVuero79e1hbeF6t3yzNIAj2QjTWomEo/mSO+eZw8p/OCYHvggx1YCQQixgoSbC8c9pepRwgy9PmLfyGCKRj8CwXEQXVRd77YSsqnvPq/YlHgiWi+e4iuUAm7SW+LcWMmNKqk5uU69QfzzW80CSmz6M487wFB7gS1112DzsAM+U2uHLD5H8D6OA4SKYSrP6odZ//GFRJYIp3bc8t02bq7E+MudoV9jDlwsCsKl7P2bh+AZ3GUMop9JUuD60n3FKYp5Jd7+5opBCeddXtMHSA== X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 31:tvLicQpOO+J8JV02Jfv2KpUYAePolrqNtazqoiAMpbM+IJ19hsynKhBFH8DvdapN0j9NBU8yy99xq/U+mLK79GaLQFpZfoCYiGkRp4KqyyVGgMXeC0DxXp5/5P4mHI8gt5c6eKu9Oit+4jYAZOZgxpTJGXZ8S7Lj+jT+poXPqIJWaSokloHaHUzh/Sr8JzvxmBSg3RggxCC9cHVjD7wNLLOYhoWBt1P/4PtsRbLBPkdcgn+O+qs6ekh0MZ88VoV6; 20:BvguNr/7vmh0cUAQlT5jL6PeFC9eGb0WHMqZ4guyjjs1um0Y2lDweH3ODk5fEjZyXRG822WrUCvl5NiM62s+ILgZsYrJB7ah4QKHV4QwD85RzI4uywleGPVy9Yy1h1AItZjZtd3LDWct+5w51J+2vAzRCPrG8oJlHKSe/T+sqG/+lWnwoRD2sY2lrLwYHHuUJXr71YX5Uu6T9ei+50OhYAYDEgMq/pwWHgZ/jDzLa8OxuU7Vdqt6LLsmVyfMq7WItoBlMHrk89lpC3YSae9xdLRPNJAvylIcq2DtorNdxKX5TXfcF511w5LGtyRkGM+rQBeE0C0mjcZMOg48aScS5cdJIrSKCOJmz/jLnydr4JSopGvAhas0CzJ8WZpuMM79U8H6E97krajwoVp5AMp7CqWQKS9aBlbI1q2p6peOJ69aHnI4WdYrIXrmFhXOWBOQi2dxeMeQf3LSt/j9UTFOH47Z4SLI/qmlB7F18Wf3wj4SWKfk252ipb2LctW8EpK0 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:SG2PR0601MB1885; BCL:0; PCL:0; RULEID:; SRVR:SG2PR0601MB1885; X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 4:Uq9jdkSoMxFA4BqMGc7O98yuTD7UYKO8AtNDAapOHZGZNc5lI7QHcFSke2BzyLJxdmbWkhnCZYUiW/Mm6e/DJPOGDlWFgKWuChi0+EfGgcH4dQBZ7uq/2yUEd7nudNeUTZmxR3u3xoubipv8l051HymOIkTueQVAK8OqwXRGXW519cSBKO8v2sIg9VthMvaCVah9x68TvicXaRV6f7VLqakUjYIVka209u+6evJVuqMhTaTKPymG6SawW0SJZon+7Mb+wpMm9rXLG1olmgmbhDQuTidHXp8dluTiFRYejhjLIbX7WKCd/GLkF3JwnUX2WK4uGwSc+3Am6WcYX5VfiOR7sy/jKl6/RhM9dRO+Dx29YPfHjGZDid0WTQqBSCLb3iHAaF1Yn7gRkx5Z6egTmeYNAYBqOvE8jid1E4Asx5MR0NDAjErnVYgEtTeQNZfqUAFHaK5GRwwCvo92x9BV8SbyQkbQNZyRga5pJEW20GsuHyK+TGIfQHbdnxAK0YkLU7D3yz5F6V0c3cJb4B1ucbq0Oi1p2yecIuzZE+xBTsYk8CsdyZIfB2n31Dfcrvc5H4gcJn/OZ/2pWwivkD3Zp7IxsvdNxZVAc3RPjjFCLHnhDXpdc1DHzdfwk0bLVQyAImbTgIBMieUMq61T827La3fFjc6UE425c8/5Oa3FkEoW18BvR4XoUkZcunqh7ct4AkKFRjXE44prj9s8VlACeJaTgCNVM6pVp0bVM7KuMex/8fmV4kcHXjjNUXJZTsuf9TTpmN0+rXKsTzbRMa+V6bW4+4gRNYTv5k2RJ2suTyA= X-Forefront-PRVS: 0301360BF5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39860400002)(39450400003)(39400400002)(39850400002)(39410400002)(33646002)(4001350100001)(50986999)(38730400002)(110136004)(46406003)(53936002)(86362001)(36756003)(83506001)(54906002)(3846002)(4326008)(50466002)(23726003)(25786009)(6116002)(66066001)(189998001)(54356999)(6486002)(6916009)(2906002)(42186005)(53416004)(478600001)(47776003)(5660300001)(81166006)(8676002)(7736002)(305945005)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:SG2PR0601MB1885; H:morimoto-PC.renesas.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SG2PR0601MB1885; 23:rkKP1ZAu+ms75bEmRy1WqcFkziCXCLevqk8wRfC?= =?us-ascii?Q?E/JGcJ87borHTpi71JaLjsWFotZ4mlNHeEBFLLOLgl+sPcmWUcxVqayVEfTe?= =?us-ascii?Q?aSXIOtttLpAQettFLKHTfeRJl8Td95xpqdZ8Ym5jHlVvB4/K2gmWmw1pICJ1?= =?us-ascii?Q?yBpBAtpz2cbqjqNMUhGjNFzYb+5okXvgWso1hYfFQEqn2FgA/nE/9/V3plr5?= =?us-ascii?Q?6FycVsgFSrqsLGD2j7o3FdxCxA2Tl/QT+2TQ0raILUEBfQMWi7z1J2lk85ML?= =?us-ascii?Q?YPSULH0EA4IRYYgss/9QRjhALdtanIeNlfSrDozkwGVvtfvjGTuY1Z+B74by?= =?us-ascii?Q?EKRB2gr1zHrerkSkvWRA/WU8TcQiftn2HTM3jSehWGlExi+xcm2xsHSE8GuC?= =?us-ascii?Q?vMTwb2T8S2B6mF/cX8v7JAXZhJ7LQPdLWK/rFvzFEWI0dM7EW82DQLC1zP01?= =?us-ascii?Q?8MMhGHnuIpHv6g1Iuzr7iBHnhy6of9SMbjN8Kw4zeG8Y1Mwc+WrDAaNset6u?= =?us-ascii?Q?L7fDuAmwLqL7Ddx81ZHpE4iurk/ijnHYMo9yOznd/Q+bwei38fKDSzvCiaiY?= =?us-ascii?Q?2ruFXMzVflPYx36zvcsuAM1LOWTfV6rD2vD8ovwzCjwgzHoIfilcn0ynivs7?= =?us-ascii?Q?KRc+i3rvTFtFzU/+lITqCkLHVE+mFtxav9wETPJPefKsCpZLbkZ2t/5uJKja?= =?us-ascii?Q?dd8813y8M9JfQ8hVTu9o7omA/02dLto2cSp0Bjcke8esDHTaSDnSddJSnHZe?= =?us-ascii?Q?Qg74ZzsZ5sEe5VbtZVfi517n57VcrXCGE29/UwC5unabTvvetik4PSL3M+tl?= =?us-ascii?Q?Nc381dau7BdCcmwO6xv8Ya/F0KTfCd7GkYgS12I2nZVd+chZuVCFdB9mLdWE?= =?us-ascii?Q?EGz5/HSOT6lfiXrOrLSwHoni1MpXh080Xs8TO7190mNTNaoqNpzxaPkZw6Dd?= =?us-ascii?Q?6TqF/JkHPx3gKF+UgFtOQPKJg8YBXOrRC8TWo0kJb903rIHGgSjM/fPZ2sr+?= =?us-ascii?Q?IXP4hEOWCfnn9LShzVLJx1/R2qPziO9wUlNXpZY610RPqQA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 6:vrVFzZ5kiquEP7ntarvxpl9fkyohuMni+9MVtoCdymiA8Yk7cY9vrQpAj/HpHpSJgxdms0ba2LpLg2GfjWusc+Et2uxm7xPoebHzucjUE8IVZ/9mv3Vf6nuzpEL7f/GoEb2VU+aPfjesCF1u61OsTA31aUJ+XuNB/MA2KhgmXRBMH/dfNKrYgYl/MurWKUQyRx7HQoUitvfcYiSWTFlXLeq3udugdd4cJ1INy+qRA3dOYsm4mGLxC8Q8yP7tACTzibqVobWmqgyJb7wSMtoMB+91gW+VZScNeCB3SgaHzKsk0iW5uEppwohb8HeudQrs7NCphZhfBVq3Bw4EgfYc51yW4amH2yER7usr+jEj7Dr0DoQWSGzovgp+em5tmJ22I7EaioeEfswUnivR3Mu4HnMVpNPW05fo1+bUVMlzbhznRHiqVLSoiTXHgIMthICH6qqWkvWIOgGlJQe35Iht9Wg5EOe1I5bUjTIP72u8XA5A539S3hs8YB/RtLcIFCJhiyWdNzLovP+cBcAvNdrrjiZ0LjrbqfhsDzMAFJMk+RU=; 5:ab2yzrvjvPx+CZnK4v33FT76OJ/IJWuvmiLuKCwAKIVJaL+mqDdYOWcrFx9KT20y5VtcnqgqCHV1DItVxGwqvKrcRtTMMdnBldasm8vWYdxciwQZQCAmJV5dm9XFvN9eLJ9bWt3SKKEWf2ePo3pWLQ==; 24:mts2ipW/llEh5TxCoCueBS7n5umhQCrKErryK0+4lFJFrn6/6odYsjoCUg+200Anxo7c1LoEH7e4I/wS6BBnqE/tpsKPZWfViJwYsoASnbs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SG2PR0601MB1885; 7:cZcWcVZSTDnKzN3rekL/nbLlohipdm9tL0PltUkgqEK4Gk003SmhsrqLmkDjeBWlTnqoKgmOBHosNWcIek3icwRf888BlcU+dTBgo+MDOYujsbvB9Z2kppoZL6NFYtf2dtxe0708v/iJ9I9hdlQgqCcfvAuRghQEMYNpa3O3MbgVUt4cy22Ax0sodB4Gi174V1o18uBHCiAtlf8HQRZi9bf9PUEm6GmiEi2lTPRfPkJZu8E1vhQSr9ACzx0uVf0gBZQgw711zmLx+e2IsJ9JETbrhI7ZvUPNB2GJbmi43mivv/DC/ABCNiRkiU5YWiMWqRsIk8VSQKZPOuF+xinN/Q==; 20:d0nM16IbVD76I82bmhoKFL/fdoLcwkLesa/G6GcO4FPBF288s0S08xMu9ZDWH1oPvK2vCfjijpugWKiGROsSDPZOuaXe51l4UwL8RI98omiJ3sxaQoiJCE2R2d4JptdnM9kUZwQq7TikobD3lqhsUbE/0hrHESTeo9j6Rvjg60g= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2017 02:28:13.7337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1885 Cc: linux-renesas-soc@vger.kernel.org, Linux-ALSA , Simon Subject: [alsa-devel] [PATCH v2] ASoC: ak4613: disable asymmetric audio interface format X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto Asymmetric audio interface formats exist in ak4613 by same register settings. Capture Playback 24bit LEFT_J 16bit RIGHT_J 24bit LEFT_J 20bit RIGHT_J 24bit LEFT_J 24bit RIGHT_J 24bit LEFT_J 24bit LEFT_J 24bit I2S 24bit I2S These asymmetric formats makes driver / behavior difficult. It is not HW limitation, but SW limitation. To makes code reading easy, this patch removes asymmetric format support. Signed-off-by: Kuninori Morimoto --- v1 -> v2 - just remove code instead of comment out sound/soc/codecs/ak4613.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index b2dfdde..557ac16 100644 --- a/sound/soc/codecs/ak4613.c +++ b/sound/soc/codecs/ak4613.c @@ -139,9 +139,7 @@ struct ak4613_priv { #define AUDIO_IFACE(b, fmt) { b, SND_SOC_DAIFMT_##fmt } static const struct ak4613_interface ak4613_iface[] = { /* capture */ /* playback */ - [0] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(16, RIGHT_J) }, - [1] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(20, RIGHT_J) }, - [2] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, RIGHT_J) }, + /* [0] - [2] are not supported */ [3] = { AUDIO_IFACE(24, LEFT_J), AUDIO_IFACE(24, LEFT_J) }, [4] = { AUDIO_IFACE(24, I2S), AUDIO_IFACE(24, I2S) }, }; @@ -262,11 +260,9 @@ static int ak4613_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) fmt &= SND_SOC_DAIFMT_FORMAT_MASK; switch (fmt) { - case SND_SOC_DAIFMT_RIGHT_J: case SND_SOC_DAIFMT_LEFT_J: case SND_SOC_DAIFMT_I2S: priv->fmt = fmt; - break; default: return -EINVAL; @@ -286,13 +282,8 @@ static bool ak4613_dai_fmt_matching(const struct ak4613_interface *iface, if (fmts->fmt != fmt) return false; - if (fmt == SND_SOC_DAIFMT_RIGHT_J) { - if (fmts->width != width) - return false; - } else { - if (fmts->width < width) - return false; - } + if (fmts->width != width) + return false; return true; } @@ -420,8 +411,7 @@ static int ak4613_set_bias_level(struct snd_soc_codec *codec, SNDRV_PCM_RATE_96000 |\ SNDRV_PCM_RATE_176400 |\ SNDRV_PCM_RATE_192000) -#define AK4613_PCM_FMTBIT (SNDRV_PCM_FMTBIT_S16_LE |\ - SNDRV_PCM_FMTBIT_S24_LE) +#define AK4613_PCM_FMTBIT (SNDRV_PCM_FMTBIT_S24_LE) static struct snd_soc_dai_driver ak4613_dai = { .name = "ak4613-hifi",