arm64: dts: ls1088a: update the sata node
diff mbox

Message ID 1494213209-39673-1-git-send-email-andy.tang@nxp.com
State New, archived
Headers show

Commit Message

Andy Tang May 8, 2017, 3:13 a.m. UTC
1. Sata ecc should be disabled due to a erratum.
Provide the ecc register address for driver to use.
2. Enable dma coherence operation

Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Shawn Guo May 11, 2017, 7:35 a.m. UTC | #1
On Mon, May 08, 2017 at 11:13:29AM +0800, Yuantian Tang wrote:
> 1. Sata ecc should be disabled due to a erratum.
> Provide the ecc register address for driver to use.

This is a bit confusing.  Are you saying that the ECC register address
is provided in DT for SATA driver to disable ECC function?

> 2. Enable dma coherence operation
> 
> Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> index 2946fd7..90edd76 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> @@ -265,10 +265,13 @@
>  
>  		sata: sata@3200000 {
>  			compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
> -			reg = <0x0 0x3200000 0x0 0x10000>;
> +			reg = <0x0 0x3200000 0x0 0x10000>,
> +				<0x0 0x20140520 0x0 0x4>;
> +			reg-names = "ahci", "sata-ecc";
>  			interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
>  			clocks = <&clockgen 4 3>;
>  			status = "disabled";
> +			dma-coherent;

Please add it above 'status' line, which we generally keep at the bottom
of property list.

Shawn

>  		};
>  	};
>  
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Andy Tang May 11, 2017, 7:57 a.m. UTC | #2
Hi Shawn,

Please see my reply inline.

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> Sent: Thursday, May 11, 2017 3:35 PM
> To: Andy Tang <andy.tang@nxp.com>
> Cc: mark.rutland@arm.com; devicetree@vger.kernel.org;
> catalin.marinas@arm.com; will.deacon@arm.com; robh+dt@kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH] arm64: dts: ls1088a: update the sata node
> 
> On Mon, May 08, 2017 at 11:13:29AM +0800, Yuantian Tang wrote:
> > 1. Sata ecc should be disabled due to a erratum.
> > Provide the ecc register address for driver to use.
> 
> This is a bit confusing.  Are you saying that the ECC register address is
> provided in DT for SATA driver to disable ECC function?
> 
Yes, we have a ECC register to control all the IP's ecc status.
This ECC register doesn't belong to any IP block.

> > 2. Enable dma coherence operation
> >
> > Signed-off-by: Tang Yuantian <andy.tang@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 2946fd7..90edd76 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -265,10 +265,13 @@
> >
> >  		sata: sata@3200000 {
> >  			compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
> > -			reg = <0x0 0x3200000 0x0 0x10000>;
> > +			reg = <0x0 0x3200000 0x0 0x10000>,
> > +				<0x0 0x20140520 0x0 0x4>;
> > +			reg-names = "ahci", "sata-ecc";
> >  			interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
> >  			clocks = <&clockgen 4 3>;
> >  			status = "disabled";
> > +			dma-coherent;
> 
> Please add it above 'status' line, which we generally keep at the bottom of
> property list.
> 
OK, Will resend this patch.

Thanks,
Andy

> Shawn
> 
> >  		};
> >  	};
> >
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Patch
diff mbox

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
index 2946fd7..90edd76 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
@@ -265,10 +265,13 @@ 
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1088a-ahci", "fsl,ls1043a-ahci";
-			reg = <0x0 0x3200000 0x0 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000>,
+				<0x0 0x20140520 0x0 0x4>;
+			reg-names = "ahci", "sata-ecc";
 			interrupts = <0 133 IRQ_TYPE_LEVEL_HIGH>;
 			clocks = <&clockgen 4 3>;
 			status = "disabled";
+			dma-coherent;
 		};
 	};