| Message ID | 20170508113303.27521-21-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/05/17 14:32, Laurent Pinchart wrote: > The OMAP implementation of the set_min_bus_tput() API is a no-op. > There's no point in forwarding the driver calls to the platform code. > Remove the use of the related platform data callback, but keep the > internal function as a reminder that the feature will need to be > implemented when the OMAP platform will provide support. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Tomi
diff --git a/drivers/gpu/drm/omapdrm/dss/core.c b/drivers/gpu/drm/omapdrm/dss/core.c index 7579de042d32..ff6357df0588 100644 --- a/drivers/gpu/drm/omapdrm/dss/core.c +++ b/drivers/gpu/drm/omapdrm/dss/core.c @@ -50,16 +50,6 @@ enum omapdss_version omapdss_get_version(void) } EXPORT_SYMBOL(omapdss_get_version); -int dss_set_min_bus_tput(struct device *dev, unsigned long tput) -{ - struct omap_dss_board_info *pdata = core.pdev->dev.platform_data; - - if (pdata->set_min_bus_tput) - return pdata->set_min_bus_tput(dev, tput); - else - return 0; -} - #if defined(CONFIG_OMAP2_DSS_DEBUGFS) static int dss_debug_show(struct seq_file *s, void *unused) { diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h b/drivers/gpu/drm/omapdrm/dss/dss.h index 453b4ba0bf18..1ef7c0e75d4c 100644 --- a/drivers/gpu/drm/omapdrm/dss/dss.h +++ b/drivers/gpu/drm/omapdrm/dss/dss.h @@ -230,7 +230,12 @@ struct seq_file; struct platform_device; /* core */ -int dss_set_min_bus_tput(struct device *dev, unsigned long tput); +static inline int dss_set_min_bus_tput(struct device *dev, unsigned long tput) +{ + /* To be implemented when the OMAP platform will provide this feature */ + return 0; +} + int dss_debugfs_create_file(const char *name, void (*write)(struct seq_file *)); static inline bool dss_mgr_is_lcd(enum omap_channel id)
The OMAP implementation of the set_min_bus_tput() API is a no-op. There's no point in forwarding the driver calls to the platform code. Remove the use of the related platform data callback, but keep the internal function as a reminder that the feature will need to be implemented when the OMAP platform will provide support. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- Changes since v1: - Make the function inline --- drivers/gpu/drm/omapdrm/dss/core.c | 10 ---------- drivers/gpu/drm/omapdrm/dss/dss.h | 7 ++++++- 2 files changed, 6 insertions(+), 11 deletions(-)