From patchwork Tue May 9 13:50:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 9717983 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D54C460237 for ; Tue, 9 May 2017 13:52:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAA9B28408 for ; Tue, 9 May 2017 13:52:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BF5C928418; Tue, 9 May 2017 13:52:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.wl.linuxfoundation.org (Postfix) with SMTP id 4311B28408 for ; Tue, 9 May 2017 13:52:07 +0000 (UTC) Received: (qmail 27945 invoked by uid 550); 9 May 2017 13:51:50 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Received: (qmail 27859 invoked from network); 9 May 2017 13:51:48 -0000 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:in-reply-to:references; s=mail; bh=Ckh5 aOfPxqYrMu6lnL1avbTdqzE=; b=xWjRnQEXP5OhIKW05idd/yABX2Lj2QHKC/H2 LmxnjMEkol4WtWJdRoTgGYvZGKUun0g33c5uspDxUYdG/N9IVvv+WzbIcyveTCD9 GJL47CbVdxnll+/KhWLPLB2CPrmTU/2871H0rpQnhbvari6nwXSVIdcrqNevebQ/ td/8WtDW9e8VZ9IODDtrfA1rnc6HiJu+6EAC/88DC6LrEw1QSton/N1piHT8KsBj 4dLT1d/kaeB++5NNmrCDBQ4w3oIpwBoVQ33xlsZS/mfW+j+eReJ/Vyhtx2Evuw/r GYblb2fT6FmWIUF7jHf9tOkr59QBeo2ZKN9EoYk6hACYhZtBHQ== From: "Jason A. Donenfeld" To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, kernel-hardening@lists.openwall.com Cc: "Jason A. Donenfeld" , Steffen Klassert , Herbert Xu Date: Tue, 9 May 2017 15:50:06 +0200 Message-Id: <20170509135009.13751-3-Jason@zx2c4.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170509135009.13751-1-Jason@zx2c4.com> References: <20170509135009.13751-1-Jason@zx2c4.com> Subject: [kernel-hardening] [PATCH v7 2/5] ipsec: check return value of skb_to_sgvec always X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Jason A. Donenfeld Cc: Steffen Klassert Cc: Herbert Xu Cc: "David S. Miller" --- net/ipv4/ah4.c | 8 ++++++-- net/ipv4/esp4.c | 30 ++++++++++++++++++++---------- net/ipv6/ah6.c | 8 ++++++-- net/ipv6/esp6.c | 31 +++++++++++++++++++++---------- 4 files changed, 53 insertions(+), 24 deletions(-) diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c index 22377c8ff14b..e8f862358518 100644 --- a/net/ipv4/ah4.c +++ b/net/ipv4/ah4.c @@ -220,7 +220,9 @@ static int ah_output(struct xfrm_state *x, struct sk_buff *skb) ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low); sg_init_table(sg, nfrags + sglists); - skb_to_sgvec_nomark(skb, sg, 0, skb->len); + err = skb_to_sgvec_nomark(skb, sg, 0, skb->len); + if (unlikely(err < 0)) + goto out_free; if (x->props.flags & XFRM_STATE_ESN) { /* Attach seqhi sg right after packet payload */ @@ -393,7 +395,9 @@ static int ah_input(struct xfrm_state *x, struct sk_buff *skb) skb_push(skb, ihl); sg_init_table(sg, nfrags + sglists); - skb_to_sgvec_nomark(skb, sg, 0, skb->len); + err = skb_to_sgvec_nomark(skb, sg, 0, skb->len); + if (unlikely(err < 0)) + goto out_free; if (x->props.flags & XFRM_STATE_ESN) { /* Attach seqhi sg right after packet payload */ diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index b1e24446e297..42cb09cc8533 100644 --- a/net/ipv4/esp4.c +++ b/net/ipv4/esp4.c @@ -360,9 +360,13 @@ static int esp_output(struct xfrm_state *x, struct sk_buff *skb) esph = esp_output_set_extra(skb, esph, extra); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); + if (unlikely(err < 0)) { + spin_unlock_bh(&x->lock); + goto error; + } allocsize = ALIGN(skb->data_len, L1_CACHE_BYTES); @@ -381,11 +385,13 @@ static int esp_output(struct xfrm_state *x, struct sk_buff *skb) pfrag->offset = pfrag->offset + allocsize; sg_init_table(dsg, skb_shinfo(skb)->nr_frags + 1); - skb_to_sgvec(skb, dsg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, dsg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); spin_unlock_bh(&x->lock); + if (unlikely(err < 0)) + goto error; goto skip_cow2; } @@ -422,9 +428,11 @@ static int esp_output(struct xfrm_state *x, struct sk_buff *skb) esph = esp_output_set_extra(skb, esph, extra); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); + if (unlikely(err < 0)) + goto error; skip_cow2: if ((x->props.flags & XFRM_STATE_ESN)) @@ -658,7 +666,9 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb) esp_input_set_header(skb, seqhi); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, 0, skb->len); + err = skb_to_sgvec(skb, sg, 0, skb->len); + if (unlikely(err < 0)) + goto out; skb->ip_summed = CHECKSUM_NONE; diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c index dda6035e3b84..755f38271dd5 100644 --- a/net/ipv6/ah6.c +++ b/net/ipv6/ah6.c @@ -423,7 +423,9 @@ static int ah6_output(struct xfrm_state *x, struct sk_buff *skb) ah->seq_no = htonl(XFRM_SKB_CB(skb)->seq.output.low); sg_init_table(sg, nfrags + sglists); - skb_to_sgvec_nomark(skb, sg, 0, skb->len); + err = skb_to_sgvec_nomark(skb, sg, 0, skb->len); + if (unlikely(err < 0)) + goto out_free; if (x->props.flags & XFRM_STATE_ESN) { /* Attach seqhi sg right after packet payload */ @@ -606,7 +608,9 @@ static int ah6_input(struct xfrm_state *x, struct sk_buff *skb) ip6h->hop_limit = 0; sg_init_table(sg, nfrags + sglists); - skb_to_sgvec_nomark(skb, sg, 0, skb->len); + err = skb_to_sgvec_nomark(skb, sg, 0, skb->len); + if (unlikely(err < 0)) + goto out_free; if (x->props.flags & XFRM_STATE_ESN) { /* Attach seqhi sg right after packet payload */ diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c index ff54faa75631..017e2c2d36e1 100644 --- a/net/ipv6/esp6.c +++ b/net/ipv6/esp6.c @@ -339,9 +339,13 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb) esph = esp_output_set_esn(skb, esph, seqhi); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); + if (unlikely(err < 0)) { + spin_unlock_bh(&x->lock); + goto error; + } allocsize = ALIGN(skb->data_len, L1_CACHE_BYTES); @@ -360,12 +364,15 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb) pfrag->offset = pfrag->offset + allocsize; sg_init_table(dsg, skb_shinfo(skb)->nr_frags + 1); - skb_to_sgvec(skb, dsg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, dsg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); spin_unlock_bh(&x->lock); + if (unlikely(err < 0)) + goto error; + goto skip_cow2; } } @@ -403,9 +410,11 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb) esph = esp_output_set_esn(skb, esph, seqhi); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, - (unsigned char *)esph - skb->data, - assoclen + ivlen + clen + alen); + err = skb_to_sgvec(skb, sg, + (unsigned char *)esph - skb->data, + assoclen + ivlen + clen + alen); + if (unlikely(err < 0)) + goto error; skip_cow2: if ((x->props.flags & XFRM_STATE_ESN)) @@ -600,7 +609,9 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb) esp_input_set_header(skb, seqhi); sg_init_table(sg, nfrags); - skb_to_sgvec(skb, sg, 0, skb->len); + ret = skb_to_sgvec(skb, sg, 0, skb->len); + if (unlikely(ret < 0)) + goto out; skb->ip_summed = CHECKSUM_NONE;