| Message ID | 20170510055226.5mlkw654cl6djc65@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Wed, May 10, 2017 at 08:52:26AM +0300, Dan Carpenter wrote: > We checked (nbytes < bsize) inside the loops so it's not possible to hit > the "goto done;" here. This code is cut and paste from other slightly > different loops where we don't have the check inside the loop. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Patch applied. Thanks.
diff --git a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c index 24ac9fad832d..d61e57960fe0 100644 --- a/arch/x86/crypto/glue_helper.c +++ b/arch/x86/crypto/glue_helper.c @@ -176,9 +176,6 @@ __glue_cbc_decrypt_128bit(const struct common_glue_ctx *gctx, src -= 1; dst -= 1; } while (nbytes >= func_bytes); - - if (nbytes < bsize) - goto done; } }
We checked (nbytes < bsize) inside the loops so it's not possible to hit the "goto done;" here. This code is cut and paste from other slightly different loops where we don't have the check inside the loop. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>