Patchwork [7/8] drm: remove unsafe drm_for_each_connector()

login
register
mail settings
Submitter Gustavo F. Padovan
Date May 11, 2017, 7:10 p.m.
Message ID <20170511191049.28944-8-gustavo@padovan.org>
Download mbox | patch
Permalink /patch/9722785/
State New
Headers show

Comments

Gustavo F. Padovan - May 11, 2017, 7:10 p.m.
From: Gustavo Padovan <gustavo.padovan@collabora.com>

After converting all users to drm_for_each_connector_iter() we no
longer need drm_for_each_connector() so we can go ahead and remove it.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
 include/drm/drm_connector.h | 15 ---------------
 1 file changed, 15 deletions(-)
Daniel Vetter - May 12, 2017, 7:51 a.m.
On Thu, May 11, 2017 at 04:10:48PM -0300, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
> 
> After converting all users to drm_for_each_connector_iter() we no
> longer need drm_for_each_connector() so we can go ahead and remove it.
> 
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  include/drm/drm_connector.h | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
> index 4eeda12..ffb8ec1 100644
> --- a/include/drm/drm_connector.h
> +++ b/include/drm/drm_connector.h
> @@ -989,21 +989,6 @@ void drm_mode_put_tile_group(struct drm_device *dev,
>  			     struct drm_tile_group *tg);
>  
>  /**
> - * drm_for_each_connector - iterate over all connectors
> - * @connector: the loop cursor
> - * @dev: the DRM device
> - *
> - * Iterate over all connectors of @dev.
> - *
> - * WARNING:
> - *
> - * This iterator is not safe against hotadd/removal of connectors and is
> - * deprecated. Use drm_for_each_connector_iter() instead.
> - */
> -#define drm_for_each_connector(connector, dev) \
> -	list_for_each_entry(connector, &(dev)->mode_config.connector_list, head)
> -
> -/**
>   * struct drm_connector_list_iter - connector_list iterator
>   *
>   * This iterator tracks state needed to be able to walk the connector_list
> -- 
> 2.9.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index 4eeda12..ffb8ec1 100644
--- a/include/drm/drm_connector.h
+++ b/include/drm/drm_connector.h
@@ -989,21 +989,6 @@  void drm_mode_put_tile_group(struct drm_device *dev,
 			     struct drm_tile_group *tg);
 
 /**
- * drm_for_each_connector - iterate over all connectors
- * @connector: the loop cursor
- * @dev: the DRM device
- *
- * Iterate over all connectors of @dev.
- *
- * WARNING:
- *
- * This iterator is not safe against hotadd/removal of connectors and is
- * deprecated. Use drm_for_each_connector_iter() instead.
- */
-#define drm_for_each_connector(connector, dev) \
-	list_for_each_entry(connector, &(dev)->mode_config.connector_list, head)
-
-/**
  * struct drm_connector_list_iter - connector_list iterator
  *
  * This iterator tracks state needed to be able to walk the connector_list