Message ID | 20170524145212.27837-27-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <intel-gfx-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AA27E60209 for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 24 May 2017 14:54:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A06962899A for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 24 May 2017 14:54:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 953DF2899D; Wed, 24 May 2017 14:54:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C66332899A for <patchwork-intel-gfx@patchwork.kernel.org>; Wed, 24 May 2017 14:54:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 337126E776; Wed, 24 May 2017 14:53:10 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DB526E77C for <intel-gfx@lists.freedesktop.org>; Wed, 24 May 2017 14:52:55 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id d127so47737841wmf.1 for <intel-gfx@lists.freedesktop.org>; Wed, 24 May 2017 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dj4dER3ma4TnLqKNz8W7S6/dsB+V8x96vWaTMZJ0RJo=; b=BflipmW5Z3NYH913+RPvpTLmUzcSLCvRW0Otmun5n1gMu4crSTtl6NFt1C0jNfkqAc gJyWBho3mjEvtRV+3HXvJmDt5ExJhzAXnUv4vAztaz90gAfUi4ueGErudnSXuSShHvW/ WfIVwPm2j7879/TqZEZ+7eJ4YOilKdyItkvRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dj4dER3ma4TnLqKNz8W7S6/dsB+V8x96vWaTMZJ0RJo=; b=RlPFUF+QPXynaIzYnn5ceDTXr71QJK6leh1qY5j1U1kAlgCPrdaKaCeUOp013XeCvh Lec9awfz1qBnP0hr3/9T6w1R+1D9fRBdG4qkuKvoH4gVPxIqJZnFZtzdYk2PGtTerCiG pjXkCQ+EgGE5CqTAts4+UACHWKQ+kogXMv5VBjhlieaqTxJSx0i0gDNfbA6VEaXQ2uIo uofQJOETxFF0IxUMrybr/qYHeygSarKrwqcSGaawATFj+O63xwYTyskch+USrv8uzXZ7 hYt2mwg+wB/+lwfV9B9bbek9J52X2Z7DwSqUoWnRapdcE630L6fm1mUTnJwwPpT4hJ5H jvkQ== X-Gm-Message-State: AODbwcBX3Po+1DBJ1BHgqCACQaJtL+sFIcExR38v75jcrxLngqdXpGpa yGc4zuTWfPNpwiCi X-Received: by 10.80.205.212 with SMTP id h20mr25396105edj.58.1495637574228; Wed, 24 May 2017 07:52:54 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id m9sm1778858edm.62.2017.05.24.07.52.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 07:52:53 -0700 (PDT) From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Date: Wed, 24 May 2017 16:52:01 +0200 Message-Id: <20170524145212.27837-27-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170524145212.27837-1-daniel.vetter@ffwll.ch> References: <20170524145212.27837-1-daniel.vetter@ffwll.ch> Cc: Marek Vasut <marex@denx.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> Subject: [Intel-gfx] [PATCH 26/37] drm/mxsfb: Drop drm_vblank_cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development <intel-gfx.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/intel-gfx> List-Post: <mailto:intel-gfx@lists.freedesktop.org> List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>, <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index d1b9c34c7c00..1853557fef46 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -256,7 +256,6 @@ static void mxsfb_unload(struct drm_device *drm) drm_kms_helper_poll_fini(drm); drm_mode_config_cleanup(drm); - drm_vblank_cleanup(drm); pm_runtime_get_sync(drm->dev); drm_irq_uninstall(drm);
Almost right but still racy, it's called before the interrupts are uninstalled. So let's just drop it. Cc: Marek Vasut <marex@denx.de> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 - 1 file changed, 1 deletion(-)