Message ID | 20170524145212.27837-27-daniel.vetter@ffwll.ch (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <dri-devel-bounces@lists.freedesktop.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8979B60209 for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 24 May 2017 14:56:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EB692896F for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 24 May 2017 14:56:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7202B2899A; Wed, 24 May 2017 14:56:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 204B52896F for <patchwork-dri-devel@patchwork.kernel.org>; Wed, 24 May 2017 14:56:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0BAA6E7A2; Wed, 24 May 2017 14:53:37 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id C2A056E783 for <dri-devel@lists.freedesktop.org>; Wed, 24 May 2017 14:52:55 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id g15so28185771wmc.2 for <dri-devel@lists.freedesktop.org>; Wed, 24 May 2017 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dj4dER3ma4TnLqKNz8W7S6/dsB+V8x96vWaTMZJ0RJo=; b=BflipmW5Z3NYH913+RPvpTLmUzcSLCvRW0Otmun5n1gMu4crSTtl6NFt1C0jNfkqAc gJyWBho3mjEvtRV+3HXvJmDt5ExJhzAXnUv4vAztaz90gAfUi4ueGErudnSXuSShHvW/ WfIVwPm2j7879/TqZEZ+7eJ4YOilKdyItkvRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dj4dER3ma4TnLqKNz8W7S6/dsB+V8x96vWaTMZJ0RJo=; b=edpqma+pivH6IOcadddZWF0+xC8xw4OAN9HWqmONQeghERwYeTjcb3T8OC2SMEcuho FS8+zT5KXc4jhYSb3t3vzTfc9GKU2cHk0QPmCNyS4WbjxXX77VfJUXdBI4S9yuweneyB emDiv9OdMZAl7VO3LXq9rpoRV8fPEEa1oP3pI4c4+GzYYux5quHQGQfg7NC/G04H/7Md iRbq/ByUJGlcNgxIIEGRrp0zHHHVuD0SDXMjQZOVTsmrFpB0Zs1usZFkC0X1NA5Z7Bhb dxwrOqV7FoAQFZjDHpgWWVE8RKY7NMoeUBx2Rre0F0+3gtzF7q7r4DJYOuMACT0D6Pgn Ki0w== X-Gm-Message-State: AODbwcCRGOUF8UFDMn3HhpFa2DNJUopsxNtS8ayTD1NwMcuQwsjZXG65 hDcrNLOx6Ohy6d2F9nA= X-Received: by 10.80.205.212 with SMTP id h20mr25396105edj.58.1495637574228; Wed, 24 May 2017 07:52:54 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id m9sm1778858edm.62.2017.05.24.07.52.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 07:52:53 -0700 (PDT) From: Daniel Vetter <daniel.vetter@ffwll.ch> To: DRI Development <dri-devel@lists.freedesktop.org> Subject: [PATCH 26/37] drm/mxsfb: Drop drm_vblank_cleanup Date: Wed, 24 May 2017 16:52:01 +0200 Message-Id: <20170524145212.27837-27-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170524145212.27837-1-daniel.vetter@ffwll.ch> References: <20170524145212.27837-1-daniel.vetter@ffwll.ch> Cc: Marek Vasut <marex@denx.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Daniel Vetter <daniel.vetter@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development <dri-devel.lists.freedesktop.org> List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe> List-Archive: <https://lists.freedesktop.org/archives/dri-devel> List-Post: <mailto:dri-devel@lists.freedesktop.org> List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help> List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>, <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index d1b9c34c7c00..1853557fef46 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -256,7 +256,6 @@ static void mxsfb_unload(struct drm_device *drm) drm_kms_helper_poll_fini(drm); drm_mode_config_cleanup(drm); - drm_vblank_cleanup(drm); pm_runtime_get_sync(drm->dev); drm_irq_uninstall(drm);
Almost right but still racy, it's called before the interrupts are uninstalled. So let's just drop it. Cc: Marek Vasut <marex@denx.de> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 1 - 1 file changed, 1 deletion(-)