gpiolib: remove unused variable 'i'
diff mbox

Message ID 20170530094420.31076-1-colin.king@canonical.com
State New
Headers show

Commit Message

Colin King May 30, 2017, 9:44 a.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Fixes smatch warning: unused variable 'i' [-Wunused-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpio/gpiolib.c                   | 2 --
 sound/soc/generic/audio-graph-scu-card.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Mark Brown May 30, 2017, 10:58 a.m. UTC | #1
On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpio/gpiolib.c                   | 2 --
>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>  2 files changed, 1 insertion(+), 3 deletions(-)

You've got two unrelated patches in one here (as a quick review of your
CC list would probably have warned you...).
Colin King May 30, 2017, 11:02 a.m. UTC | #2
On 30/05/17 11:58, Mark Brown wrote:
> On Tue, May 30, 2017 at 10:44:20AM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Fixes smatch warning: unused variable 'i' [-Wunused-variable]
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/gpio/gpiolib.c                   | 2 --
>>  sound/soc/generic/audio-graph-scu-card.c | 2 +-
>>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> You've got two unrelated patches in one here (as a quick review of your
> CC list would probably have warned you...).
> 
Oops, my bad. V2 resent.

Patch
diff mbox

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index be8097097326..62ffb4e293d2 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1471,8 +1471,6 @@  static struct gpio_chip *find_chip_by_name(const char *name)
 
 static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip)
 {
-	int i;
-
 	if (!gpiochip->irq_need_valid_mask)
 		return 0;
 
diff --git a/sound/soc/generic/audio-graph-scu-card.c b/sound/soc/generic/audio-graph-scu-card.c
index c5c52d1f500c..e15f63c74f59 100644
--- a/sound/soc/generic/audio-graph-scu-card.c
+++ b/sound/soc/generic/audio-graph-scu-card.c
@@ -246,7 +246,7 @@  static int asoc_graph_card_parse_of(struct graph_card_data *priv)
 			continue;
 
 		if (rcpu_ep != cpu_ep) {
-			dev_err(dev, "remote-endpoint missmatch (%s/%s/%s)\n",
+			dev_err(dev, "remote-endpoint mismatch (%s/%s/%s)\n",
 				cpu_ep->name, codec_ep->name, rcpu_ep->name);
 			ret = -EINVAL;
 			goto parse_of_err;