| Message ID | 1496222871-12996-3-git-send-email-shobhit.kumar@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Shobhit,
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Shobhit-Kumar/drm-i915-Encapsulate-the-pwm_device-in-a-pwm_info-structure/20170531-222631
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-i0-201722 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> ERROR: "pwm_add_table" [drivers/pwm/pwm-lpss-platform.ko] undefined!
>> ERROR: "pwm_remove_table" [drivers/pwm/pwm-lpss-platform.ko] undefined!
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Wednesday 31 May 2017 10:16 PM, kbuild test robot wrote: > Hi Shobhit, > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on v4.12-rc3 next-20170531] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] Guess this needs to be built with CONFIG_PWM_LPSS_PLATFORM=y. Else I would have to send a patch to do EXPORT_SYMBOL_GPL for missing symbols. But then all the drivers that depend on this one are actually in-built. Any suggestions ? Regards Shobhit > > url: https://github.com/0day-ci/linux/commits/Shobhit-Kumar/drm-i915-Encapsulate-the-pwm_device-in-a-pwm_info-structure/20170531-222631 > base: git://anongit.freedesktop.org/drm-intel for-linux-next > config: x86_64-randconfig-i0-201722 (attached as .config) > compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > >>> ERROR: "pwm_add_table" [drivers/pwm/pwm-lpss-platform.ko] undefined! >>> ERROR: "pwm_remove_table" [drivers/pwm/pwm-lpss-platform.ko] undefined! > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c index 5d6ed15..f157a6d 100644 --- a/drivers/pwm/pwm-lpss-platform.c +++ b/drivers/pwm/pwm-lpss-platform.c @@ -40,6 +40,11 @@ static const struct pwm_lpss_boardinfo pwm_lpss_bxt_info = { .bypass = true, }; +/* PWM consumed by the Intel GFX */ +static struct pwm_lookup lpss_pwm_lookup[] = { + PWM_LOOKUP("80860F09:00", 0, "0000:00:02.0", "pwm_lpss", 0, PWM_POLARITY_NORMAL), +}; + static int pwm_lpss_probe_platform(struct platform_device *pdev) { const struct pwm_lpss_boardinfo *info; @@ -60,6 +65,9 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev) platform_set_drvdata(pdev, lpwm); + /* Register intel-gfx device as allowed consumer */ + pwm_add_table(lpss_pwm_lookup, ARRAY_SIZE(lpss_pwm_lookup)); + pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); @@ -71,6 +79,10 @@ static int pwm_lpss_remove_platform(struct platform_device *pdev) struct pwm_lpss_chip *lpwm = platform_get_drvdata(pdev); pm_runtime_disable(&pdev->dev); + + /* remove lookup table */ + pwm_remove_table(lpss_pwm_lookup, ARRAY_SIZE(lpss_pwm_lookup)); + return pwm_lpss_remove(lpwm); }
v2: Rebase on latest code and correct the device name in lookup table (viric) Remove lookup table on driver remove Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96571 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90075 Cc: cbrookes@gmail.com Cc: jani.nikula@linux.intel.com Tested-by: Lluís Batlle i Rossell <viric@viric.name> Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com> --- drivers/pwm/pwm-lpss-platform.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)