| Message ID | 20170531205951.30852-8-dmitry.torokhov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dmitry,
[auto build test ERROR on hid/for-next]
[also build test ERROR on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/HID-Consolidate-serializing-ope-close-in-transport-drivers/20170601-092350
base: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/staging//greybus/hid.c: In function 'gb_hid_open':
>> drivers/staging//greybus/hid.c:352:10: error: 'struct hid_device' has no member named 'open'
if (!hid->open++) {
^~
drivers/staging//greybus/hid.c:355:7: error: 'struct hid_device' has no member named 'open'
hid->open--;
^~
drivers/staging//greybus/hid.c: In function 'gb_hid_close':
drivers/staging//greybus/hid.c:374:12: error: 'struct hid_device' has no member named 'open'
if (!--hid->open) {
^~
vim +352 drivers/staging//greybus/hid.c
96eab779 Viresh Kumar 2015-03-16 346 static int gb_hid_open(struct hid_device *hid)
96eab779 Viresh Kumar 2015-03-16 347 {
96eab779 Viresh Kumar 2015-03-16 348 struct gb_hid *ghid = hid->driver_data;
96eab779 Viresh Kumar 2015-03-16 349 int ret = 0;
96eab779 Viresh Kumar 2015-03-16 350
96eab779 Viresh Kumar 2015-03-16 351 mutex_lock(&gb_hid_open_mutex);
96eab779 Viresh Kumar 2015-03-16 @352 if (!hid->open++) {
96eab779 Viresh Kumar 2015-03-16 353 ret = gb_hid_set_power(ghid, GB_HID_TYPE_PWR_ON);
96eab779 Viresh Kumar 2015-03-16 354 if (ret < 0)
96eab779 Viresh Kumar 2015-03-16 355 hid->open--;
:::::: The code at line 352 was first introduced by commit
:::::: 96eab779e1985fd0b39426d288d3af38e3bce50c greybus: hid: add HID class driver
:::::: TO: Viresh Kumar <viresh.kumar@linaro.org>
:::::: CC: Greg Kroah-Hartman <greg@kroah.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Hi Dmitry,
[auto build test WARNING on hid/for-next]
[also build test WARNING on v4.12-rc3 next-20170531]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dmitry-Torokhov/HID-Consolidate-serializing-ope-close-in-transport-drivers/20170601-092350
base: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-next
config: x86_64-randconfig-h0-06010835 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from arch/x86/include/asm/bitops.h:15:0,
from include/linux/bitops.h:36,
from drivers/staging/greybus/hid.c:10:
drivers/staging/greybus/hid.c: In function 'gb_hid_open':
drivers/staging/greybus/hid.c:352:10: error: 'struct hid_device' has no member named 'open'
if (!hid->open++) {
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> drivers/staging/greybus/hid.c:352:2: note: in expansion of macro 'if'
if (!hid->open++) {
^
drivers/staging/greybus/hid.c:352:10: error: 'struct hid_device' has no member named 'open'
if (!hid->open++) {
^
include/linux/compiler.h:160:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
>> drivers/staging/greybus/hid.c:352:2: note: in expansion of macro 'if'
if (!hid->open++) {
^
drivers/staging/greybus/hid.c:352:10: error: 'struct hid_device' has no member named 'open'
if (!hid->open++) {
^
include/linux/compiler.h:171:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^
>> drivers/staging/greybus/hid.c:352:2: note: in expansion of macro 'if'
if (!hid->open++) {
^
drivers/staging/greybus/hid.c:355:7: error: 'struct hid_device' has no member named 'open'
hid->open--;
^
In file included from arch/x86/include/asm/bitops.h:15:0,
from include/linux/bitops.h:36,
from drivers/staging/greybus/hid.c:10:
drivers/staging/greybus/hid.c: In function 'gb_hid_close':
drivers/staging/greybus/hid.c:374:12: error: 'struct hid_device' has no member named 'open'
if (!--hid->open) {
^
include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
drivers/staging/greybus/hid.c:374:2: note: in expansion of macro 'if'
if (!--hid->open) {
^
drivers/staging/greybus/hid.c:374:12: error: 'struct hid_device' has no member named 'open'
if (!--hid->open) {
^
include/linux/compiler.h:160:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^
drivers/staging/greybus/hid.c:374:2: note: in expansion of macro 'if'
if (!--hid->open) {
^
drivers/staging/greybus/hid.c:374:12: error: 'struct hid_device' has no member named 'open'
if (!--hid->open) {
^
include/linux/compiler.h:171:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^
drivers/staging/greybus/hid.c:374:2: note: in expansion of macro 'if'
if (!--hid->open) {
^
vim +/if +352 drivers/staging/greybus/hid.c
96eab779 Viresh Kumar 2015-03-16 336 return 0;
96eab779 Viresh Kumar 2015-03-16 337 }
96eab779 Viresh Kumar 2015-03-16 338
96eab779 Viresh Kumar 2015-03-16 339 static void gb_hid_stop(struct hid_device *hid)
96eab779 Viresh Kumar 2015-03-16 340 {
96eab779 Viresh Kumar 2015-03-16 341 struct gb_hid *ghid = hid->driver_data;
96eab779 Viresh Kumar 2015-03-16 342
96eab779 Viresh Kumar 2015-03-16 343 gb_hid_free_buffers(ghid);
96eab779 Viresh Kumar 2015-03-16 344 }
96eab779 Viresh Kumar 2015-03-16 345
96eab779 Viresh Kumar 2015-03-16 346 static int gb_hid_open(struct hid_device *hid)
96eab779 Viresh Kumar 2015-03-16 347 {
96eab779 Viresh Kumar 2015-03-16 348 struct gb_hid *ghid = hid->driver_data;
96eab779 Viresh Kumar 2015-03-16 349 int ret = 0;
96eab779 Viresh Kumar 2015-03-16 350
96eab779 Viresh Kumar 2015-03-16 351 mutex_lock(&gb_hid_open_mutex);
96eab779 Viresh Kumar 2015-03-16 @352 if (!hid->open++) {
96eab779 Viresh Kumar 2015-03-16 353 ret = gb_hid_set_power(ghid, GB_HID_TYPE_PWR_ON);
96eab779 Viresh Kumar 2015-03-16 354 if (ret < 0)
96eab779 Viresh Kumar 2015-03-16 355 hid->open--;
96eab779 Viresh Kumar 2015-03-16 356 else
96eab779 Viresh Kumar 2015-03-16 357 set_bit(GB_HID_STARTED, &ghid->flags);
96eab779 Viresh Kumar 2015-03-16 358 }
96eab779 Viresh Kumar 2015-03-16 359 mutex_unlock(&gb_hid_open_mutex);
96eab779 Viresh Kumar 2015-03-16 360
:::::: The code at line 352 was first introduced by commit
:::::: 96eab779e1985fd0b39426d288d3af38e3bce50c greybus: hid: add HID class driver
:::::: TO: Viresh Kumar <viresh.kumar@linaro.org>
:::::: CC: Greg Kroah-Hartman <greg@kroah.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/include/linux/hid.h b/include/linux/hid.h index 5501eb64dbc4..72e8ac667771 100644 --- a/include/linux/hid.h +++ b/include/linux/hid.h @@ -548,7 +548,6 @@ struct hid_device { /* device report descriptor */ void *hiddev; /* The hiddev structure */ void *hidraw; - int open; /* is the device open by anyone? */ char name[128]; /* Device name */ char phys[64]; /* Device physical location */ char uniq[64]; /* Device unique identifier (serial #) */
Now that all users have migrated to use hid->ll_open_count, we can remove hid->open field. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- include/linux/hid.h | 1 - 1 file changed, 1 deletion(-)