From patchwork Wed May 31 22:52:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9758493 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2CA0060360 for ; Wed, 31 May 2017 22:54:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1CCFE2766D for ; Wed, 31 May 2017 22:54:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0FB67284D2; Wed, 31 May 2017 22:54:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80CE22766D for ; Wed, 31 May 2017 22:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751004AbdEaWyZ (ORCPT ); Wed, 31 May 2017 18:54:25 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:9916 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdEaWyY (ORCPT ); Wed, 31 May 2017 18:54:24 -0400 X-IronPort-AV: E=Sophos;i="5.39,276,1493654400"; d="scan'208";a="23043799" Received: from mail-bn3nam01lp0182.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) ([216.32.180.182]) by ob1.hgst.iphmx.com with ESMTP; 01 Jun 2017 06:53:14 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TcP/l+lMeYwt9fs+Ve5gI4dWPYSRu61tDpBESZWaH/4=; b=IAjhK8XoNlTaVFSXuBOwnmLbbr7NrwHq7XBJB4JFNj4oc+wddh1jLorauz8P26hxnXAyvsl8FZFCpurSKn7vXBmfSYlCBCHj/K9BREfiP6eOkJdHJMVWMsrlmVziZv1pPapJWoy6m8xMTdlJmhR2ypfNSXjB5eOaxNBFT2iOjjw= Received: from BLUPR0401CA0022.namprd04.prod.outlook.com (10.162.114.160) by BN6PR04MB0389.namprd04.prod.outlook.com (10.173.198.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Wed, 31 May 2017 22:52:57 +0000 Received: from SN1NAM04FT018.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4c::205) by BLUPR0401CA0022.outlook.office365.com (2a01:111:e400:525a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9 via Frontend Transport; Wed, 31 May 2017 22:52:57 +0000 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; kernel.dk; dkim=none (message not signed) header.d=none;kernel.dk; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 63.163.107.225 as permitted sender) receiver=protection.outlook.com; client-ip=63.163.107.225; helo=milsmgep14.sandisk.com; Received: from milsmgep14.sandisk.com (63.163.107.225) by SN1NAM04FT018.mail.protection.outlook.com (10.152.88.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.1101.12 via Frontend Transport; Wed, 31 May 2017 22:52:56 +0000 Received: from MILHUBIP03.sdcorp.global.sandisk.com (Unknown_Domain [10.201.67.162]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 61.EC.38445.7494F295; Wed, 31 May 2017 15:52:55 -0700 (PDT) Received: from milsmgip12.sandisk.com (10.177.8.100) by MILHUBIP03.sdcorp.global.sandisk.com (10.177.9.96) with Microsoft SMTP Server id 14.3.319.2; Wed, 31 May 2017 15:52:50 -0700 X-AuditID: 0ac94371-422569800000962d-39-592f49474fb5 Received: from exp-402881.sdcorp.global.sandisk.com ( [10.177.8.100]) by (Symantec Messaging Gateway) with SMTP id 8D.1F.18148.1494F295; Wed, 31 May 2017 15:52:49 -0700 (PDT) From: Bart Van Assche To: Jens Axboe CC: , Christoph Hellwig , "Bart Van Assche" , Hannes Reinecke , "Omar Sandoval" , Ming Lei Subject: [PATCH v2 05/12] blk-mq: Initialize a request before assigning a tag Date: Wed, 31 May 2017 15:52:39 -0700 Message-ID: <20170531225246.26261-6-bart.vanassche@sandisk.com> X-Mailer: git-send-email 2.12.2 In-Reply-To: <20170531225246.26261-1-bart.vanassche@sandisk.com> References: <20170531225246.26261-1-bart.vanassche@sandisk.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsXCddJ5ka67p36kwf5Hwhar7/azWSx4s5fN YuXqo0wWe29pWxya3MxkcfjeVRYHNo+Jze/YPS6fLfXYfbOBzeP9vqtsHuu3XGXx+LxJLoAt issmJTUnsyy1SN8ugStj7cUFrAVfhCsOvVrH1sC4QqCLkZNDQsBEonv3FMYuRi4OIYGlTBI/ Jy1ignB2MErM2baXCabqz7MfLBCJzYwSW6/fYQdJsAkYSXx7P5MFxBYRUJDo+b2SDaSIWeAK o8Tay9/ZQBLCAr4Sz043sHYxcnCwCKhKXN3lA2LyCthL7FvgBjFfXuLslp3MIDangIPE6u0n wMYLAZVsOvIYbKSEwCJWiUVL1oEV8QoISpyc+QRsL7OAhMTBFy+YIRrUJU4umc80gVFoFpKy WUjKFjAyrWIUy83MKc5NTy0wNNErTsxLySzO1kvOz93ECAn/wh2Mr297H2IU4GBU4uEVuKgX KcSaWFZcmXuIUYKDWUmE11dNP1KINyWxsiq1KD++qDQntfgQozQHi5I4b5bs1AghgfTEktTs 1NSC1CKYLBMHp1QD42GG5TUiVbMZJsiY3lLjXGp32cH6nJFaK1dM4/o3Yssirjf237DJ/nVd V/Hwrt3B13/d6Tr3MW+ZoeNROXEFs7YZ6xfldS2Jtfr+f071yjzJRPOJW2RYfv461nnH/eAS 1S6JsNlcZr7T74c1MIb7JsZWZ7VlzTH2FdxnYLIraD47/+5Sho8NSizFGYmGWsxFxYkAciFL oHsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOJMWRmVeSWpSXmKPExsXCtZEjRdfRUz/S4NZ9UYvVd/vZLA7+bGO0 WPBmL5vFytVHmSz23tK2ODS5mcni8L2rLA7sHhOb37F7XD5b6rH7ZgObx/t9V9k8pq05z+Sx fstVFo/Pm+QC2KO4bFJSczLLUov07RK4MtZeXMBa8EW44tCrdWwNjCsEuhg5OSQETCT+PPvB AmILCWxklDj5Sh/EZhMwkvj2fiZYXERAQaLn90q2LkYuDmaBG4wSd6ZMZQNJCAv4Sjw73cDa xcjBwSKgKnF1lw9ImFfAXqJ37ypmiPnyEme37ASzOQUcJFZvP8EOscteYtORx2wTGLkXMDKs YhTLzcwpzk3PLDA00itOzEvJLM7WS87P3cQIDhrOqB2M1yeaH2Jk4uCUamAss1CWX2LEe3BW fNTEYwvd47drHDFyP1wc/9do6oGf2w+Z89YJH9/9c9q5qpfKSfFqxYFbvuseNHu/IuRd1/Pa QxVWMXGzT6/Mze62vWWwPH4Z9zZbFzZxvUeB17/9D8laxdHynFlq8o8bBUazvPj4ZRoj7R88 ajFg2nnty/0788tWajE6P3RVYinOSDTUYi4qTgQAFGURD8oBAAA= MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:63.163.107.225; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(39450400003)(39860400002)(39410400002)(39400400002)(39850400002)(39840400002)(2980300002)(438002)(9170700003)(50226002)(8676002)(8936002)(81166006)(5003940100001)(50986999)(54906002)(356003)(77096006)(33646002)(189998001)(76176999)(50466002)(5660300001)(47776003)(48376002)(478600001)(6666003)(6916009)(106466001)(72206003)(305945005)(1076002)(2950100002)(4326008)(2906002)(86362001)(38730400002)(36756003)(110136004)(53936002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0389; H:milsmgep14.sandisk.com; FPR:; SPF:Pass; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM04FT018; 1:LJG3+y7//7yw/zQ4lXq+Xg96wJIMQUpzxgMsHAQwd3U+voayAFplSfG61ZBN6xDM6NVYycoFZJqexkjqVy7irZK8p1eepBq6a3mrnCZTl+KcUvUFxUuneCiXLbcwsfn/D0QnE5MRFptIvDQvrzc8Yqr0is3hLOp3clheSDW+rPs3tOiMidrrm1pqudhGtPi9u5ezPUudBmFDClZ8p8Vgw+/YagIMZ1spgjjoS/FX/7nPALhKeUySBdKlN1lG2gPY2xPeSBCK89aMZ7Qn8C9LKNh8nGTFZXpLqKlZIlzVk47w8RMnSMD2+O7RTUo18GQ1U/CBnuWbtz0ClEXJ960VUZFW8LSc6OrWCrlYEVUHIMvRkzKrIo5wHxjPMIPc+mXKcdrmcyuucoppteIddMswfiDc5j4dweIiIZrIX4YZZkZne4/HI9YSDAp5CH5izwdQtOFucHf6S6QEcIpOtWDlIC2fBAeqF0mgugkRHXyFXSUjoOe8LRPdfcD00iG0hfBe X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR04MB0389: X-MS-Office365-Filtering-Correlation-Id: 4633ab1c-0306-4031-9cf2-08d4a877c7d8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002)(2017030254075)(201703131423075)(201703031133081); SRVR:BN6PR04MB0389; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 3:SsJiXCtoVqDr3i8B5+TrVn3yfD8LijIADjfuZDj9aOC+1SFVhOO+qfcJ5NZVPMQWgeoKGA+ot3FkZffmnValPXQANYY+0dPQdewKafIP+JjUl42C9fi/EKAsDcLrZ3EkbW+b2xmZwb2uUqydGxIpWVexnapo+dZUaBDRr4VGi1YAl9CaCxRm3N2XglBhQpmILwAgDr+x11zbG3JQcYim9RXSzqW9wxplrO5cKtHX9VfgSepShSJIIt+wfAbFI6URq/iHFAAM9uUDaHB+cZAxsVQeBNDgY3/L1jktv5sH1BvB94QNN/0QAgnppIidXFeLXA/H2z58U7lXW9aZ3mY/CvZsORtsRlk0EmPLbLPYdd6jEisqSouyptmUGSG1SB570+TVzIq5rTmqZ99M0MvYCyGF+CrNJ3wCyBAQpC23J/wxI7X1LWT4df29Xu9HZOZB2dv7JwZ7oh0qXa4NLVZxMRimaCOQjPi+YlYRZSmHsTevitf8ZZ8CpkTPsBXTUl7g X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 25:yCWiU17Z6tEIcQD70HJMuJbby9KAqjyfNiWNZHEmy1JmNWI8E8uqxacwUa+EMv7spAXEuDbzxqdXN+2YbYGQo/ehHcgFsp6jYUGMsnUPMRMEKKKgYnQDoesDhRWmbQUwu7TtngbQP+glbq4GaYFR4nkYPbO0zbbXRn6fpU2TPA/4w/8u8a7jrIqqTFzp0uqEqmRWnNicYrL1kuWNZykZMGIBRkSjSfJj6f3Sd3cJoqbT2BLdDDo9hoN5wA3taOU4sj6MD4DHmGgHIy4EgwyPM81ihbe+YvCzkctACu4llZ+i/un98gh2NYrzkRwdrY390MPvRD9ux78/XSGXjB0Vkxyg7I+7cy2+7KDKWbGoAm5ROfKIKvUDl9ZB9VUhMViHLB/bPRLuM8Aynez4MX6/vacvXVn8Biqn5/jr0HGnVHWQFW9oQGZI1+ROojnr661RpPxFikWJkHb5ghTzUJUvuYsUzmcW3zNGwk1TAuFUjnE=; 31:Ji9sX3u0FCEdm98B4vqdBuTMLN5bDKjNW8kQiLW0h5SeeZ8birB49qlIVMKOvnhQiytODuJ8T4DSvu24eRQFEgUlKouzOlGN/DA5C4WnXmcz03pfErHB3ctZiJPICtvynGw3k0uiJosQQhd7d0OcAihK87rNbnSAo7DcKAbW+Oza1+HmFIzKRTDEgrCdHSuX6pDLmR8gbQZOhn6cbuAirAuW/OJNphO9kSR3Jo7dynhipdOwogbY8g+2bPK/jTw8 WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 20:5jWHgQtOpVtW1lTirN8pqhDKJTfuZqSnC/tOjrytRWGrjP+fM1bAyT8b3S7w2faozuGuLqStXGrTIPuhpHQU8QOyizxLwaJs946yyBpkjTBSrByaf0WbhtYcR4r5VlSK6L3OZOG57zLWM/UYx5tXGeBKCZRaWhgNoZ1hg1/AOOohq9ZSTKMBHjHBTXwFrq4+cc3yvVNQ8ksviwVGZr2Qa4eLfjQDqcPfdpriO9fY/Pf/vI7Q6c76J1MogvL4Ne8Vhl8uxRZ1pDpUgWVfmf5RZsB7xIXwXGrw/44qw23G7SR1hpT7etk2mgtkBQ4rEr8ffpm/kA/kU3KMv8BavZpem1r7Uv+gNZ+p6UpoCSzVZ4yZJiG5FyNwI0/5dXHdYg6palMWRxpoAupo0dL39pMZBBlDt4fLDiqlwHz7daOXoQ9nvJo5+VbTS/p0ZfMb9M9UFB9du4UxvxD+HJaxeaYKU3rJN5dosEC+skucr+ePtS4lulEJ4mqfURRkAnnZcQGD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(42932892334569); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(13016025)(5005006)(8121501046)(13018025)(10201501046)(93006095)(93004095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148); SRVR:BN6PR04MB0389; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0389; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 4:hquA0CcuRRqVdJsbdx5CLQnUyWJEM4gsnZ7JliaGxVJhnaJdFQzE9ZeW3CYKxPqWfhMgJz4uA+fGq78/+vuPqZj8bhXdZL5cNT88CT8aztcW5GJQb5kjXShO1QrgHvHOJWcBdetItmB2RXnWrQpVXQt7x9qeOXPuXz8v6btDdR72RhB9rs5Njazj8f/ykBUOPrgHtg2oO1PBRiAuukvBXSz/kLcNGElNTtt10O43Q0ofpN7gmnCH1fCKbae8I3dJU9SL0fhS4poktsMJww/hjnCgG8bSpF0t5JJ6ZLI/OQHnwrvgph5tEeLk+t773rPuuR07PC7H/UeBI380MxsN/BKdJWz9N6mOhhoEGlbNaVuHN6Qo0LfvE/bn70GcdnReMKJST6WbE+N3p8GwXKZtMtuCW+5JKuDuhd6+JbCiYoGFuAPOozg2wnn+5zHT9mHaJFi31+ZEX8RmfT1526e8KVfkFGvZqohWOrLMQUWbjBSaM42Hm5ezzgzrScBczVK9uxNdzblsdOfeny45J7mFNFArRl8fN4u3nM9DlPIqeCKyd7pXBUhUaytzP9NEmmWCpli4hFtOdS4szz7ULZ/o6NlHq0Vlg8CCwzfvyf4KiKEqO1++7d2Qs4sJyL0TrZj10xnc3P0BwNpSTV3C+JgII/ibrzO7ouXelGb5P37RZHl5oRAOpERdmaa9aRXez7UQNPLWuNXh1FLJTSKMhYMcoJV9nzZKRNLr2/DCyldLJLqT+SFHEXP9yfaDjmIDrOCnFQwK4Eum9cQ1UeBLyTxDe+6x2dfBJDf+tjogD0DYkcZ7ZY9Byln4VXRRMZeWlXBFfaERXQcTbcxeoAQ6TugBfM6VfWJWT17bFlFpDjfekXr3OUlwM+b+F0RgrpJPPJbpSD+F4NETJJqKc3rSZ1vSlrsk694OvV3ZEfXoSG9Re8 c= X-Forefront-PRVS: 0324C2C0E2 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR04MB0389; 23:HgZoFm9A4DGzXPKKuAzXMJl/prRQ9+JHKKQCKSmcW?= =?us-ascii?Q?o3Zwd/Q3uEDBhjvKCIYT7ftDo2pFVLyhmOd2dGSRtTyrCwwf/DXLQ/uUokhk?= =?us-ascii?Q?We5R26SpRD32wwiBvvAW+O4F6deJeLPOXwanHSDC4K9XynTquAzy8JRX0h0K?= =?us-ascii?Q?WbeGwHIl2VLS+HyG/o2jLeY797PudtKTkrYCfKCsiyXNbkmzL6OW++h1oqht?= =?us-ascii?Q?JFwnPCukmI2iIYjNYPwZXmQF1nu32y6k+u1Y9oTrZtc0VAlA1+Y+YAaFe6XY?= =?us-ascii?Q?BWoJbrcwVpc9oJshOY65r9/fYMAT/gTtuZiBZQvaVHtm16+lP5Dqq6RFhKXi?= =?us-ascii?Q?hU8ya3d5cXuZAGss9ciYAEZ0pHi0mYAXT7D8yPy4E5IOqwDp4onX8oVgddpI?= =?us-ascii?Q?sC4Qs30fQDnIf9HkYfXJMDO9iIR8yTdhsb2slfIDMq41VwTqkRaJlobz7jpw?= =?us-ascii?Q?PEZhEO4mCoPHyBbywAHW+4cw7ofKiq1ujt+NtKg6mMC0ZY8KyH+c+Yuu18J2?= =?us-ascii?Q?E+Q9Pbpfun7k07ktHkLLopUXpA+GCSaqPR3Z1sF9koOiWIeUreV40c4rmV21?= =?us-ascii?Q?uuKuba134bd5ExdY/OePbdNm6usN6DfrqwzCiIn5rQ6AB56q0B3HRq+q6MMk?= =?us-ascii?Q?6EyLdEQZKedsWIijgf+GgmrLGA8rHCC+9ddcGYlHxABhtCpfzXfNXJSoeZbN?= =?us-ascii?Q?kjRjTF3kEDWJbPldRJbbu4bMns7sqA6bjDCZ3nP10/FDarUnfvJmd+kkzjfq?= =?us-ascii?Q?GQPSyZKaiOJVikuSqYUSUTsUzz+vXWSqTWOvwH8uSUDCOVjdrq6zLXwmJ3te?= =?us-ascii?Q?u+cydlx8thgXyxpX+8a9YKDh8NFwLCvCQZgtgQ93Efeac0EAg8FBNY7VF922?= =?us-ascii?Q?BI4KcieXNHb/NQFBPZYhb3zFJ8R7HQf0hXoJfEdXPPkZuNnTtQOFQBI2nAW/?= =?us-ascii?Q?gjgnqMdjxtdiYeAaNP8Mg43ch0hyVmxrFcHVu3ZbRmLxMMpgRluqzmPM+ruE?= =?us-ascii?Q?OCSnfm8wtvsdKrU2JZRIti/ECPEMULGFnu31bRFfiXXRY8EEU/jQ/VaFCJRJ?= =?us-ascii?Q?o9dYYo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 6:pqKwjCZF8AzeIV4YegL0c/fIE/t9yVvNXNkKdCTiK7Zu6+QuLADsZUKvU9ygCZxOec/+RtNel7/kgFTIoZI6CM7asO0Mn679VJsBESY9th/fD9dOO+SCq8UobI8q+rEU+KnovSXqOPUzxrpaRl+LCb9EjGSx8hbYD3aoeapdOHF5TeQqXYk1/3BhAoBLPly3LIs8hxQIiVFKHmtn9C8bLFI77nitoL0Z9E9yFOhUsvcDBPLZDcbTLwx37GoJXyBBtIWJlYPOFYCf7zlPcsAr7gB2BwDZ++sbnTWvC8jyTJxEugxTBtjfJlQU6HHLq1cPTQFndDf+TnoYrnSo/qnxg0a64fPVtvZNWMGxX+wsCEEunl8/4nYRQq1Yfxvl54wurtuWWMVmfFPBKrEbda/syuajkpr1IpmkQt9oQ1GkAU7IIJUp7upP/Kz7bV3lg8u/1U7vznOvUTJXEujz9Z1J+LHcVfXQzXrhYwvRbyxceWdfW0/JPCoJXh1jnqBox91cJLjdh2JxBZOWDY4Ku2O3GcdDLWJFV9FmUQN9yXobkro=; 5:0YhDd8xVaVjaU8WAsCw7ZK9h4gSI5yvDQ3BWMxeYtTbnOGGUFM7jbXT/2dMEr8fwWI4MzIhu74CQss/+qFlcZgiyqfTeO1+qY3+d5PN5Y8ubAh2DaZoqfBCgj4HsRLXMjpT3xbrr2EK8TzyZDvVtBQ==; 24:DTwBQSkd4cjVRggV+VVgkkoeTFKpUbWNkkwRBJ3qkKZqPFTFKZACzKh6uY9grfp6VCepMIOC1bGGRFcJ0TeUEnP3/kvPsztXUeLXcH7Awg0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 7:HbzJ22DMDTmcJ/g6Cvwuo0o95PgseQcVXi65EHmlkORaLOEIbB2uX83nvvYu6RNaiA6BOGYXof/YAFhnQFURNFtWSxYMtpkiArDU4iguCSvt4goYYmKPBDXwAVyoQUrjxPq0Gg7YHuc0LNDkSob+SAv6PtYj3/R6xqXohWOSZMop900Wx/NK8ONJl/nrPCzb/Qgc/DSwioFVXF4n2BCqofZhUJIH4/QHHiuNl5DwZeZypywptLi1eQQl0l1H0JqbyoDepeZJ90yjmYGNsyQQ1m17BwrkztQAUeia/J1EspRfq1rs49Lk8sYp76ICQqGg4AEj9NA0AQzWAl02CxCXhg==; 20:RHe8Ql+Pomc0SKGo7Gd5p4Z1rFFeI1fnwIQHO1pXiKss9WXavKxI+sc10is3sDJYQwSG4VWJe0V1GQYMFSk8d60TM1whKOZ/9bMNk09BDb/piNkigOzWA59S+brHmJYvtiukQ45KfuV7Avj2+alSIUf0u4cwwPP8+OW1sfL2RK8= X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2017 22:52:56.8050 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[63.163.107.225]; Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0389 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initialization of blk-mq requests is a bit weird: blk_mq_rq_ctx_init() is called after a value has been assigned to .rq_flags and .rq_flags is initialized in __blk_mq_finish_request(). Call blk_mq_rq_ctx_init() before modifying any struct request members. Initialize .rq_flags in blk_mq_rq_ctx_init() instead of relying on __blk_mq_finish_request(). Moving the initialization of .rq_flags is fine because all changes and tests of .rq_flags occur between blk_get_request() and finishing a request. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Omar Sandoval Cc: Ming Lei Reviewed-by: Christoph Hellwig --- block/blk-mq.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 9aa1754e938b..488c6ca2ad91 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -212,6 +212,7 @@ void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx, rq->q = q; rq->mq_ctx = ctx; rq->cmd_flags = op; + rq->rq_flags = 0; if (blk_queue_io_stat(q)) rq->rq_flags |= RQF_IO_STAT; /* do not touch atomic flags, it needs atomic ops against the timer */ @@ -231,7 +232,7 @@ void blk_mq_rq_ctx_init(struct request_queue *q, struct blk_mq_ctx *ctx, rq->nr_integrity_segments = 0; #endif rq->special = NULL; - /* tag was already set */ + /* tag will be set by caller */ rq->extra_len = 0; INIT_LIST_HEAD(&rq->timeout_list); @@ -257,12 +258,14 @@ struct request *__blk_mq_alloc_request(struct blk_mq_alloc_data *data, rq = tags->static_rqs[tag]; + blk_mq_rq_ctx_init(data->q, data->ctx, rq, op); + if (data->flags & BLK_MQ_REQ_INTERNAL) { rq->tag = -1; rq->internal_tag = tag; } else { if (blk_mq_tag_busy(data->hctx)) { - rq->rq_flags = RQF_MQ_INFLIGHT; + rq->rq_flags |= RQF_MQ_INFLIGHT; atomic_inc(&data->hctx->nr_active); } rq->tag = tag; @@ -270,7 +273,6 @@ struct request *__blk_mq_alloc_request(struct blk_mq_alloc_data *data, data->hctx->tags->rqs[rq->tag] = rq; } - blk_mq_rq_ctx_init(data->q, data->ctx, rq, op); return rq; } @@ -361,7 +363,6 @@ void __blk_mq_finish_request(struct blk_mq_hw_ctx *hctx, struct blk_mq_ctx *ctx, atomic_dec(&hctx->nr_active); wbt_done(q->rq_wb, &rq->issue_stat); - rq->rq_flags = 0; clear_bit(REQ_ATOM_STARTED, &rq->atomic_flags); clear_bit(REQ_ATOM_POLL_SLEPT, &rq->atomic_flags);