diff mbox

[v3,1/5] acpi, nfit: Switch to use new generic UUID API

Message ID 1496828271.22624.38.camel@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andy Shevchenko June 7, 2017, 9:37 a.m. UTC 
On Wed, 2017-06-07 at 06:25 +0000, Williams, Dan J wrote:
> On Mon, 2017-06-05 at 23:22 +0200, Christoph Hellwig wrote:
> > On Mon, Jun 05, 2017 at 08:10:42PM +0300, Andy Shevchenko wrote:
> > > 
> > > I hope Christoph can replace old version of this series with new
> > > one in
> > > his uuid branch. URL in cover letter, repeating for your
> > > convenience:
> > > 
> > > [1]: git://git.infradead.org/users/hch/uuid.git
> > 
> > Yeah, but I had to drop it again after noticing the guid_equals
> > bits,
> > and after not fixing up the GUID -> GUID_INIT rename.
> > 
> > for-next in the above repo should have the proper base now, and acpi
> > has the ACPI bits for Dan to test.
> 
> With one compile fix below the 'acpi' branch works for me. Please feel
> free to add:
> 
> Tested-by: Dan Williams <dan.j.williams@intel.com>

Thanks, Dan!

I probably missed some configuration option since I have done
compilation many times.

> 
> ...to the changes that touch drivers/acpi/nfit/, drivers/nvdimm/, and
> tools/testing/nvdimm, but I'm ok if you omit it if the branch is about
> to go immutable. Speaking of which, let me know when it does go
> immutable because the new libnvdimm enabling for ACPI 6.2 and EFI 2.7
> needs some new guid handling code.
> 

> Please apply the following or fold it into commit c793ed7ccf42 "ACPI:
> Switch to use generic guid_t in acpi_evaluate_dsm()"

It think we may fold it.

Besides that we might need the following fix as well.

 	params[2].type = ACPI_TYPE_INTEGER;

Comments

Christoph Hellwig June 7, 2017, 10:17 a.m. UTC | #1 
On Wed, Jun 07, 2017 at 12:37:51PM +0300, Andy Shevchenko wrote:
> It think we may fold it.

Yes, I'll fold it and delcare the tree stable late tonight my time.

> Besides that we might need the following fix as well.

Yeah.  Another reasone why buffer.pointer should be a void pointer.
diff mbox

Patch

--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -638,7 +638,7 @@  acpi_evaluate_dsm(acpi_handle handle, const guid_t
*guid, u64 rev, u64 func,
 
 	params[0].type = ACPI_TYPE_BUFFER;
 	params[0].buffer.length = 16;
-	params[0].buffer.pointer = (u8 *)&guid;
+	params[0].buffer.pointer = (u8 *)guid;
 	params[1].type = ACPI_TYPE_INTEGER;
 	params[1].integer.value = rev;