| Message ID | 20170621131157.16584-1-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/21/2017 09:11 AM, Max Reitz wrote: > Test 181 only works for formats which support live migration (naturally, > as it is a live migration test). Disable it for all formats which do > not. > > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/181 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 > index e969a2a..f73ad5a 100755 > --- a/tests/qemu-iotests/181 > +++ b/tests/qemu-iotests/181 > @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.qemu > > _supported_fmt generic > +# Formats that do not support live migration > +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat > _supported_proto generic > _supported_os Linux > > Does this come up elsewhere in iotests? I guess not often enough to justify some macro like formats_unmigratable. Eh. Reviewed-by: John Snow <jsnow@redhat.com>
On 2017-06-26 21:17, John Snow wrote: > > > On 06/21/2017 09:11 AM, Max Reitz wrote: >> Test 181 only works for formats which support live migration (naturally, >> as it is a live migration test). Disable it for all formats which do >> not. >> >> Signed-off-by: Max Reitz <mreitz@redhat.com> >> --- >> tests/qemu-iotests/181 | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 >> index e969a2a..f73ad5a 100755 >> --- a/tests/qemu-iotests/181 >> +++ b/tests/qemu-iotests/181 >> @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >> . ./common.qemu >> >> _supported_fmt generic >> +# Formats that do not support live migration >> +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat >> _supported_proto generic >> _supported_os Linux >> >> > > Does this come up elsewhere in iotests? I guess not often enough to > justify some macro like formats_unmigratable. Well, formats_no_backing might happen more often... > Eh. Don't want to volunteer? :-) > Reviewed-by: John Snow <jsnow@redhat.com> Thanks! Aaand applied to my block branch. Max
diff --git a/tests/qemu-iotests/181 b/tests/qemu-iotests/181 index e969a2a..f73ad5a 100755 --- a/tests/qemu-iotests/181 +++ b/tests/qemu-iotests/181 @@ -43,6 +43,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 . ./common.qemu _supported_fmt generic +# Formats that do not support live migration +_unsupported_fmt qcow vdi vhdx vmdk vpc vvfat _supported_proto generic _supported_os Linux
Test 181 only works for formats which support live migration (naturally, as it is a live migration test). Disable it for all formats which do not. Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/181 | 2 ++ 1 file changed, 2 insertions(+)