diff mbox

[i-g-t,1/3] lib/cfl: Add Coffeelake PCI IDs for S SKU.

Message ID 1498062899-10659-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha June 21, 2017, 4:34 p.m. UTC
From: anushasr <anusha.srivatsa@intel.com>

Just following the spec and adding these extra IDs.

v2: update IDs

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 lib/i915_pciids.h       | 10 ++++++++++
 lib/intel_device_info.c |  2 ++
 2 files changed, 12 insertions(+)

Comments

Chris Wilson June 21, 2017, 4:40 p.m. UTC | #1
Quoting Anusha Srivatsa (2017-06-21 17:34:57)
> From: anushasr <anusha.srivatsa@intel.com>
> 
> Just following the spec and adding these extra IDs.

i915_pciids.h is just a copy from the kernel. So copy across and cite
the upstream kernel commits.
-Chris
Taylor, Clinton A June 21, 2017, 7:44 p.m. UTC | #2
On 06/21/2017 09:34 AM, Anusha Srivatsa wrote:
> From: anushasr <anusha.srivatsa@intel.com>
>
> Just following the spec and adding these extra IDs.
>
> v2: update IDs
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>   lib/i915_pciids.h       | 10 ++++++++++
>   lib/intel_device_info.c |  2 ++
>   2 files changed, 12 insertions(+)
>
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 27e0dba..02f43d9 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -334,4 +334,14 @@
>   	INTEL_KBL_GT3_IDS(info), \
>   	INTEL_KBL_GT4_IDS(info)
>   
> +#define INTEL_CFL_S_IDS(info) \
> +	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
> +	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
> +	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
> +	INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
> +
Matches current documentation
Reviewed-by: Clint Taylor <Clinton.A.Taylor@intel.com>

> +#define INTEL_CFL_IDS(info) \
> +	INTEL_CFL_S_IDS(info)
> +
>   #endif /* _I915_PCIIDS_H */
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 199fa2d..2c46aba 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -241,6 +241,8 @@ static const struct pci_id_match intel_device_match[] = {
>   
>   	INTEL_GLK_IDS(&intel_geminilake_info),
>   
> +	INTEL_CFL_IDS(&intel_coffeelake_info),
> +
>   	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
>   };
>
diff mbox

Patch

diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
index 27e0dba..02f43d9 100644
--- a/lib/i915_pciids.h
+++ b/lib/i915_pciids.h
@@ -334,4 +334,14 @@ 
 	INTEL_KBL_GT3_IDS(info), \
 	INTEL_KBL_GT4_IDS(info)
 
+#define INTEL_CFL_S_IDS(info) \
+	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
+	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
+	INTEL_VGA_DEVICE(0x3E96, info) /* SRV GT2 */
+
+#define INTEL_CFL_IDS(info) \
+	INTEL_CFL_S_IDS(info)
+
 #endif /* _I915_PCIIDS_H */
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 199fa2d..2c46aba 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -241,6 +241,8 @@  static const struct pci_id_match intel_device_match[] = {
 
 	INTEL_GLK_IDS(&intel_geminilake_info),
 
+	INTEL_CFL_IDS(&intel_coffeelake_info),
+
 	INTEL_VGA_DEVICE(PCI_MATCH_ANY, &intel_generic_info),
 };