[2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"
diff mbox

Message ID 20170622175636.22723-2-eric@anholt.net
State New
Headers show

Commit Message

Eric Anholt June 22, 2017, 5:56 p.m. UTC
Signed-off-by: Eric Anholt <eric@anholt.net>
---

This fixup would be squashed into patch 1 of your series.
 drivers/gpu/drm/stm/ltdc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Philippe CORNU June 23, 2017, 2:46 p.m. UTC | #1
On 06/22/2017 07:56 PM, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <eric@anholt.net>

> ---

> 

> This fixup would be squashed into patch 1 of your series.


Hi Eric,
and many thanks for the two patches, I will follow your suggestion for 
the v5 serie.
By the way, do you have more comments on the "drm/stm: ltdc: Add 
panel-bridge support" patch?
Many thanks :-)
Philippe

>   drivers/gpu/drm/stm/ltdc.c | 3 ++-

>   1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c

> index 7d7e889f09c3..d1d28348512b 100644

> --- a/drivers/gpu/drm/stm/ltdc.c

> +++ b/drivers/gpu/drm/stm/ltdc.c

> @@ -953,7 +953,8 @@ int ltdc_load(struct drm_device *ddev)

>   		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);

>   		if (IS_ERR(bridge)) {

>   			DRM_ERROR("Failed to create panel-bridge\n");

> -			return PTR_ERR(bridge);

> +			ret = PTR_ERR(bridge);

> +			goto err;

>   		}

>   		ldev->is_panel_bridge = true;

>   	}

>
Eric Anholt June 23, 2017, 6:18 p.m. UTC | #2
Philippe CORNU <philippe.cornu@st.com> writes:

> On 06/22/2017 07:56 PM, Eric Anholt wrote:
>> Signed-off-by: Eric Anholt <eric@anholt.net>
>> ---
>> 
>> This fixup would be squashed into patch 1 of your series.
>
> Hi Eric,
> and many thanks for the two patches, I will follow your suggestion for 
> the v5 serie.
> By the way, do you have more comments on the "drm/stm: ltdc: Add 
> panel-bridge support" patch?

I think that's all -- I was going to add my r-b and apply that one, when
I found this little nitpick.

Patch
diff mbox

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 7d7e889f09c3..d1d28348512b 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -953,7 +953,8 @@  int ltdc_load(struct drm_device *ddev)
 		bridge = drm_panel_bridge_add(panel, DRM_MODE_CONNECTOR_DPI);
 		if (IS_ERR(bridge)) {
 			DRM_ERROR("Failed to create panel-bridge\n");
-			return PTR_ERR(bridge);
+			ret = PTR_ERR(bridge);
+			goto err;
 		}
 		ldev->is_panel_bridge = true;
 	}