Patchwork vmlfb: Fix error handling in cr_pll_init()

login
register
mail settings
Submitter Alexey Khoroshilov
Date June 22, 2017, 9:43 p.m.
Message ID <1498167814-5178-1-git-send-email-khoroshilov@ispras.ru>
Download mbox | patch
Permalink /patch/9805343/
State New
Headers show

Comments

Alexey Khoroshilov - June 22, 2017, 9:43 p.m.
There is an error path, where iomemory is left mapped.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/video/fbdev/vermilion/cr_pll.c | 1 +
 1 file changed, 1 insertion(+)
Bartlomiej Zolnierkiewicz - July 4, 2017, 2:14 p.m.
On Friday, June 23, 2017 12:43:34 AM Alexey Khoroshilov wrote:
> There is an error path, where iomemory is left mapped.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Patch queued for 4.13, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Patch

diff --git a/drivers/video/fbdev/vermilion/cr_pll.c b/drivers/video/fbdev/vermilion/cr_pll.c
index ebc6e6e0dd0f..ba105c876bed 100644
--- a/drivers/video/fbdev/vermilion/cr_pll.c
+++ b/drivers/video/fbdev/vermilion/cr_pll.c
@@ -185,6 +185,7 @@  static int __init cr_pll_init(void)
 	if (err) {
 		printk(KERN_ERR
 		       "Carillo Ranch failed to initialize vml_sys.\n");
+		iounmap(mch_regs_base);
 		pci_dev_put(mch_dev);
 		return err;
 	}