From patchwork Sun Jun 25 12:31:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?RGF2aWQgSMODwqRyZGVtYW4=?= X-Patchwork-Id: 9808121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 044D6603F3 for ; Sun, 25 Jun 2017 12:31:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E94E826E3A for ; Sun, 25 Jun 2017 12:31:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DDC512858F; Sun, 25 Jun 2017 12:31:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49B2126E40 for ; Sun, 25 Jun 2017 12:31:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751144AbdFYMbW (ORCPT ); Sun, 25 Jun 2017 08:31:22 -0400 Received: from vader.hardeman.nu ([95.142.160.32]:56403 "EHLO hardeman.nu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdFYMbW (ORCPT ); Sun, 25 Jun 2017 08:31:22 -0400 Received: from hardeman.nu (zeus.hardeman.nu [IPv6:fd27:2a41:8fcb:2::a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by vader.hardeman.nu (Postfix) with ESMTPSA id 57839B88; Sun, 25 Jun 2017 14:31:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hardeman.nu; s=hardeman-201705; t=1498393880; bh=UMg/61pK8t18dj8P3ToyjDRtpNUe/sgJCTQ3B0dyWxA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=We37paZZ410PvVrg6wuJjy+pcZVp0YjNncaRC/fxf538IOLea1zRCwpfiwjG8cL5F LHqHfINzGuRgjrV2ej2p6AACucjI+7AG5kHKWWWOL7D9ND99P9k54ozAxWEsIkVu4C xqyDZOtZmvwxM75OwNdIOXVbIeW10s3HhNZot5s+mkKFNE2B5Xfo6rDCIMRBDqX6lr qraD8EGAi39UIc34hjRbaURt3fQmrH5TMt0vGc/L9xP0KYHN2wntgY8KlrhKwntCIX 10m+5YOs4qMjR/FJIXiM1W9DVppOk3YJVmHXIcLNaDqgX51v5ztSyyinozpHHVVW++ spAn2omC4GJ0g== Received: (nullmailer pid 29030 invoked by uid 1000); Sun, 25 Jun 2017 12:31:19 -0000 Subject: [PATCH 01/19] lirc_dev: clarify error handling From: David =?utf-8?b?SMOkcmRlbWFu?= To: linux-media@vger.kernel.org Cc: mchehab@s-opensource.com, sean@mess.org Date: Sun, 25 Jun 2017 14:31:19 +0200 Message-ID: <149839387982.28811.17348183524326346282.stgit@zeus.hardeman.nu> In-Reply-To: <149839373103.28811.9486751698665303339.stgit@zeus.hardeman.nu> References: <149839373103.28811.9486751698665303339.stgit@zeus.hardeman.nu> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If an error is generated, it is more logical to error out ASAP. Signed-off-by: David Härdeman --- drivers/media/rc/lirc_dev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index db1e7b70c998..9c1d55e41e34 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -282,7 +282,7 @@ EXPORT_SYMBOL(lirc_unregister_driver); int lirc_dev_fop_open(struct inode *inode, struct file *file) { struct irctl *ir; - int retval = 0; + int retval; if (iminor(inode) >= MAX_IRCTL_DEVICES) { pr_err("open result for %d is -ENODEV\n", iminor(inode)); @@ -323,9 +323,11 @@ int lirc_dev_fop_open(struct inode *inode, struct file *file) ir->open++; -error: nonseekable_open(inode, file); + return 0; + +error: return retval; } EXPORT_SYMBOL(lirc_dev_fop_open);