| Message ID | 594FB0A4.2050105@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/6/25 20:46, piaojun wrote: > 'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end > of sc_fop_release(). > > Signed-off-by: Jun Piao <piaojun@huawei.com> Looks good. Reviewed-by: Joseph Qi <jiangqi903@gmail.com> Thanks, Joseph > --- > fs/ocfs2/cluster/netdebug.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c > index 564c504..74a21f6 100644 > --- a/fs/ocfs2/cluster/netdebug.c > +++ b/fs/ocfs2/cluster/netdebug.c > @@ -426,6 +426,7 @@ static int sc_fop_release(struct inode *inode, struct file *file) > struct o2net_sock_container *dummy_sc = sd->dbg_sock; > > o2net_debug_del_sc(dummy_sc); > + kfree(dummy_sc); > return seq_release_private(inode, file); > } >
diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index 564c504..74a21f6 100644 --- a/fs/ocfs2/cluster/netdebug.c +++ b/fs/ocfs2/cluster/netdebug.c @@ -426,6 +426,7 @@ static int sc_fop_release(struct inode *inode, struct file *file) struct o2net_sock_container *dummy_sc = sd->dbg_sock; o2net_debug_del_sc(dummy_sc); + kfree(dummy_sc); return seq_release_private(inode, file); }
'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end of sc_fop_release(). Signed-off-by: Jun Piao <piaojun@huawei.com> --- fs/ocfs2/cluster/netdebug.c | 1 + 1 file changed, 1 insertion(+)