[1/1] CIFS: add int cast to silence warning
diff mbox

Message ID 20170626124911.28449-1-aaptel@suse.com
State New
Headers show

Commit Message

Aurelien Aptel June 26, 2017, 12:49 p.m. UTC
The '*' field specifier expects an int and sizeof returns an unsigned
long int but its always going to be a small positive value so casting is
safe.

Signed-off-by: Aurelien Aptel <aaptel@suse.com>
---
 fs/cifs/smb2transport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Steve French June 26, 2017, 4:56 p.m. UTC | #1
I merged this with your previous patch into one and pushed to
cifs-2.6.git for-next

On Mon, Jun 26, 2017 at 7:49 AM, Aurelien Aptel <aaptel@suse.com> wrote:
> The '*' field specifier expects an int and sizeof returns an unsigned
> long int but its always going to be a small positive value so casting is
> safe.
>
> Signed-off-by: Aurelien Aptel <aaptel@suse.com>
> ---
>  fs/cifs/smb2transport.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2transport.c b/fs/cifs/smb2transport.c
> index 437d11711b3e..ad0492c682e7 100644
> --- a/fs/cifs/smb2transport.c
> +++ b/fs/cifs/smb2transport.c
> @@ -349,7 +349,8 @@ generate_smb3signingkey(struct cifs_ses *ses,
>          * print it as a long long. we dump it as we got it on the
>          * wire.
>          */
> -       cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
> +       cifs_dbg(VFS, "Session Id    %*ph\n", (int)sizeof(ses->Suid),
> +                &ses->Suid);
>         cifs_dbg(VFS, "Session Key   %*ph\n",
>                  SMB2_NTLMV2_SESSKEY_SIZE, ses->auth_key.response);
>         cifs_dbg(VFS, "Signing Key   %*ph\n",
> --
> 2.12.3
>

Patch
diff mbox

diff --git a/fs/cifs/smb2transport.c b/fs/cifs/smb2transport.c
index 437d11711b3e..ad0492c682e7 100644
--- a/fs/cifs/smb2transport.c
+++ b/fs/cifs/smb2transport.c
@@ -349,7 +349,8 @@  generate_smb3signingkey(struct cifs_ses *ses,
 	 * print it as a long long. we dump it as we got it on the
 	 * wire.
 	 */
-	cifs_dbg(VFS, "Session Id    %*ph\n", sizeof(ses->Suid), &ses->Suid);
+	cifs_dbg(VFS, "Session Id    %*ph\n", (int)sizeof(ses->Suid),
+		 &ses->Suid);
 	cifs_dbg(VFS, "Session Key   %*ph\n",
 		 SMB2_NTLMV2_SESSKEY_SIZE, ses->auth_key.response);
 	cifs_dbg(VFS, "Signing Key   %*ph\n",