[kvm-unit-tests,v1,1/2] s390x: use instruction 0x0000 to test for operation exceptions
diff mbox

Message ID 20170626161509.18873-2-david@redhat.com
State New
Headers show

Commit Message

David Hildenbrand June 26, 2017, 4:15 p.m. UTC
QEMU uses 0x0000 for KVM, not 0x0001. Doesn't really matter (both are
invalid), but now it matches the comment.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 s390x/selftest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth June 27, 2017, 2:50 a.m. UTC | #1
On 26.06.2017 18:15, David Hildenbrand wrote:
> QEMU uses 0x0000 for KVM, not 0x0001. Doesn't really matter (both are
> invalid), but now it matches the comment.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  s390x/selftest.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/s390x/selftest.c b/s390x/selftest.c
> index ca94158..87eb934 100644
> --- a/s390x/selftest.c
> +++ b/s390x/selftest.c
> @@ -29,7 +29,7 @@ static void test_fp(void)
>  static void test_pgm_int(void)
>  {
>  	expect_pgm_int();
> -	asm volatile("	.insn e,0x0001"); /* used for SW breakpoints in QEMU */
> +	asm volatile("	.insn e,0x0000"); /* used for SW breakpoints in QEMU */
>  	check_pgm_int_code(PGM_INT_CODE_OPERATION);
>  
>  	expect_pgm_int();
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Patch
diff mbox

diff --git a/s390x/selftest.c b/s390x/selftest.c
index ca94158..87eb934 100644
--- a/s390x/selftest.c
+++ b/s390x/selftest.c
@@ -29,7 +29,7 @@  static void test_fp(void)
 static void test_pgm_int(void)
 {
 	expect_pgm_int();
-	asm volatile("	.insn e,0x0001"); /* used for SW breakpoints in QEMU */
+	asm volatile("	.insn e,0x0000"); /* used for SW breakpoints in QEMU */
 	check_pgm_int_code(PGM_INT_CODE_OPERATION);
 
 	expect_pgm_int();