diff mbox

arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

Message ID 1498565735-8208-1-git-send-email-surenderp@techveda.org (mailing list archive)
State New, archived
Headers show

Commit Message

surenderp@techveda.org June 27, 2017, 12:15 p.m. UTC
From: Surender Polsani <surenderp@techveda.org>

"interrupt-parent" property is declared in root node, so it is global
to all nodes. This property is re-declared in few sub-nodes. To avoid
duplication this property is removed from following sub-nodes:
pmu, amba@0, amba@0/ethernet.

Signed-off-by: Surender Polsani <surenderp@techveda.org>
---
 arch/arm/boot/dts/artpec6.dtsi | 3 ---
 1 file changed, 3 deletions(-)

Comments

Niklas Cassel June 27, 2017, 12:27 p.m. UTC | #1
Acked-by: Niklas Cassel <niklas.cassel@axis.com>

On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
> From: Surender Polsani <surenderp@techveda.org>
> 
> "interrupt-parent" property is declared in root node, so it is global
> to all nodes. This property is re-declared in few sub-nodes. To avoid
> duplication this property is removed from following sub-nodes:
> pmu, amba@0, amba@0/ethernet.
> 
> Signed-off-by: Surender Polsani <surenderp@techveda.org>
> ---
>  arch/arm/boot/dts/artpec6.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
> index 767cbe8..2ed1177 100644
> --- a/arch/arm/boot/dts/artpec6.dtsi
> +++ b/arch/arm/boot/dts/artpec6.dtsi
> @@ -151,7 +151,6 @@
>  		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>  			<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-affinity = <&cpu0>, <&cpu1>;
> -		interrupt-parent = <&intc>;
>  	};
>  
>  	pcie: pcie@f8050000 {
> @@ -185,7 +184,6 @@
>  		compatible = "simple-bus";
>  		#address-cells = <0x1>;
>  		#size-cells = <0x1>;
> -		interrupt-parent = <&intc>;
>  		ranges;
>  		dma-ranges = <0x80000000 0x00000000 0x40000000>;
>  		dma-coherent;
> @@ -195,7 +193,6 @@
>  			clocks = <&eth_phy_ref_clk>,
>  				<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>  			compatible = "snps,dwc-qos-ethernet-4.10";
> -			interrupt-parent = <&intc>;
>  			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>  			reg = <0xf8010000 0x4000>;
>  
>
surenderp@techveda.org Aug. 11, 2017, 7:56 a.m. UTC | #2
On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
> Acked-by: Niklas Cassel <niklas.cassel@axis.com>

Hi Nik, This patch has been Acknowledged but is not getting added / 
applied to the
respective git source tree. Please let me know if there is any problem.

Thanks
Surender
>
> On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
>> From: Surender Polsani <surenderp@techveda.org>
>>
>> "interrupt-parent" property is declared in root node, so it is global
>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>> duplication this property is removed from following sub-nodes:
>> pmu, amba@0, amba@0/ethernet.
>>
>> Signed-off-by: Surender Polsani <surenderp@techveda.org>
>> ---
>>   arch/arm/boot/dts/artpec6.dtsi | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>> index 767cbe8..2ed1177 100644
>> --- a/arch/arm/boot/dts/artpec6.dtsi
>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>> @@ -151,7 +151,6 @@
>>   		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>>   			<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>   		interrupt-affinity = <&cpu0>, <&cpu1>;
>> -		interrupt-parent = <&intc>;
>>   	};
>>   
>>   	pcie: pcie@f8050000 {
>> @@ -185,7 +184,6 @@
>>   		compatible = "simple-bus";
>>   		#address-cells = <0x1>;
>>   		#size-cells = <0x1>;
>> -		interrupt-parent = <&intc>;
>>   		ranges;
>>   		dma-ranges = <0x80000000 0x00000000 0x40000000>;
>>   		dma-coherent;
>> @@ -195,7 +193,6 @@
>>   			clocks = <&eth_phy_ref_clk>,
>>   				<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>>   			compatible = "snps,dwc-qos-ethernet-4.10";
>> -			interrupt-parent = <&intc>;
>>   			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>>   			reg = <0xf8010000 0x4000>;
>>   
>>
Niklas Cassel Sept. 4, 2017, 3:23 p.m. UTC | #3
On 08/11/2017 09:56 AM, Surender Polsani wrote:
> On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
>> Acked-by: Niklas Cassel <niklas.cassel@axis.com>
> 
> Hi Nik, This patch has been Acknowledged but is not getting added / applied to the
> respective git source tree. Please let me know if there is any problem.

Hello Surender,

Sorry for the delay.

Could you please resend your patch,
add "To: arm@kernel.org", together with my Ack.

Best regards,
Niklas

> 
> Thanks
> Surender
>>
>> On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
>>> From: Surender Polsani <surenderp@techveda.org>
>>>
>>> "interrupt-parent" property is declared in root node, so it is global
>>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>>> duplication this property is removed from following sub-nodes:
>>> pmu, amba@0, amba@0/ethernet.
>>>
>>> Signed-off-by: Surender Polsani <surenderp@techveda.org>
>>> ---
>>>   arch/arm/boot/dts/artpec6.dtsi | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>>> index 767cbe8..2ed1177 100644
>>> --- a/arch/arm/boot/dts/artpec6.dtsi
>>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>>> @@ -151,7 +151,6 @@
>>>           interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>>>               <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>>           interrupt-affinity = <&cpu0>, <&cpu1>;
>>> -        interrupt-parent = <&intc>;
>>>       };
>>>         pcie: pcie@f8050000 {
>>> @@ -185,7 +184,6 @@
>>>           compatible = "simple-bus";
>>>           #address-cells = <0x1>;
>>>           #size-cells = <0x1>;
>>> -        interrupt-parent = <&intc>;
>>>           ranges;
>>>           dma-ranges = <0x80000000 0x00000000 0x40000000>;
>>>           dma-coherent;
>>> @@ -195,7 +193,6 @@
>>>               clocks = <&eth_phy_ref_clk>,
>>>                   <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>>>               compatible = "snps,dwc-qos-ethernet-4.10";
>>> -            interrupt-parent = <&intc>;
>>>               interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>>>               reg = <0xf8010000 0x4000>;
>>>  
>
Arnd Bergmann Oct. 19, 2017, 9:25 p.m. UTC | #4
On Mon, Sep 4, 2017 at 5:23 PM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> On 08/11/2017 09:56 AM, Surender Polsani wrote:
>> On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
>>> Acked-by: Niklas Cassel <niklas.cassel@axis.com>
>>
>> Hi Nik, This patch has been Acknowledged but is not getting added / applied to the
>> respective git source tree. Please let me know if there is any problem.
>
> Hello Surender,
>
> Sorry for the delay.
>
> Could you please resend your patch,
> add "To: arm@kernel.org", together with my Ack.

I stumbled over this old patch and have applied it to next/dt now with your Ack,
since I did not see another copy sent to arm@kernel.org.

       Arnd
diff mbox

Patch

diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
index 767cbe8..2ed1177 100644
--- a/arch/arm/boot/dts/artpec6.dtsi
+++ b/arch/arm/boot/dts/artpec6.dtsi
@@ -151,7 +151,6 @@ 
 		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
 			<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-affinity = <&cpu0>, <&cpu1>;
-		interrupt-parent = <&intc>;
 	};
 
 	pcie: pcie@f8050000 {
@@ -185,7 +184,6 @@ 
 		compatible = "simple-bus";
 		#address-cells = <0x1>;
 		#size-cells = <0x1>;
-		interrupt-parent = <&intc>;
 		ranges;
 		dma-ranges = <0x80000000 0x00000000 0x40000000>;
 		dma-coherent;
@@ -195,7 +193,6 @@ 
 			clocks = <&eth_phy_ref_clk>,
 				<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
 			compatible = "snps,dwc-qos-ethernet-4.10";
-			interrupt-parent = <&intc>;
 			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
 			reg = <0xf8010000 0x4000>;