| Message ID | 20170627173400.581660959@cogentembedded.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e8f2ed72f478fa9280aeb1eab70ecc87521e23a9 |
| Delegated to: | Simon Horman |
| Headers | show |
On Tue, Jun 27, 2017 at 08:33:44PM +0300, Sergei Shtylyov wrote: > Describe the IMR-LX4 devices in the R8A7796 device tree. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > This patch is against the 'renesas-devel-20170626-v4.12-rc7' tag of Simon > Horman's 'renesas.git' repo. > > The IMR-LX4 bindings were documented in the IMR driver patch and ACK'ed by Rob > Herring, so I don't expect them to change... Thanks Sergei, applied for v4.14.
Hi Sergei, On Tue, Jun 27, 2017 at 7:33 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > Describe the IMR-LX4 devices in the R8A7796 device tree. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7796.dtsi > +++ renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi > @@ -1454,5 +1454,23 @@ > }; > }; > }; > + > + imr-lx4@fe860000 { > + compatible = "renesas,r8a7796-imr-lx4", > + "renesas,imr-lx4"; > + reg = <0 0xfe860000 0 0x2000>; > + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 823>; > + power-domains = <&sysc R8A7796_PD_A3VC>; resets = <&cpg 823>; > + }; > + > + imr-lx4@fe870000 { > + compatible = "renesas,r8a7796-imr-lx4", > + "renesas,imr-lx4"; > + reg = <0 0xfe870000 0 0x2000>; > + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 822>; > + power-domains = <&sysc R8A7796_PD_A3VC>; resets = <&cpg 822>; With the issues above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wed, Jul 05, 2017 at 11:54:20AM +0200, Geert Uytterhoeven wrote: > Hi Sergei, > > On Tue, Jun 27, 2017 at 7:33 PM, Sergei Shtylyov > <sergei.shtylyov@cogentembedded.com> wrote: > > Describe the IMR-LX4 devices in the R8A7796 device tree. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > +++ renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi > > @@ -1454,5 +1454,23 @@ > > }; > > }; > > }; > > + > > + imr-lx4@fe860000 { > > + compatible = "renesas,r8a7796-imr-lx4", > > + "renesas,imr-lx4"; > > + reg = <0 0xfe860000 0 0x2000>; > > + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 823>; > > + power-domains = <&sysc R8A7796_PD_A3VC>; > > resets = <&cpg 823>; > > > + }; > > + > > + imr-lx4@fe870000 { > > + compatible = "renesas,r8a7796-imr-lx4", > > + "renesas,imr-lx4"; > > + reg = <0 0xfe870000 0 0x2000>; > > + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 822>; > > + power-domains = <&sysc R8A7796_PD_A3VC>; > > resets = <&cpg 822>; > > With the issues above fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, fixed.
Hello. On 07/05/2017 12:54 PM, Geert Uytterhoeven wrote: >> Describe the IMR-LX4 devices in the R8A7796 device tree. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7796.dtsi >> +++ renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi >> @@ -1454,5 +1454,23 @@ >> }; >> }; >> }; >> + >> + imr-lx4@fe860000 { >> + compatible = "renesas,r8a7796-imr-lx4", >> + "renesas,imr-lx4"; >> + reg = <0 0xfe860000 0 0x2000>; >> + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 823>; >> + power-domains = <&sysc R8A7796_PD_A3VC>; > > resets = <&cpg 823>; > >> + }; >> + >> + imr-lx4@fe870000 { >> + compatible = "renesas,r8a7796-imr-lx4", >> + "renesas,imr-lx4"; >> + reg = <0 0xfe870000 0 0x2000>; >> + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 822>; >> + power-domains = <&sysc R8A7796_PD_A3VC>; > > resets = <&cpg 822>; > > With the issues above fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I'm afraid it's already merged by Simon... > Gr{oetje,eeting}s, > > Geert MBR, Sergei
On Wed, Jul 05, 2017 at 03:03:37PM +0300, Sergei Shtylyov wrote: > Hello. > > On 07/05/2017 12:54 PM, Geert Uytterhoeven wrote: > > >>Describe the IMR-LX4 devices in the R8A7796 device tree. > >> > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > >>--- renesas.orig/arch/arm64/boot/dts/renesas/r8a7796.dtsi > >>+++ renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi > >>@@ -1454,5 +1454,23 @@ > >> }; > >> }; > >> }; > >>+ > >>+ imr-lx4@fe860000 { > >>+ compatible = "renesas,r8a7796-imr-lx4", > >>+ "renesas,imr-lx4"; > >>+ reg = <0 0xfe860000 0 0x2000>; > >>+ interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; > >>+ clocks = <&cpg CPG_MOD 823>; > >>+ power-domains = <&sysc R8A7796_PD_A3VC>; > > > >resets = <&cpg 823>; > > > >>+ }; > >>+ > >>+ imr-lx4@fe870000 { > >>+ compatible = "renesas,r8a7796-imr-lx4", > >>+ "renesas,imr-lx4"; > >>+ reg = <0 0xfe870000 0 0x2000>; > >>+ interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>; > >>+ clocks = <&cpg CPG_MOD 822>; > >>+ power-domains = <&sysc R8A7796_PD_A3VC>; > > > >resets = <&cpg 822>; > > > >With the issues above fixed: > > > >Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > I'm afraid it's already merged by Simon... I've gone through and added Geert's tags to patches that I merged recently. I'm planning to push the updated patches later today.
Index: renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi =================================================================== --- renesas.orig/arch/arm64/boot/dts/renesas/r8a7796.dtsi +++ renesas/arch/arm64/boot/dts/renesas/r8a7796.dtsi @@ -1454,5 +1454,23 @@ }; }; }; + + imr-lx4@fe860000 { + compatible = "renesas,r8a7796-imr-lx4", + "renesas,imr-lx4"; + reg = <0 0xfe860000 0 0x2000>; + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 823>; + power-domains = <&sysc R8A7796_PD_A3VC>; + }; + + imr-lx4@fe870000 { + compatible = "renesas,r8a7796-imr-lx4", + "renesas,imr-lx4"; + reg = <0 0xfe870000 0 0x2000>; + interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 822>; + power-domains = <&sysc R8A7796_PD_A3VC>; + }; }; };
Describe the IMR-LX4 devices in the R8A7796 device tree. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against the 'renesas-devel-20170626-v4.12-rc7' tag of Simon Horman's 'renesas.git' repo. The IMR-LX4 bindings were documented in the IMR driver patch and ACK'ed by Rob Herring, so I don't expect them to change... Changes in version 2: - added SoC specific "compatible" prop values; - refreshed the patch. arch/arm64/boot/dts/renesas/r8a7796.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)