fstests: btrfs: reorder the arguments of btrfs replace in btrfs/027
diff mbox

Message ID 20170628054531.17882-1-lufq.fnst@cn.fujitsu.com
State New
Headers show

Commit Message

Lu Fengqi June 28, 2017, 5:45 a.m. UTC
The option parser only accept options before non-option argument.
Although David Sterba has submitted commit df8c7225ba00 ("btrfs: reorder
arguments so that options come first"), but this case seems to be left out.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
 tests/btrfs/027 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

David Sterba June 28, 2017, 1:55 p.m. UTC | #1
On Wed, Jun 28, 2017 at 01:45:31PM +0800, Lu Fengqi wrote:
> The option parser only accept options before non-option argument.
> Although David Sterba has submitted commit df8c7225ba00 ("btrfs: reorder
> arguments so that options come first"), but this case seems to be left out.
> 
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

Thanks for cathing it.

Reviewed-by: David Sterba <dsterba@suse.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/tests/btrfs/027 b/tests/btrfs/027
index 2c8b458e..625a27f5 100755
--- a/tests/btrfs/027
+++ b/tests/btrfs/027
@@ -91,8 +91,8 @@  run_test()
 	_scratch_mount -o degraded >>$seqres.full 2>&1
 
 	# replace $missing_dev with $replace_dev and scrub it to double-check
-	$BTRFS_UTIL_PROG replace start -B -r $missing_dev_id $SPARE_DEV \
-		$SCRATCH_MNT -f >>$seqres.full 2>&1
+	$BTRFS_UTIL_PROG replace start -B -f -r $missing_dev_id $SPARE_DEV \
+		$SCRATCH_MNT >>$seqres.full 2>&1
 	if [ $? -ne 0 ]; then
 		echo "btrfs replace failed"
 		_spare_dev_put