| Message ID | bd709fe1a8e75d8389a5e97d5e3fce97fbf6f8b1.1498732573.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 29 Jun 2017 12:37:01 +0200, Arvind Yadav wrote: > > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/device.h> work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 995 608 0 1603 643 sound/pci/hda/hda_sysfs.o > > File size After adding 'const': > text data bss dec hex filename > 1035 544 0 1579 62b sound/pci/hda/hda_sysfs.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied, thanks. Takashi
diff --git a/sound/pci/hda/hda_sysfs.c b/sound/pci/hda/hda_sysfs.c index 9739fce..9b7efec 100644 --- a/sound/pci/hda/hda_sysfs.c +++ b/sound/pci/hda/hda_sysfs.c @@ -761,7 +761,7 @@ int snd_hda_load_patch(struct hda_bus *bus, size_t fw_size, const void *fw_buf) NULL }; -static struct attribute_group hda_dev_attr_group = { +static const struct attribute_group hda_dev_attr_group = { .attrs = hda_dev_attrs, };
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/device.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 995 608 0 1603 643 sound/pci/hda/hda_sysfs.o File size After adding 'const': text data bss dec hex filename 1035 544 0 1579 62b sound/pci/hda/hda_sysfs.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- sound/pci/hda/hda_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)