ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
diff mbox

Message ID 20170630223423.GA20635@embeddedgus
State New
Headers show

Commit Message

Gustavo A. R. Silva June 30, 2017, 10:34 p.m. UTC
platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 sound/atmel/ac97c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Takashi Iwai July 1, 2017, 6:06 a.m. UTC | #1
On Sat, 01 Jul 2017 00:34:23 +0200,
Gustavo A. R. Silva wrote:
> 
> platform_get_irq() returns an error code, but the ac97c
> driver ignores it and always returns -ENXIO. This is not correct,
> and prevents -EPROBE_DEFER from being propagated properly.
> Notice that platform_get_irq() no longer returns 0 on error.
> 
> Print and propagate the return value of platform_get_irq on failure.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Applied, thanks.


Takashi

Patch
diff mbox

diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 65e6948..9d2c9d9 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -774,8 +774,8 @@  static int atmel_ac97c_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_dbg(&pdev->dev, "could not get irq\n");
-		return -ENXIO;
+		dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
+		return irq;
 	}
 
 	pclk = clk_get(&pdev->dev, "ac97_clk");