| Message ID | 1498913770-16519-1-git-send-email-jacob-chen@iotwrt.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jacob, Am Samstag, 1. Juli 2017, 20:56:08 CEST schrieb Jacob Chen: > Add Mali GPU device tree node for the rk3399 SoC. > Tested with rockchip-forwardports repo. > > Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 1cbd7a2..e795135 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1443,6 +1443,18 @@ > status = "disabled"; > }; > > + gpu: mali@ff9a0000 { > + compatible = "rockchip,rk3399-mali", "arm,mali-t860", "arm,mali-midgard"; this is missing a separate patch adding rockchip,rk3399-mali to Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt Also arm,mali-midgard is not part of the binding. I just saw that it slipped into the example in the binding file and also the rk3288.dtsi - which should be fixed. But the driver should bind against the arm,mali-t860 alone, not the mali-midgard. Heiko
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 1cbd7a2..e795135 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -1443,6 +1443,18 @@ status = "disabled"; }; + gpu: mali@ff9a0000 { + compatible = "rockchip,rk3399-mali", "arm,mali-t860", "arm,mali-midgard"; + reg = <0x0 0xff9a0000 0x0 0x10000>; + interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH 0>; + interrupt-names = "gpu", "job", "mmu"; + clocks = <&cru ACLK_GPU>; + power-domains = <&power RK3399_PD_GPU>; + status = "disabled"; + }; + pinctrl: pinctrl { compatible = "rockchip,rk3399-pinctrl"; rockchip,grf = <&grf>;
Add Mali GPU device tree node for the rk3399 SoC. Tested with rockchip-forwardports repo. Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)