hwmon: applesmc: fix deprecated hwmon_device_register call
diff mbox

Message ID 20170702000505.2650-1-cengizc@gmail.com
State Changes Requested
Headers show

Commit Message

Cengiz Can July 2, 2017, 12:05 a.m. UTC
Hello.

This is my first patch attempt on drivers so I might be completely wrong.

applesmc driver was using the deprecated `hwmon_device_register` call for
some reason. And that causes a deprecation warning in dmesg.

I've replaced the call with `hwmon_device_register_with_info` and booted
my MBP 11,2 with it.

The warning is no longer shown. And the functionality doesn't seem to be
broken.

Thank you for reading this.

Signed-off-by: Cengiz Can <cengizc@gmail.com>
---
 drivers/hwmon/applesmc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Guenter Roeck July 7, 2017, 6:18 p.m. UTC | #1
On Sun, Jul 02, 2017 at 03:05:05AM +0300, Cengiz Can wrote:
> Hello.
> 
> This is my first patch attempt on drivers so I might be completely wrong.
> 
> applesmc driver was using the deprecated `hwmon_device_register` call for
> some reason. And that causes a deprecation warning in dmesg.
> 
> I've replaced the call with `hwmon_device_register_with_info` and booted
> my MBP 11,2 with it.
> 
> The warning is no longer shown. And the functionality doesn't seem to be
> broken.
> 
> Thank you for reading this.
> 

Do you really want all of the above in the change log ?

> Signed-off-by: Cengiz Can <cengizc@gmail.com>
> ---
>  drivers/hwmon/applesmc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
> index 0af7fd311979..6e897310151a 100644
> --- a/drivers/hwmon/applesmc.c
> +++ b/drivers/hwmon/applesmc.c
> @@ -1326,7 +1326,11 @@ static int __init applesmc_init(void)
>  	if (ret)
>  		goto out_light_sysfs;
>  
> -	hwmon_dev = hwmon_device_register(&pdev->dev);
> +	hwmon_dev = hwmon_device_register_with_info(&pdev->dev,
> +						   "applesmcbacklight",
> +						   NULL,
> +						   NULL,
> +						   NULL);

I am not in favor of changes like this. It doesn't solve the problem
with the old API, which is that it maintains sysfs nodes locally.
Besides, this patch changes the name from "applesmc" to "applesmcbacklight",
it creates a name attribute in the hwmon device directory while
keeping the actual hwmon attributes in the platform device directory,
and the driver has another name attribute in the platform device directory.

Given that, sorry, I can not accept this patch.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c
index 0af7fd311979..6e897310151a 100644
--- a/drivers/hwmon/applesmc.c
+++ b/drivers/hwmon/applesmc.c
@@ -1326,7 +1326,11 @@  static int __init applesmc_init(void)
 	if (ret)
 		goto out_light_sysfs;
 
-	hwmon_dev = hwmon_device_register(&pdev->dev);
+	hwmon_dev = hwmon_device_register_with_info(&pdev->dev,
+						   "applesmcbacklight",
+						   NULL,
+						   NULL,
+						   NULL);
 	if (IS_ERR(hwmon_dev)) {
 		ret = PTR_ERR(hwmon_dev);
 		goto out_light_ledclass;