From patchwork Sun Jul 2 00:05:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cengiz Can X-Patchwork-Id: 9821031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 464836035F for ; Sun, 2 Jul 2017 00:05:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27AF727F95 for ; Sun, 2 Jul 2017 00:05:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 184E1283BE; Sun, 2 Jul 2017 00:05:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB38127F95 for ; Sun, 2 Jul 2017 00:05:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbdGBAFb (ORCPT ); Sat, 1 Jul 2017 20:05:31 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33394 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbdGBAFa (ORCPT ); Sat, 1 Jul 2017 20:05:30 -0400 Received: by mail-wm0-f65.google.com with SMTP id j85so14091245wmj.0; Sat, 01 Jul 2017 17:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=IQYifxHvD8FBZFXdioL/YgZxUWzSMV4Sp+isVJepW9Y=; b=WUNMAwLRIm9jrzqyWs3U/SGEjtYc9lF01gSyRSD+VwZJwA/tKNHBnUXNnWsTBIlsw4 uG9Cl7982QzKNUc2GN4UtrS33X5gtCSuiqqYqf7ZrW8YE7Jegkr1wqOSOjWgoQ1SguEc diRVKMYx/IBwy3XsRwlgtm+vdL1kKGkLVILSOdF6KMMgIhG4EzyiV8vlo9HbstlcCWZH jvii/FAyAa6a+bMVSKgdPPnZGPLeI8T+/bdwVRDhqefzZ36hLma0BEftifOX0I10f2rw fAFSpNzpcNcxLhLirxH8GY0lizNEpDWs2NOxcojOhb3epimcs5jAbgvM+/IvHxVOjd2F 8WJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IQYifxHvD8FBZFXdioL/YgZxUWzSMV4Sp+isVJepW9Y=; b=oy+S98S1JwVIQ1rVLbRAJ7eJbpSZhvkzWskv8spFf4ZQjQbuKADi3sTLVnvAzR7U8i VOBAPch9qlAINBBKbepZiu6JCwMRCfB7qirFj3pwf84wy6x1yIdVuObaRM+oGgiyWl4D 2Lu63l/j8iBvNeqZtMkxusZ5Y/UY7RLuDhskI118GjamCBHRPXm96sU+NxaNi0OQB0/o cyj9j7ysf63uxyc3vSMDBEhxChta9xpA8dYNan8wNZUfldmbmv7G4USofeZYGjQt1nOn 8RgKP/BBg1B50o41U6CkiAVgBvt8SLTYxP/W2N4KdAJ+IFINKZmgHBtRDNNv5e4nr9I2 myWA== X-Gm-Message-State: AIVw112vCS2Kg40QXUVuwS/mFs1fO8QSsesYByQ4igN/uoI+QaYrtIL6 mPBIKVyGavKYHQ== X-Received: by 10.28.66.67 with SMTP id p64mr2624722wma.93.1498953928964; Sat, 01 Jul 2017 17:05:28 -0700 (PDT) Received: from localhost.localdomain ([95.70.165.60]) by smtp.gmail.com with ESMTPSA id j13sm19365056wra.56.2017.07.01.17.05.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Jul 2017 17:05:27 -0700 (PDT) From: Cengiz Can To: Henrik Rydberg Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Cengiz Can Subject: [PATCH] hwmon: applesmc: fix deprecated hwmon_device_register call Date: Sun, 2 Jul 2017 03:05:05 +0300 Message-Id: <20170702000505.2650-1-cengizc@gmail.com> X-Mailer: git-send-email 2.13.2 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello. This is my first patch attempt on drivers so I might be completely wrong. applesmc driver was using the deprecated `hwmon_device_register` call for some reason. And that causes a deprecation warning in dmesg. I've replaced the call with `hwmon_device_register_with_info` and booted my MBP 11,2 with it. The warning is no longer shown. And the functionality doesn't seem to be broken. Thank you for reading this. Signed-off-by: Cengiz Can --- drivers/hwmon/applesmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/applesmc.c b/drivers/hwmon/applesmc.c index 0af7fd311979..6e897310151a 100644 --- a/drivers/hwmon/applesmc.c +++ b/drivers/hwmon/applesmc.c @@ -1326,7 +1326,11 @@ static int __init applesmc_init(void) if (ret) goto out_light_sysfs; - hwmon_dev = hwmon_device_register(&pdev->dev); + hwmon_dev = hwmon_device_register_with_info(&pdev->dev, + "applesmcbacklight", + NULL, + NULL, + NULL); if (IS_ERR(hwmon_dev)) { ret = PTR_ERR(hwmon_dev); goto out_light_ledclass;