Patchwork [12/14] drm/exynos: mic: clean up drm_bridge_add call

login
register
mail settings
Submitter Inki Dae
Date July 3, 2017, 8:42 a.m.
Message ID <1499071350-25168-13-git-send-email-inki.dae@samsung.com>
Download mbox | patch
Permalink /patch/9822227/
State New
Headers show

Comments

Inki Dae - July 3, 2017, 8:42 a.m.
This patch removes unnecessary checking of return value.

Ps. this patch depends on below one,
	http://www.spinics.net/lists/dri-devel/msg145687.html

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Archit Taneja - July 5, 2017, 9 a.m.
On 07/03/2017 02:12 PM, Inki Dae wrote:
> This patch removes unnecessary checking of return value.
> 
> Ps. this patch depends on below one,
> 	http://www.spinics.net/lists/dri-devel/msg145687.html

Will this one^ go via the exynos pull req or drm-misc? If there won't
be any conflicts, we could get both the patches through drm-misc to
keep things simple.

Archit

> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>   drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 5ea6e3d..07bd7fc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>   	mic->bridge.funcs = &mic_bridge_funcs;
>   	mic->bridge.of_node = dev->of_node;
>   
> -	ret = drm_bridge_add(&mic->bridge);
> -	if (ret) {
> -		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
> -		return ret;
> -	}
> +	drm_bridge_add(&mic->bridge);
>   
>   	pm_runtime_enable(dev);
>   
>
Inki Dae - July 5, 2017, 9:05 a.m.
2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/03/2017 02:12 PM, Inki Dae wrote:
>> This patch removes unnecessary checking of return value.
>>
>> Ps. this patch depends on below one,
>>     http://www.spinics.net/lists/dri-devel/msg145687.html
> 
> Will this one^ go via the exynos pull req or drm-misc? If there won't
> be any conflicts, we could get both the patches through drm-misc to
> keep things simple.

exynos pull it would be better. I will pick this up. :)

Thanks,
Inki Dae

> 
> Archit
> 
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> ---
>>   drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> index 5ea6e3d..07bd7fc 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>       mic->bridge.funcs = &mic_bridge_funcs;
>>       mic->bridge.of_node = dev->of_node;
>>   -    ret = drm_bridge_add(&mic->bridge);
>> -    if (ret) {
>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>> -        return ret;
>> -    }
>> +    drm_bridge_add(&mic->bridge);
>>         pm_runtime_enable(dev);
>>  
>
Archit Taneja - July 5, 2017, 9:14 a.m.
On 07/05/2017 02:35 PM, Inki Dae wrote:
> 
> 
> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>
>>
>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>> This patch removes unnecessary checking of return value.
>>>
>>> Ps. this patch depends on below one,
>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>
>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>> be any conflicts, we could get both the patches through drm-misc to
>> keep things simple.
> 
> exynos pull it would be better. I will pick this up. :)

If patch # 1/14 goes through drm-misc, and the exynos patch goes through
exynos pull, the drm-misc branch would break. That's the reason I
preferred the exynos patches to go via misc.

Thanks,
Archit

> 
> Thanks,
> Inki Dae
> 
>>
>> Archit
>>
>>>
>>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>>> ---
>>>    drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>>    1 file changed, 1 insertion(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> index 5ea6e3d..07bd7fc 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>>        mic->bridge.funcs = &mic_bridge_funcs;
>>>        mic->bridge.of_node = dev->of_node;
>>>    -    ret = drm_bridge_add(&mic->bridge);
>>> -    if (ret) {
>>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>>> -        return ret;
>>> -    }
>>> +    drm_bridge_add(&mic->bridge);
>>>          pm_runtime_enable(dev);
>>>   
>>
Emil Velikov - July 5, 2017, 11:12 a.m.
On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>
>
> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>
>>
>>
>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>
>>>
>>>
>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>
>>>> This patch removes unnecessary checking of return value.
>>>>
>>>> Ps. this patch depends on below one,
>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>
>>>
>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>> be any conflicts, we could get both the patches through drm-misc to
>>> keep things simple.
>>
>>
>> exynos pull it would be better. I will pick this up. :)
>
>
> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
> exynos pull, the drm-misc branch would break. That's the reason I
> preferred the exynos patches to go via misc.
>
As mentioned in 1/14:

If 1/14 is applied before the rest of the series all the drivers
(addressed with 2-14) will fail to build.
I think...

-Emil
Archit Taneja - July 6, 2017, 7:59 a.m.
On 07/05/2017 04:42 PM, Emil Velikov wrote:
> On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>>
>>
>> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>>
>>>
>>>
>>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>>
>>>>
>>>>
>>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>>
>>>>> This patch removes unnecessary checking of return value.
>>>>>
>>>>> Ps. this patch depends on below one,
>>>>>       http://www.spinics.net/lists/dri-devel/msg145687.html
>>>>
>>>>
>>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>>> be any conflicts, we could get both the patches through drm-misc to
>>>> keep things simple.
>>>
>>>
>>> exynos pull it would be better. I will pick this up. :)
>>
>>
>> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
>> exynos pull, the drm-misc branch would break. That's the reason I
>> preferred the exynos patches to go via misc.
>>
> As mentioned in 1/14:
> 
> If 1/14 is applied before the rest of the series all the drivers
> (addressed with 2-14) will fail to build.
> I think...

Yeah, they would. We'd want to push 1/14 right at the end. Getting all
the ones from 2-14 via drm-misc would make life simpler.

Archit

> 
> -Emil
>
Inki Dae - Aug. 18, 2017, 8:01 a.m.
2017년 07월 03일 17:42에 Inki Dae 이(가) 쓴 글:
> This patch removes unnecessary checking of return value.
> 
> Ps. this patch depends on below one,
> 	http://www.spinics.net/lists/dri-devel/msg145687.html

Above patch has been already merged to mainline so no dependency, and can go through misc.

Acked-by: Inki Dae <inki.dae@samsung.com>

Thanks,
Inki Dae


> 
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 5ea6e3d..07bd7fc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>  	mic->bridge.funcs = &mic_bridge_funcs;
>  	mic->bridge.of_node = dev->of_node;
>  
> -	ret = drm_bridge_add(&mic->bridge);
> -	if (ret) {
> -		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
> -		return ret;
> -	}
> +	drm_bridge_add(&mic->bridge);
>  
>  	pm_runtime_enable(dev);
>  
>
Inki Dae - Aug. 18, 2017, 8:03 a.m.
2017년 07월 05일 18:14에 Archit Taneja 이(가) 쓴 글:
> 
> 
> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>
>>
>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>
>>>
>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>> This patch removes unnecessary checking of return value.
>>>>
>>>> Ps. this patch depends on below one,
>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>
>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>> be any conflicts, we could get both the patches through drm-misc to
>>> keep things simple.
>>
>> exynos pull it would be better. I will pick this up. :)
> 
> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
> exynos pull, the drm-misc branch would break. That's the reason I
> preferred the exynos patches to go via misc.

Sorry for late. I missed checking your comment. Sorry for this.
As you commented, I left Acked-by so that this patch series can go to mainline through misc without build break.

Thanks,
Inki Dae

> 
> Thanks,
> Archit
> 
>>
>> Thanks,
>> Inki Dae
>>
>>>
>>> Archit
>>>
>>>>
>>>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>>>> ---
>>>>    drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 +-----
>>>>    1 file changed, 1 insertion(+), 5 deletions(-)
>>>>
>>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> index 5ea6e3d..07bd7fc 100644
>>>> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
>>>> @@ -458,11 +458,7 @@ static int exynos_mic_probe(struct platform_device *pdev)
>>>>        mic->bridge.funcs = &mic_bridge_funcs;
>>>>        mic->bridge.of_node = dev->of_node;
>>>>    -    ret = drm_bridge_add(&mic->bridge);
>>>> -    if (ret) {
>>>> -        DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
>>>> -        return ret;
>>>> -    }
>>>> +    drm_bridge_add(&mic->bridge);
>>>>          pm_runtime_enable(dev);
>>>>   
>>>
>
Inki Dae - Aug. 18, 2017, 8:04 a.m.
2017년 07월 05일 20:12에 Emil Velikov 이(가) 쓴 글:
> On 5 July 2017 at 10:14, Archit Taneja <architt@codeaurora.org> wrote:
>>
>>
>> On 07/05/2017 02:35 PM, Inki Dae wrote:
>>>
>>>
>>>
>>> 2017년 07월 05일 18:00에 Archit Taneja 이(가) 쓴 글:
>>>>
>>>>
>>>>
>>>> On 07/03/2017 02:12 PM, Inki Dae wrote:
>>>>>
>>>>> This patch removes unnecessary checking of return value.
>>>>>
>>>>> Ps. this patch depends on below one,
>>>>>      http://www.spinics.net/lists/dri-devel/msg145687.html
>>>>
>>>>
>>>> Will this one^ go via the exynos pull req or drm-misc? If there won't
>>>> be any conflicts, we could get both the patches through drm-misc to
>>>> keep things simple.
>>>
>>>
>>> exynos pull it would be better. I will pick this up. :)
>>
>>
>> If patch # 1/14 goes through drm-misc, and the exynos patch goes through
>> exynos pull, the drm-misc branch would break. That's the reason I
>> preferred the exynos patches to go via misc.
>>
> As mentioned in 1/14:
> 
> If 1/14 is applied before the rest of the series all the drivers
> (addressed with 2-14) will fail to build.
> I think...

Indeed. :)

Thanks,
Inki Dae

> 
> -Emil
> 
> 
>

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 5ea6e3d..07bd7fc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -458,11 +458,7 @@  static int exynos_mic_probe(struct platform_device *pdev)
 	mic->bridge.funcs = &mic_bridge_funcs;
 	mic->bridge.of_node = dev->of_node;
 
-	ret = drm_bridge_add(&mic->bridge);
-	if (ret) {
-		DRM_ERROR("mic: Failed to add MIC to the global bridge list\n");
-		return ret;
-	}
+	drm_bridge_add(&mic->bridge);
 
 	pm_runtime_enable(dev);