Patchwork [01/14] drm/bridge: change return type of drm_bridge_add function

login
register
mail settings
Submitter Inki Dae
Date July 3, 2017, 8:42 a.m.
Message ID <1499071350-25168-2-git-send-email-inki.dae@samsung.com>
Download mbox | patch
Permalink /patch/9822239/
State New
Headers show

Comments

Inki Dae - July 3, 2017, 8:42 a.m.
This patch changes return type of drm_bridge_add function.

This function never return negative value but returns only 0.
So it changes the return type of this function to void one.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/drm_bridge.c | 7 +------
 include/drm/drm_bridge.h     | 2 +-
 2 files changed, 2 insertions(+), 7 deletions(-)
Emil Velikov - July 3, 2017, 9:56 a.m.
Hi Inki,

On 3 July 2017 at 09:42, Inki Dae <inki.dae@samsung.com> wrote:
> This patch changes return type of drm_bridge_add function.
>
> This function never return negative value but returns only 0.
> So it changes the return type of this function to void one.
>
This patch should be the final in the series. Otherwise you'll get the
following build error for each call site.

"error: void value not ignored as it ought to be"

Regards,
Emil

Patch

diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c
index dc8cdfe..1638bfe 100644
--- a/drivers/gpu/drm/drm_bridge.c
+++ b/drivers/gpu/drm/drm_bridge.c
@@ -67,17 +67,12 @@ 
  * drm_bridge_add - add the given bridge to the global bridge list
  *
  * @bridge: bridge control structure
- *
- * RETURNS:
- * Unconditionally returns Zero.
  */
-int drm_bridge_add(struct drm_bridge *bridge)
+void drm_bridge_add(struct drm_bridge *bridge)
 {
 	mutex_lock(&bridge_lock);
 	list_add_tail(&bridge->list, &bridge_list);
 	mutex_unlock(&bridge_lock);
-
-	return 0;
 }
 EXPORT_SYMBOL(drm_bridge_add);
 
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 1dc94d5..4254423 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -245,7 +245,7 @@  struct drm_bridge {
 	void *driver_private;
 };
 
-int drm_bridge_add(struct drm_bridge *bridge);
+void drm_bridge_add(struct drm_bridge *bridge);
 void drm_bridge_remove(struct drm_bridge *bridge);
 struct drm_bridge *of_drm_find_bridge(struct device_node *np);
 int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge,