Patchwork [14/14] drm/sti: sti_vdo: clean up drm_bridge_add call

login
register
mail settings
Submitter Inki Dae
Date July 3, 2017, 8:42 a.m.
Message ID <1499071350-25168-15-git-send-email-inki.dae@samsung.com>
Download mbox | patch
Permalink /patch/9822245/
State New
Headers show

Comments

Inki Dae - July 3, 2017, 8:42 a.m.
This patch removes unnecessary checking of return value.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
---
 drivers/gpu/drm/sti/sti_dvo.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
Sean Paul - Aug. 18, 2017, 3:15 p.m.
On Mon, Jul 3, 2017 at 4:42 AM, Inki Dae <inki.dae@samsung.com> wrote:
> This patch removes unnecessary checking of return value.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>

Reviewed-by: Sean Paul <seanpaul@chromium.org>

> ---
>  drivers/gpu/drm/sti/sti_dvo.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
> index 24ebc6b..dcc2c22 100644
> --- a/drivers/gpu/drm/sti/sti_dvo.c
> +++ b/drivers/gpu/drm/sti/sti_dvo.c
> @@ -464,11 +464,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
>         bridge->driver_private = dvo;
>         bridge->funcs = &sti_dvo_bridge_funcs;
>         bridge->of_node = dvo->dev.of_node;
> -       err = drm_bridge_add(bridge);
> -       if (err) {
> -               DRM_ERROR("Failed to add bridge\n");
> -               return err;
> -       }
> +       drm_bridge_add(bridge);
>
>         err = drm_bridge_attach(encoder, bridge, NULL);
>         if (err) {
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c
index 24ebc6b..dcc2c22 100644
--- a/drivers/gpu/drm/sti/sti_dvo.c
+++ b/drivers/gpu/drm/sti/sti_dvo.c
@@ -464,11 +464,7 @@  static int sti_dvo_bind(struct device *dev, struct device *master, void *data)
 	bridge->driver_private = dvo;
 	bridge->funcs = &sti_dvo_bridge_funcs;
 	bridge->of_node = dvo->dev.of_node;
-	err = drm_bridge_add(bridge);
-	if (err) {
-		DRM_ERROR("Failed to add bridge\n");
-		return err;
-	}
+	drm_bridge_add(bridge);
 
 	err = drm_bridge_attach(encoder, bridge, NULL);
 	if (err) {