| Message ID | 1499084743-24257-1-git-send-email-shashank.sharma@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 03, 2017 at 05:55:43PM +0530, Shashank Sharma wrote: > CEA-861-F introduces extended tag codes for EDID extension blocks, > which indicates the actual type of the data block. The code for > using exteded tag is 0x7, whereas in the existing code, the > corresponding macro is named as "VIDEO_CAPABILITY_BLOCK" > > This patch renames the macro and usages from "VIDEO_CAPABILITY_BLOCK" > to "CEA_EXTENDED_TAG" > > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Signed-off-by: Shashank Sharma <shashank.sharma@intel.com> > --- > drivers/gpu/drm/drm_edid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 2e55599..c81b076 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2566,7 +2566,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > #define VIDEO_BLOCK 0x02 > #define VENDOR_BLOCK 0x03 > #define SPEAKER_BLOCK 0x04 > -#define VIDEO_CAPABILITY_BLOCK 0x07 > +#define CEA_EXTENDED_TAG 0x07 > #define EDID_BASIC_AUDIO (1 << 6) > #define EDID_CEA_YCRCB444 (1 << 5) > #define EDID_CEA_YCRCB422 (1 << 4) > @@ -3793,7 +3793,7 @@ bool drm_rgb_quant_range_selectable(struct edid *edid) > return false; > > for_each_cea_db(edid_ext, i, start, end) { > - if (cea_db_tag(&edid_ext[i]) == VIDEO_CAPABILITY_BLOCK && > + if (cea_db_tag(&edid_ext[i]) == CEA_EXTENDED_TAG && > cea_db_payload_len(&edid_ext[i]) == 2) { The video capability block should have a specific ext tag no? We should check for that. > DRM_DEBUG_KMS("CEA VCDB 0x%02x\n", edid_ext[i + 2]); > return edid_ext[i + 2] & EDID_CEA_VCDB_QS; > -- > 2.7.4
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 2e55599..c81b076 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -2566,7 +2566,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, #define VIDEO_BLOCK 0x02 #define VENDOR_BLOCK 0x03 #define SPEAKER_BLOCK 0x04 -#define VIDEO_CAPABILITY_BLOCK 0x07 +#define CEA_EXTENDED_TAG 0x07 #define EDID_BASIC_AUDIO (1 << 6) #define EDID_CEA_YCRCB444 (1 << 5) #define EDID_CEA_YCRCB422 (1 << 4) @@ -3793,7 +3793,7 @@ bool drm_rgb_quant_range_selectable(struct edid *edid) return false; for_each_cea_db(edid_ext, i, start, end) { - if (cea_db_tag(&edid_ext[i]) == VIDEO_CAPABILITY_BLOCK && + if (cea_db_tag(&edid_ext[i]) == CEA_EXTENDED_TAG && cea_db_payload_len(&edid_ext[i]) == 2) { DRM_DEBUG_KMS("CEA VCDB 0x%02x\n", edid_ext[i + 2]); return edid_ext[i + 2] & EDID_CEA_VCDB_QS;
CEA-861-F introduces extended tag codes for EDID extension blocks, which indicates the actual type of the data block. The code for using exteded tag is 0x7, whereas in the existing code, the corresponding macro is named as "VIDEO_CAPABILITY_BLOCK" This patch renames the macro and usages from "VIDEO_CAPABILITY_BLOCK" to "CEA_EXTENDED_TAG" Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Signed-off-by: Shashank Sharma <shashank.sharma@intel.com> --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)