From patchwork Thu Jul 6 12:57:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9828231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B8270602BD for ; Thu, 6 Jul 2017 12:57:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9BA828621 for ; Thu, 6 Jul 2017 12:57:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9E1C528628; Thu, 6 Jul 2017 12:57:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6034228621 for ; Thu, 6 Jul 2017 12:57:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 638D089CA1; Thu, 6 Jul 2017 12:57:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C8E46E5EA for ; Thu, 6 Jul 2017 12:57:46 +0000 (UTC) Received: by mail-lf0-x241.google.com with SMTP id t72so232979lff.0 for ; Thu, 06 Jul 2017 05:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Qk5bot7573UdGoO89Kie9TRLEU/mrkKg8jx+63xW/80=; b=BD0iB/OrbvuVPpoqudR7k8NS11GB4YmZGsbkF695ciQwmdsz2D+3+r451xJ6O6xDYf r3FhnfQySSrT/4yruQCbjsARWyJHTXCTCnhJMoB4+6DnpRsJz8wVrJO7SWX/2cJuVRTX 6cisW2SmY4kaFC+ng02SD3pUqn8aiyPIXove4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Qk5bot7573UdGoO89Kie9TRLEU/mrkKg8jx+63xW/80=; b=tk7g7pVsmkkjSu6unkYHqgF1rMMMayicau8r4yPwx1azm5hgoeRvyFS+bBJQNK6aCH tFexBOHGN4X4pBGx0Ho98V5xQZFLEl4V3+yoHMhhSedDwHM7nvKuaDZXdSk+sxTEPOyl thtaFY0VHzOJq9iSLLkUVWu8BKae8b1e/dFoGam8yPLODr+OLLSjbs04okjZZKWOj1VR aX9CAfyQ6hgjY7M8DUUQoalU29UwF+q9sOUT5FD9zCSik+xUH/X8v7aiMXUXvaAF+D6Z RVD9GVRo9vY8ZQJ1AUZFmibaxLhpYy7vDS/Pse5E8g9SwIOlvAWhFiQNEhzOUwiqq46m D7zg== X-Gm-Message-State: AKS2vOwDP/DTFiLhapCTR1WkzD6Z/JpQsfBbn8oGowxNrlmGHwqTBP/e K2rWZjAVWbPZwK71ZJQ= X-Received: by 10.80.137.67 with SMTP id f3mr25794654edf.152.1499345864703; Thu, 06 Jul 2017 05:57:44 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id 2sm406636edt.36.2017.07.06.05.57.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 05:57:44 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/4] fbdev: Nuke FBINFO_MODULE Date: Thu, 6 Jul 2017 14:57:33 +0200 Message-Id: <20170706125735.28299-3-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170706125735.28299-1-daniel.vetter@ffwll.ch> References: <20170706125735.28299-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter , linux-fbdev@vger.kernel.org, Intel Graphics Development , Bartlomiej Zolnierkiewicz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Instead check info->ops->owner, which amounts to the same. Spotted because I want to remove the pile of broken and cargo-culted fb_info->flags assignments in drm drivers. Cc: Bartlomiej Zolnierkiewicz Cc: linux-fbdev@vger.kernel.org Signed-off-by: Daniel Vetter --- drivers/video/fbdev/core/fbcon.c | 2 +- drivers/video/fbdev/core/fbmem.c | 4 ++-- include/linux/fb.h | 7 +------ 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c index 86b3bcbd01a8..431a1533a2fe 100644 --- a/drivers/video/fbdev/core/fbcon.c +++ b/drivers/video/fbdev/core/fbcon.c @@ -564,7 +564,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, unsigned short *save = NULL, *r, *q; int logo_height; - if (info->flags & FBINFO_MODULE) { + if (info->fbops->owner) { logo_shown = FBCON_LOGO_DONTSHOW; return; } diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 283d57cf8526..2636f192e8c9 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -463,7 +463,7 @@ static int fb_show_logo_line(struct fb_info *info, int rotate, /* Return if the frame buffer is not mapped or suspended */ if (logo == NULL || info->state != FBINFO_STATE_RUNNING || - info->flags & FBINFO_MODULE) + info->fbops->owner) return 0; image.depth = 8; @@ -601,7 +601,7 @@ int fb_prepare_logo(struct fb_info *info, int rotate) memset(&fb_logo, 0, sizeof(struct logo_data)); if (info->flags & FBINFO_MISC_TILEBLITTING || - info->flags & FBINFO_MODULE) + info->fbops->owner) return 0; if (info->fix.visual == FB_VISUAL_DIRECTCOLOR) { diff --git a/include/linux/fb.h b/include/linux/fb.h index a964d076b4dc..40b767fa622f 100644 --- a/include/linux/fb.h +++ b/include/linux/fb.h @@ -400,7 +400,7 @@ struct fb_tile_ops { #endif /* CONFIG_FB_TILEBLITTING */ /* FBINFO_* = fb_info.flags bit flags */ -#define FBINFO_MODULE 0x0001 /* Low-level driver is a module */ +#define FBINFO_DEFAULT 0 #define FBINFO_HWACCEL_DISABLED 0x0002 /* When FBINFO_HWACCEL_DISABLED is set: * Hardware acceleration is turned off. Software implementations @@ -533,11 +533,6 @@ static inline struct apertures_struct *alloc_apertures(unsigned int max_num) { return a; } -#ifdef MODULE -#define FBINFO_DEFAULT FBINFO_MODULE -#else -#define FBINFO_DEFAULT 0 -#endif // This will go away #define FBINFO_FLAG_MODULE FBINFO_MODULE