From patchwork Thu Jul 6 13:00:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9828245 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 627CF60361 for ; Thu, 6 Jul 2017 13:00:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53C8E28621 for ; Thu, 6 Jul 2017 13:00:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4831128639; Thu, 6 Jul 2017 13:00:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 00FFF28621 for ; Thu, 6 Jul 2017 13:00:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2317C6E5EC; Thu, 6 Jul 2017 13:00:32 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-lf0-x244.google.com (mail-lf0-x244.google.com [IPv6:2a00:1450:4010:c07::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD0226E5EC for ; Thu, 6 Jul 2017 13:00:30 +0000 (UTC) Received: by mail-lf0-x244.google.com with SMTP id z78so232074lff.2 for ; Thu, 06 Jul 2017 06:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=C98izmHBJkhimYePe5zdYn4LVOTGoCxHG2bcI0+OGDw=; b=QUlu59VS8RA9GfLaOaX6FaMCemVk+oge9Zzl5FQX8lnMGgLxr7K6JkK/xC2/puNdKU MJLtx/iVEOjtFpx4B+1A6qYAMDzXg+LgYooPoFj4Slk6luumKMk8JQUXteKUWNt3sIvU TutDmjB3gisAn5jxwvwzDcu254ld2m21L1aHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=C98izmHBJkhimYePe5zdYn4LVOTGoCxHG2bcI0+OGDw=; b=Ag1r10QGUSgtQhMT37fhJz2Ie5uH1S0G6EgjHTx1XW+1LElTXtyXRwVxkj50VreOyY 0Km0Ql3kuIs+tLqfVm+b/DfppOdzjU4o5XgVuLw+NqDnloepYo1gEifq6Kpv48OBUERf JGGYNSGkOeQHHBZTprHTWRRS6fmCSSfnHL2e04q6sYdP+m5clzv+Kp4yQL/vXKfEh0jY e4fCew38ziI8+1yD9gWOiVhSA0/jC0rFgBVMHw0fAu069L1p5bCHTw+Lpgl6qddxAWHm SXsqX/ciLGRA8friDffcm51G3+vkv6LBiXTd90kgtLolZVmMW/El4n35huVBZDYUbKv5 KJaw== X-Gm-Message-State: AIVw110+fxQqiYYpLKrGyl1KwaVxnZb+DrpalZjdhZssdcFgiDWX8UCB YIaTwGTD5TRnr7nmr3c= X-Received: by 10.80.209.195 with SMTP id i3mr18218430edg.70.1499346028832; Thu, 06 Jul 2017 06:00:28 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id a20sm132884edd.60.2017.07.06.06.00.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Jul 2017 06:00:28 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 1/5] drm/i915/fbdev: Always forward hotplug events Date: Thu, 6 Jul 2017 15:00:19 +0200 Message-Id: <20170706130023.28417-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.13.2 Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter , Mika Kuoppala X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP With deferred fbdev setup we always need to forward hotplug events, even if fbdev isn't fully set up yet. Otherwise the deferred setup will neer happen. Originally this check was added in commit c45eb4fed12d278d3619f1904885bd0d7bcbf036 (tag: drm-intel-next-fixes-2016-08-05) Author: Chris Wilson Date: Wed Jul 13 18:34:45 2016 +0100 drm/i915/fbdev: Check for the framebuffer before use But the specific case of the hotplug function blowing up was fixed in commit 50c3dc970a09b3b60422a58934cc27a413288bab Author: Daniel Vetter Date: Fri Jun 27 17:19:22 2014 +0200 drm/fb-helper: Fix hpd vs. initial config races Cc: Maarten Lankhorst Cc: Mika Kuoppala Cc: Chris Wilson Signed-off-by: Daniel Vetter Reviewed-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b/drivers/gpu/drm/i915/intel_fbdev.c index f11ee039ff45..5536591d3da0 100644 --- a/drivers/gpu/drm/i915/intel_fbdev.c +++ b/drivers/gpu/drm/i915/intel_fbdev.c @@ -821,7 +821,7 @@ void intel_fbdev_output_poll_changed(struct drm_device *dev) { struct intel_fbdev *ifbdev = to_i915(dev)->fbdev; - if (ifbdev && ifbdev->vma) + if (ifbdev) drm_fb_helper_hotplug_event(&ifbdev->helper); }