diff mbox

crypto: cavium/nitrox - Remove default m setting from Kconfig

Message ID 20170710101532.GA15004@gondor.apana.org.au (mailing list archive)
State Not Applicable
Delegated to: Herbert Xu
Headers show

Commit Message

Herbert Xu July 10, 2017, 10:15 a.m. UTC 
Drivers should not enable themselves by default, unless they're
an integral part of the platform.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Linus Torvalds July 10, 2017, 6:51 p.m. UTC | #1 
Heh, I already did this in commit b4b8cbf679c4.

I complained because I want maintainers to be aware of this issue -
adding Kconfig options with defaults that don't make sense should be
caught earlier than when I do a test built..

                  Linus

On Mon, Jul 10, 2017 at 3:15 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Drivers should not enable themselves by default, unless they're
> an integral part of the platform.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/crypto/cavium/nitrox/Kconfig b/drivers/crypto/cavium/nitrox/Kconfig
> index 731e6a5..181a1df 100644
> --- a/drivers/crypto/cavium/nitrox/Kconfig
> +++ b/drivers/crypto/cavium/nitrox/Kconfig
> @@ -12,7 +12,6 @@ config CRYPTO_DEV_NITROX_CNN55XX
>         tristate "Support for Cavium CNN55XX driver"
>         depends on PCI_MSI && 64BIT
>         select CRYPTO_DEV_NITROX
> -       default m
>         help
>           Support for Cavium NITROX family CNN55XX driver
>           for accelerating crypto workloads.
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert Xu July 11, 2017, 2:14 a.m. UTC | #2 
On Mon, Jul 10, 2017 at 11:51:42AM -0700, Linus Torvalds wrote:
> Heh, I already did this in commit b4b8cbf679c4.
> 
> I complained because I want maintainers to be aware of this issue -
> adding Kconfig options with defaults that don't make sense should be
> caught earlier than when I do a test built..

OK, I will be more vigilant next time.

Cheers,
diff mbox

Patch

diff --git a/drivers/crypto/cavium/nitrox/Kconfig b/drivers/crypto/cavium/nitrox/Kconfig
index 731e6a5..181a1df 100644
--- a/drivers/crypto/cavium/nitrox/Kconfig
+++ b/drivers/crypto/cavium/nitrox/Kconfig
@@ -12,7 +12,6 @@  config CRYPTO_DEV_NITROX_CNN55XX
 	tristate "Support for Cavium CNN55XX driver"
 	depends on PCI_MSI && 64BIT
 	select CRYPTO_DEV_NITROX
-	default m
 	help
 	  Support for Cavium NITROX family CNN55XX driver
 	  for accelerating crypto workloads.