[v2,5/5] dt-bindings: display: fill Documents for series of vop
diff mbox

Message ID 1499825042-7652-1-git-send-email-mark.yao@rock-chips.com
State New
Headers show

Commit Message

yao mark July 12, 2017, 2:04 a.m. UTC
Changes in v2:
- rename rk322x to rk3228(Heiko Stübner)

Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
---
 Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Rob Herring July 17, 2017, 5:24 p.m. UTC | #1
On Wed, Jul 12, 2017 at 10:04:02AM +0800, Mark Yao wrote:
> Changes in v2:
> - rename rk322x to rk3228(Heiko Stübner)

This goes below '---' and you need a commit msg here. Also, it is not 
clear in the subject this is for Rockchip.


> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++
>  1 file changed, 4 insertions(+)
yao mark July 20, 2017, 2:10 a.m. UTC | #2
On 2017年07月18日 01:24, Rob Herring wrote:
> On Wed, Jul 12, 2017 at 10:04:02AM +0800, Mark Yao wrote:
>> Changes in v2:
>> - rename rk322x to rk3228(Heiko Stübner)
> This goes below '---' and you need a commit msg here. Also, it is not
> clear in the subject this is for Rockchip.
>

Got it, will fix it at next version.

Thanks.

>> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
>> ---
>>   Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++
>>   1 file changed, 4 insertions(+)
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
>
>

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
index 9eb3f0a..5d835d9 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
@@ -8,8 +8,12 @@  Required properties:
 - compatible: value should be one of the following
 		"rockchip,rk3036-vop";
 		"rockchip,rk3288-vop";
+		"rockchip,rk3368-vop";
+		"rockchip,rk3366-vop";
 		"rockchip,rk3399-vop-big";
 		"rockchip,rk3399-vop-lit";
+		"rockchip,rk3228-vop";
+		"rockchip,rk3328-vop";
 
 - interrupts: should contain a list of all VOP IP block interrupts in the
 		 order: VSYNC, LCD_SYSTEM. The interrupt specifier