From patchwork Mon Jul 17 15:10:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9845447 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5874560386 for ; Mon, 17 Jul 2017 15:11:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AD1928504 for ; Mon, 17 Jul 2017 15:11:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E8AA28509; Mon, 17 Jul 2017 15:11:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DC8EB28429 for ; Mon, 17 Jul 2017 15:10:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0673C6E240; Mon, 17 Jul 2017 15:10:59 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0FA0A89E3B for ; Mon, 17 Jul 2017 15:10:57 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id 15so11780458wmm.3 for ; Mon, 17 Jul 2017 08:10:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dQNXqZP9W8I1SERGNPLukHGgZrlvTIJAWrYphGccAIU=; b=hWKYbBp3Bc673N0nOljSf0ZZrcnDhWBG25sxGxCZ3Fl3tmK0wU+oGY0HoNeTIF8TUT HVsWBnyBsNPOuoqkozcD+uZprbErSWm/GThr5DAFT/1HWGbSaGmDF5lyEzFTqnvrM1Y2 bYpbLhcf5kiGCopwkO5PvqYWfA/1pmISAZxNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dQNXqZP9W8I1SERGNPLukHGgZrlvTIJAWrYphGccAIU=; b=nZXjLtWtRZxGAf4JN57xHbLxdFjHKuQ73mKIq8Ku4589/ZbiKf2j9JcTfp7Qps2JZ+ +Ptac+jc+nf5CXCCX3jMGyygDQNngCEhED0TfsBb0HS+ANFIPTTDdBXaFO9mjibGMvxP X3t4zgbsonIToYZLsfiWvfSQJNONIzdoOLKbiAEgUvw2zl06hppAnalEn0u4JB5+M0nh WITrfhSx3VGSfCMXkYvm23eETyWBnPcZLiA/hPabw65WZT/LcD0qKMuQRDv/G1fELDo4 RzVZMkKRrx8T7IAl2op5h0kihAEs50WRLswHXw+UTyfrh1wyFDS+NI0o+YOoMroLlagn c7lw== X-Gm-Message-State: AIVw112AmybUxW0zVWVO7vQZOrNPsqeO50RNYs62PVq+LaRBkV9ahtuI hayZdXezDwFQw6GsQ5g= X-Received: by 10.80.153.69 with SMTP id l5mr17596585edb.7.1500304255565; Mon, 17 Jul 2017 08:10:55 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5640:0:960b:2678:e223:c1c6]) by smtp.gmail.com with ESMTPSA id b22sm9065938edb.9.2017.07.17.08.10.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 08:10:54 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/3] drm/pl111: Use gem_free_object_unlocked Date: Mon, 17 Jul 2017 17:10:44 +0200 Message-Id: <20170717151045.4188-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170717151045.4188-1-daniel.vetter@ffwll.ch> References: <20170717151045.4188-1-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP CMA helpers are struct_mutex free, and so is the mxsfb itself. And that's the only valid reason for using gem_free_object. Please read the kerneldoc for this stuff :-) Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl111_drv.c index ac8771be70b0..8907bc261ab2 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -161,7 +161,7 @@ static struct drm_driver pl111_drm_driver = { .dumb_create = drm_gem_cma_dumb_create, .dumb_destroy = drm_gem_dumb_destroy, .dumb_map_offset = drm_gem_cma_dumb_map_offset, - .gem_free_object = drm_gem_cma_free_object, + .gem_free_object_unlocked = drm_gem_cma_free_object, .gem_vm_ops = &drm_gem_cma_vm_ops, .enable_vblank = pl111_enable_vblank,