From patchwork Tue Jul 18 06:39:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 9847053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 51D48600CC for ; Tue, 18 Jul 2017 06:42:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 48EA5274D0 for ; Tue, 18 Jul 2017 06:42:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3AB7C28542; Tue, 18 Jul 2017 06:42:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A9448274D0 for ; Tue, 18 Jul 2017 06:42:06 +0000 (UTC) Received: from localhost ([::1]:54376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXMCr-0004L0-VB for patchwork-qemu-devel@patchwork.kernel.org; Tue, 18 Jul 2017 02:42:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXMAG-0002Hu-Dw for qemu-devel@nongnu.org; Tue, 18 Jul 2017 02:39:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXMAF-0003zS-7v for qemu-devel@nongnu.org; Tue, 18 Jul 2017 02:39:24 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:34257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXMAF-0003z2-20; Tue, 18 Jul 2017 02:39:23 -0400 Received: by mail-pf0-x241.google.com with SMTP id o88so1599802pfk.1; Mon, 17 Jul 2017 23:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=0Z9ljCpDC9iQJVx2QWKQM5HuKq6LOocJgaEXih/MZv4=; b=ZBhul09PLdhNR9k6tl2ffpp9W4axnfmMEBBHfvUqxYY283kQFTZE8xJ/Ird3Y2X+5j jvnnoY6aw5XL6MKFrv0/pSnU1bT/Vhs6UVrxRgbA0su/6av3Ik97bfEjhPJ/6wvL4mxy LN6v3oRW/VkbuQVenLnxHu0tGdameVir8r/UrwlCGEB0Qp0tcyzL5FBm2QiMKTTsKBjS rcFlF5QyM4QVWgbTKfaSTli5OFy0Rk5//hTYDhwCOsgB0ZrHmGGvDhmNGzSRSK5Qfyj1 QTuhyhMq1MWs2Pulfo5vJWBiCAlKnjeeajwfCzivU1IUFoxGw4l9pIf/vosLz4rfulsD qccw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=0Z9ljCpDC9iQJVx2QWKQM5HuKq6LOocJgaEXih/MZv4=; b=HOblgd06EWdrY3KwnqCIT0eWEXP1DThaRYAnlRoHmHJBU7dRpt0TPJ7uFVszIWjx7R 07P1lxjLHRDxG4zB6pTgwKne0CbZG69BAUH5hOfeHMdxYB8z6SdxjC+KtGsa1eVUlH+v 8Xzdkj2pb3LyhV97eeaji0Bjjc6nNRsM4zAs0OseFyAf3Xwa+UwqPFd6xN3+gm4AUaGY huHOfPvgNCop994IwbFNORehe6gMLeDDIDpuNxsRetcqqNlp5YQmDo6418mGDcLJsrRt DO+zMbi94Ch+u7iv/1k2uO+AEEpR948DR74mkkwymYKKKvQPfsD+VCExkTxLDvzSbPvl p9pw== X-Gm-Message-State: AIVw112mQhFFZRuU5rvZIDQ9HovztDJf29zc15DxbZxgDIuAGZcKl2C3 MSYWfKLleCTFOg/8tIM= X-Received: by 10.98.67.147 with SMTP id l19mr121648pfi.198.1500359961703; Mon, 17 Jul 2017 23:39:21 -0700 (PDT) Received: from bigtime.twiddle.net ([101.165.234.197]) by smtp.gmail.com with ESMTPSA id s87sm2548402pfa.86.2017.07.17.23.39.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jul 2017 23:39:21 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 17 Jul 2017 20:39:07 -1000 Message-Id: <20170718063907.23525-1-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH] target/arm: Optimize aa64 rev16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, f4bug@amsat.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP It is much shorter to reverse all 4 half-words in parallel than extract, reverse, and deposit each in turn. Suggested-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index e55547d..6b247a7 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4042,25 +4042,13 @@ static void handle_rev16(DisasContext *s, unsigned int sf, TCGv_i64 tcg_rd = cpu_reg(s, rd); TCGv_i64 tcg_tmp = tcg_temp_new_i64(); TCGv_i64 tcg_rn = read_cpu_reg(s, rn, sf); + TCGv_i64 mask = tcg_const_i64(sf ? 0x00ff00ff00ff00ffull : 0x00ff00ff); - tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); - tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); - - if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 48); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 48, 16); - } + tcg_gen_shri_i64(tcg_tmp, tcg_rn, 8); + tcg_gen_and_i64(tcg_rd, tcg_rn, mask); + tcg_gen_and_i64(tcg_tmp, tcg_tmp, mask); + tcg_gen_shli_i64(tcg_rd, tcg_rd, 8); + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_tmp); tcg_temp_free_i64(tcg_tmp); }