diff mbox

[1/8] ARM: OMAP2+: board-generic: add support for dra76x family

Message ID 20170718195503.1700-2-lokeshvutla@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Lokesh Vutla July 18, 2017, 7:54 p.m. UTC
Adding board generic support for dra76 family.

Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++
 arch/arm/mach-omap2/board-generic.c                 | 1 +
 2 files changed, 4 insertions(+)

Comments

Rob Herring July 24, 2017, 7:02 p.m. UTC | #1
On Wed, Jul 19, 2017 at 01:24:56AM +0530, Lokesh Vutla wrote:
> Adding board generic support for dra76 family.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++
>  arch/arm/mach-omap2/board-generic.c                 | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> index 8219b2c6bb29..ffe02755a285 100644
> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> @@ -80,6 +80,9 @@ SoCs:
>  - OMAP5432
>    compatible = "ti,omap5432", "ti,omap5"
>  
> +- DRA762
> +  compatible = "ti,dra76", "ti,dra7"

76 or 762?

How many of these 2 or 3 compatible strings actually get used? I'd 
prefer to see one of these less specific compatibles get dropped.

> +
>  - DRA742
>    compatible = "ti,dra742", "ti,dra74", "ti,dra7"
>  
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index dc9e34e670a2..e5d9d769a76e 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -312,6 +312,7 @@ MACHINE_END
>  
>  #ifdef CONFIG_SOC_DRA7XX
>  static const char *const dra74x_boards_compat[] __initconst = {
> +	"ti,dra76",
>  	"ti,am5728",
>  	"ti,am5726",
>  	"ti,dra742",
> -- 
> 2.13.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lokesh Vutla July 25, 2017, 6:40 a.m. UTC | #2
On 7/25/2017 12:32 AM, Rob Herring wrote:
> On Wed, Jul 19, 2017 at 01:24:56AM +0530, Lokesh Vutla wrote:
>> Adding board generic support for dra76 family.
>>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>> ---
>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++
>>  arch/arm/mach-omap2/board-generic.c                 | 1 +
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
>> index 8219b2c6bb29..ffe02755a285 100644
>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
>> @@ -80,6 +80,9 @@ SoCs:
>>  - OMAP5432
>>    compatible = "ti,omap5432", "ti,omap5"
>>  
>> +- DRA762
>> +  compatible = "ti,dra76", "ti,dra7"
> 
> 76 or 762?

Just wanted to cover all variants of dra76x with this compatible. Okay
ill use 762.

> 
> How many of these 2 or 3 compatible strings actually get used? I'd 
> prefer to see one of these less specific compatibles get dropped.

ti,dra76 is being used. Ill try not to include ti,dra7 and post it again.

Thanks and regards,
Lokesh

> 
>> +
>>  - DRA742
>>    compatible = "ti,dra742", "ti,dra74", "ti,dra7"
>>  
>> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
>> index dc9e34e670a2..e5d9d769a76e 100644
>> --- a/arch/arm/mach-omap2/board-generic.c
>> +++ b/arch/arm/mach-omap2/board-generic.c
>> @@ -312,6 +312,7 @@ MACHINE_END
>>  
>>  #ifdef CONFIG_SOC_DRA7XX
>>  static const char *const dra74x_boards_compat[] __initconst = {
>> +	"ti,dra76",
>>  	"ti,am5728",
>>  	"ti,am5726",
>>  	"ti,dra742",
>> -- 
>> 2.13.0
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lokesh Vutla July 30, 2017, 11:19 a.m. UTC | #3
Rob,

On 7/25/2017 12:10 PM, Lokesh Vutla wrote:
> 
> 
> On 7/25/2017 12:32 AM, Rob Herring wrote:
>> On Wed, Jul 19, 2017 at 01:24:56AM +0530, Lokesh Vutla wrote:
>>> Adding board generic support for dra76 family.
>>>
>>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++
>>>  arch/arm/mach-omap2/board-generic.c                 | 1 +
>>>  2 files changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> index 8219b2c6bb29..ffe02755a285 100644
>>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
>>> @@ -80,6 +80,9 @@ SoCs:
>>>  - OMAP5432
>>>    compatible = "ti,omap5432", "ti,omap5"
>>>  
>>> +- DRA762
>>> +  compatible = "ti,dra76", "ti,dra7"
>>
>> 76 or 762?
> 
> Just wanted to cover all variants of dra76x with this compatible. Okay
> ill use 762.
> 
>>
>> How many of these 2 or 3 compatible strings actually get used? I'd 
>> prefer to see one of these less specific compatibles get dropped.
> 
> ti,dra76 is being used. Ill try not to include ti,dra7 and post it again.

ti,dra7 is being used by cpufreq driver . So, I would like to use both
ti,dra762 and ti,dra7 as compatible.

Thanks and regards,
Lokesh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Aug. 11, 2017, 3:42 p.m. UTC | #4
* Lokesh Vutla <lokeshvutla@ti.com> [170730 04:20]:
> Rob,
> 
> On 7/25/2017 12:10 PM, Lokesh Vutla wrote:
> > 
> > 
> > On 7/25/2017 12:32 AM, Rob Herring wrote:
> >> On Wed, Jul 19, 2017 at 01:24:56AM +0530, Lokesh Vutla wrote:
> >>> Adding board generic support for dra76 family.
> >>>
> >>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++
> >>>  arch/arm/mach-omap2/board-generic.c                 | 1 +
> >>>  2 files changed, 4 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> index 8219b2c6bb29..ffe02755a285 100644
> >>> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> >>> @@ -80,6 +80,9 @@ SoCs:
> >>>  - OMAP5432
> >>>    compatible = "ti,omap5432", "ti,omap5"
> >>>  
> >>> +- DRA762
> >>> +  compatible = "ti,dra76", "ti,dra7"
> >>
> >> 76 or 762?
> > 
> > Just wanted to cover all variants of dra76x with this compatible. Okay
> > ill use 762.
> > 
> >>
> >> How many of these 2 or 3 compatible strings actually get used? I'd 
> >> prefer to see one of these less specific compatibles get dropped.
> > 
> > ti,dra76 is being used. Ill try not to include ti,dra7 and post it again.
> 
> ti,dra7 is being used by cpufreq driver . So, I would like to use both
> ti,dra762 and ti,dra7 as compatible.

So are you going to repost this one with ti,dra762 and ti,dra7?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
index 8219b2c6bb29..ffe02755a285 100644
--- a/Documentation/devicetree/bindings/arm/omap/omap.txt
+++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
@@ -80,6 +80,9 @@  SoCs:
 - OMAP5432
   compatible = "ti,omap5432", "ti,omap5"
 
+- DRA762
+  compatible = "ti,dra76", "ti,dra7"
+
 - DRA742
   compatible = "ti,dra742", "ti,dra74", "ti,dra7"
 
diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
index dc9e34e670a2..e5d9d769a76e 100644
--- a/arch/arm/mach-omap2/board-generic.c
+++ b/arch/arm/mach-omap2/board-generic.c
@@ -312,6 +312,7 @@  MACHINE_END
 
 #ifdef CONFIG_SOC_DRA7XX
 static const char *const dra74x_boards_compat[] __initconst = {
+	"ti,dra76",
 	"ti,am5728",
 	"ti,am5726",
 	"ti,dra742",