From patchwork Wed Jul 19 04:57:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 9850493 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DDAC7602BD for ; Wed, 19 Jul 2017 05:01:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB73E285FE for ; Wed, 19 Jul 2017 05:01:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BEE28285FB; Wed, 19 Jul 2017 05:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1CBE9285FB for ; Wed, 19 Jul 2017 05:01:09 +0000 (UTC) Received: from localhost ([::1]:59894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXh6i-0005Qp-BU for patchwork-qemu-devel@patchwork.kernel.org; Wed, 19 Jul 2017 01:01:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXh3X-0003Q5-AN for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXh3W-000297-Cd for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:57:51 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:35876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXh3W-00028t-1J for qemu-devel@nongnu.org; Wed, 19 Jul 2017 00:57:50 -0400 Received: by mail-pg0-x244.google.com with SMTP id y129so5429015pgy.3 for ; Tue, 18 Jul 2017 21:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=AEiT3T0A46sjcTvOEbqlLPAzHl4MGJfDUrOqHcIn8iY=; b=ADqFLd2ypbZoyjoEG8PaKbt9SHwUU3DdYFxFpTqT4I4SUvb3IImwbxVlHjHnwWn5CR n1toIVzq2xAwCIwX6mE5DP/KxYhIvhtiiOzhaSeGez6/Sg7JUsNQDUORrD0dGBKFY1dZ hyo5nSAuhY9mQBpmmOTlfOW+sBWTUe2WUPM6ZI+Iv6ss+S+8BWe/Imx49Ar9jifnoiwY 0FZ2kqCTTC3lWegpHjifbja02Phv2S434O9CXL+LFm+eIY8isPzD81g0A388o3/Nzw4M Xr5ja6PnNhVO62xcUHMVgTKPkTPFJMcEkKQA5HddrpbVpiI4qjzBP/ltxO3GFiAfF2L4 aNyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=AEiT3T0A46sjcTvOEbqlLPAzHl4MGJfDUrOqHcIn8iY=; b=Jjm/qMvfHoxi0WFMIysH5JnczQWn/OmirDdVvYh7+cFZalfBD0qOElMhW9HKDX4JDr sTz+Vhy9tXNgqp4Vt1D2XndBpKA3N9ez9RmnyKeMGr1IhcJwBlbRAVlqaoimVujaWg2s HW2Zm4aTdoIN6Pt2JO5A0FwKqv2LEEInwNt4/o0I1t37W0QZWpwvOXsUC3ex8OwZ4nR+ DFYds+VSHp4lK+ee24VPrwtAaNIGGZjBaNQA1POP+A+gufPeGbrU3FAZjJeFadTqeeZu a/GIhfLpD9PhptPF7369CxKyvQwXi653R48JF5T1FxIpL8yokD8VyT40NHWhbwkbJ/jN 1Cog== X-Gm-Message-State: AIVw113MIki2hDYbJ9aUiMGCnnQV1KGy79y+TVfD+MMs4wFdbdbxrT7B hp3eWJ4/nurZmHUNBYg= X-Received: by 10.98.142.1 with SMTP id k1mr1134104pfe.189.1500440268895; Tue, 18 Jul 2017 21:57:48 -0700 (PDT) Received: from bigtime.twiddle.net (14-203-207-215.tpgi.com.au. [14.203.207.215]) by smtp.gmail.com with ESMTPSA id m196sm9062855pga.33.2017.07.18.21.57.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Jul 2017 21:57:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 18 Jul 2017 18:57:14 -1000 Message-Id: <20170719045722.25492-7-rth@twiddle.net> X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170719045722.25492-1-rth@twiddle.net> References: <20170719045722.25492-1-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 06/14] target/arm: Optimize aarch64 rev16 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP It is much shorter to reverse all 4 half-words in parallel than extract, reverse, and deposit each in turn. Suggested-by: Aurelien Jarno Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 3fa3902..5bb0f8e 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4043,25 +4043,13 @@ static void handle_rev16(DisasContext *s, unsigned int sf, TCGv_i64 tcg_rd = cpu_reg(s, rd); TCGv_i64 tcg_tmp = tcg_temp_new_i64(); TCGv_i64 tcg_rn = read_cpu_reg(s, rn, sf); + TCGv_i64 mask = tcg_const_i64(sf ? 0x00ff00ff00ff00ffull : 0x00ff00ff); - tcg_gen_andi_i64(tcg_tmp, tcg_rn, 0xffff); - tcg_gen_bswap16_i64(tcg_rd, tcg_tmp); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 16); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 16, 16); - - if (sf) { - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 32); - tcg_gen_andi_i64(tcg_tmp, tcg_tmp, 0xffff); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 32, 16); - - tcg_gen_shri_i64(tcg_tmp, tcg_rn, 48); - tcg_gen_bswap16_i64(tcg_tmp, tcg_tmp); - tcg_gen_deposit_i64(tcg_rd, tcg_rd, tcg_tmp, 48, 16); - } + tcg_gen_shri_i64(tcg_tmp, tcg_rn, 8); + tcg_gen_and_i64(tcg_rd, tcg_rn, mask); + tcg_gen_and_i64(tcg_tmp, tcg_tmp, mask); + tcg_gen_shli_i64(tcg_rd, tcg_rd, 8); + tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_tmp); tcg_temp_free_i64(tcg_tmp); }