ath10k_htt_rx_amsdu_allowed(): use ath10k_dbg()
diff mbox

Message ID 288fce5b-d738-f0ac-2433-67e1b35a0664@gmail.com
State New
Headers show

Commit Message

Gabriel C July 19, 2017, 3:37 p.m. UTC
Each time we get disconencted from AP we get flooded with messages like:

         ...
         ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
         <until ratelimit kicks in>
         ath10k_warn: 155 callbacks suppressed
         ...

         Use ath10k_dbg() here too.

Signed-off-by: Gabriel Craciunescu <nix.or.die@gmail.com>
---
  drivers/net/wireless/ath/ath10k/htt_rx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Perches July 19, 2017, 4:26 p.m. UTC | #1
On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
>          Each time we get disconencted from AP we get flooded with messages like:
> 
>          ...
>          ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
>          <until ratelimit kicks in>
>          ath10k_warn: 155 callbacks suppressed

[]

> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
[]
> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>           */
> 
>          if (!rx_status->freq) {
> -               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>                  return false;
>          }

Hi.  This doesn't apply because of tab to space conversions.

Please use git send-email to send your patch.

Maybe read Documentation/process/email-clients.rst
Gabriel C July 19, 2017, 6:12 p.m. UTC | #2
On 19.07.2017 18:26, Joe Perches wrote:
> On Wed, 2017-07-19 at 17:37 +0200, Gabriel C wrote:
>>           Each time we get disconencted from AP we get flooded with messages like:
>>
>>           ...
>>           ath10k_pci 0000:03:00.0: no channel configured; ignoring frame(s)!
>>           <until ratelimit kicks in>
>>           ath10k_warn: 155 callbacks suppressed
> 
> []
> 
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
> []
>> @@ -1514,7 +1514,7 @@ static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
>>            */
>>
>>           if (!rx_status->freq) {
>> -               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
>> +               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
>>                   return false;
>>           }
> 
> Hi.  This doesn't apply because of tab to space conversions.
> 
> Please use git send-email to send your patch.

Yes you are right .. I think newer thunderbird just doesn't work anymore to send patches.

Will have a look to setup git send-email and resend.

> 
> Maybe read Documentation/process/email-clients.rst
> 

I use tbird to send patches forver but it seems latest updates here broke it some sort.

Patch
diff mbox

diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c
index 398dda978d6e..75d9b59b7e63 100644
--- a/drivers/net/wireless/ath/ath10k/htt_rx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_rx.c
@@ -1514,7 +1514,7 @@  static bool ath10k_htt_rx_amsdu_allowed(struct ath10k *ar,
          */

         if (!rx_status->freq) {
-               ath10k_warn(ar, "no channel configured; ignoring frame(s)!\n");
+               ath10k_dbg(ar, ATH10K_DBG_HTT, "no channel configured; ignoring frame(s)!\n");
                 return false;
         }