[02/11] present_address: remove a warning
diff mbox

Message ID 20170719205354.10006-3-steved@redhat.com
State New
Headers show

Commit Message

Steve Dickson July 19, 2017, 8:53 p.m. UTC
tcpwrapper.c:73:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 support/misc/tcpwrapper.c | 1 +
 1 file changed, 1 insertion(+)

Comments

J. Bruce Fields July 20, 2017, 6:42 p.m. UTC | #1
On Wed, Jul 19, 2017 at 04:53:45PM -0400, Steve Dickson wrote:
> tcpwrapper.c:73:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

This one looks like a real bugfix to me; could use a changelog.

--b.

> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  support/misc/tcpwrapper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/support/misc/tcpwrapper.c b/support/misc/tcpwrapper.c
> index 06b0a46..3128053 100644
> --- a/support/misc/tcpwrapper.c
> +++ b/support/misc/tcpwrapper.c
> @@ -72,6 +72,7 @@ present_address(const struct sockaddr *sap, char *buf, const size_t buflen)
>  	case AF_INET:
>  		if (inet_ntop(AF_INET, &sin->sin_addr, buf, len) != 0)
>  			return;
> +		break;
>  	case AF_INET6:
>  		if (inet_ntop(AF_INET6, &sin6->sin6_addr, buf, len) != 0)
>  			return;
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/support/misc/tcpwrapper.c b/support/misc/tcpwrapper.c
index 06b0a46..3128053 100644
--- a/support/misc/tcpwrapper.c
+++ b/support/misc/tcpwrapper.c
@@ -72,6 +72,7 @@  present_address(const struct sockaddr *sap, char *buf, const size_t buflen)
 	case AF_INET:
 		if (inet_ntop(AF_INET, &sin->sin_addr, buf, len) != 0)
 			return;
+		break;
 	case AF_INET6:
 		if (inet_ntop(AF_INET6, &sin6->sin6_addr, buf, len) != 0)
 			return;