From patchwork Wed Jul 19 23:34:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 9853381 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5F8D860392 for ; Wed, 19 Jul 2017 23:44:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DBD922A68 for ; Wed, 19 Jul 2017 23:44:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3215B2871B; Wed, 19 Jul 2017 23:44:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5304A22A68 for ; Wed, 19 Jul 2017 23:44:48 +0000 (UTC) Received: from localhost ([::1]:35417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXye7-0006fk-JJ for patchwork-qemu-devel@patchwork.kernel.org; Wed, 19 Jul 2017 19:44:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXyVw-0008T5-3G for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXyVu-00071H-UP for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:20 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:38609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXyVu-000719-QI for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:18 -0400 Received: by mail-qt0-x241.google.com with SMTP id h47so1768658qta.5 for ; Wed, 19 Jul 2017 16:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=93k+ezACAhYC59QJOHnrNta+EITu8k2xOSxDmJs1mhA=; b=WGeQ4rWYut69JbdW3ELP8wnkjAea2Niuk5TGhpMmmX9K+4woOtapoOgc8B7D0ZU/VP FRKS1F04EW4VJbmBsvIUUqiB6NxaGRrWaw9lzb1pccHljbxDDxc3fNqfklbnXdpBlRvw IF9AGAa3nc08oATD6mBIHfnWO7OuBTEdSG6XrdhjlRwa02vJZb5ZveShVAzLWKhW2TQ8 ZPt0W3jCIXPbYQzPbKyb375PXLqazG7fVZ5vDdsUH4dw/7Crg/xIhwd4qz3VWz0tkEsf q2PzcgeX+2ktNk8tjd1LqvZRQxLp7nVt5iD+Nw6LIZpUtEYAB5W8ZP/DgP7Z1HNPSvD5 mnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=93k+ezACAhYC59QJOHnrNta+EITu8k2xOSxDmJs1mhA=; b=J2RGUwJy/xDajo97aktcfQKptuw6NxSohGwv8038x/jwbExrP1pSovleSnjAdXzaf7 qZnpZLBD7y7RsBP4CRLCy/6DaoKGRXw/yziB6mvUE5cBdYHb7fQ35lPoBXJ3O53Fg1vC zN74szVL2f1ntUHlEUKqc3a9tp2YdOesozquA0GJ5L4UjE2muLqdkX2DH4nB9s4E2Agp ArBxHcXmLp6P2SehucrJsMqF9b1iIiO1D7ikrSFdWHWQkURh0NbThAevIu5u69DAaSX2 ADFBeixgndLj54Qd95oIS0JjEpYFCVKGcDiizaki+b7SQD5OfR3S45VBNTKUWcb+u2xj RP5w== X-Gm-Message-State: AIVw112OpgAtT22L18XQT1FC1z9TUkhc5VoO/t+mx0OQX+oSbb4WDaEI uT0QbEW7wEInoW4+Ad4= X-Received: by 10.200.41.220 with SMTP id 28mr2545487qtt.168.1500507378077; Wed, 19 Jul 2017 16:36:18 -0700 (PDT) Received: from bigtime.com ([203.221.203.174]) by smtp.gmail.com with ESMTPSA id w33sm857130qth.96.2017.07.19.16.36.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Jul 2017 16:36:17 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 19 Jul 2017 13:34:54 -1000 Message-Id: <20170719233455.8740-14-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170719233455.8740-1-rth@twiddle.net> References: <20170719233455.8740-1-rth@twiddle.net> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PULL v2 13/14] tcg/tci: enable bswap16_i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jaroslaw Pelczar Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Philippe Mathieu-Daudé Altough correctly implemented, bswap16_i64() never got tested/executed so the safety TODO() statement was never removed. Since it got now tested the TODO() can be removed. while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img: Trace 0x7fa1904b0890 [0: ffffffc00036cd04] ---------------- IN: 0xffffffc00036cd24: 5ac00694 rev16 w20, w20 OP: ---- ffffffc00036cd24 0000000000000000 0000000000000000 ext32u_i64 tmp3,x20 ext16u_i64 tmp2,tmp3 bswap16_i64 x20,tmp2 movi_i64 tmp4,$0x10 shr_i64 tmp2,tmp3,tmp4 ext16u_i64 tmp2,tmp2 bswap16_i64 tmp2,tmp2 deposit_i64 x20,x20,tmp2,$0x10,$0x10 Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24] Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24] TODO qemu/tci.c:1049: tcg_qemu_tb_exec() qemu/tci.c:1049: tcg fatal error Aborted Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Jaroslaw Pelczar Reviewed-by: Alex Bennée Reviewed-by: Eric Blake Reviewed-by: Stefan Weil Message-Id: <20170718045540.16322-11-f4bug@amsat.org> Signed-off-by: Richard Henderson --- tcg/tci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tci.c b/tcg/tci.c index 4bdc645f2a..f39bfb95c0 100644 --- a/tcg/tci.c +++ b/tcg/tci.c @@ -1046,7 +1046,6 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) break; #if TCG_TARGET_HAS_bswap16_i64 case INDEX_op_bswap16_i64: - TODO(); t0 = *tb_ptr++; t1 = tci_read_r16(&tb_ptr); tci_write_reg64(t0, bswap16(t1));