| Message ID | 20170721161704.3335851-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote: > We get a Kconfig warning when selecting this without also enabling > CONFIG_PCI: > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects > IOSF_MBI which has unmet direct dependencies (PCI) > > This adds a new depedency. > > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common > APIs") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > --- > drivers/thermal/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index b5b5facb8747..ac2a53823576 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL > > config INTEL_SOC_DTS_IOSF_CORE > tristate > - depends on X86 > + depends on X86 && PCI > select IOSF_MBI > help > This is becoming a common feature for Intel SoCs to expose > the additional > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE > > config INTEL_SOC_DTS_THERMAL > tristate "Intel SoCs DTS thermal driver" > - depends on X86 > + depends on X86 && PCI > select INTEL_SOC_DTS_IOSF_CORE > select THERMAL_WRITABLE_TRIPS > help
On Sat, 2017-07-29 at 13:22 -0600, Pandruvada, Srinivas wrote: > On Fri, 2017-07-21 at 18:16 +0200, Arnd Bergmann wrote: > > > > We get a Kconfig warning when selecting this without also enabling > > CONFIG_PCI: > > > > warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && > > SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects > > IOSF_MBI which has unmet direct dependencies (PCI) > > > > This adds a new depedency. > > > > Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common > > APIs") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com Applied. thanks, rui > > > > > > > --- > > drivers/thermal/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index b5b5facb8747..ac2a53823576 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL > > > > config INTEL_SOC_DTS_IOSF_CORE > > tristate > > - depends on X86 > > + depends on X86 && PCI > > select IOSF_MBI > > help > > This is becoming a common feature for Intel SoCs to > > expose > > the additional > > @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE > > > > config INTEL_SOC_DTS_THERMAL > > tristate "Intel SoCs DTS thermal driver" > > - depends on X86 > > + depends on X86 && PCI > > select INTEL_SOC_DTS_IOSF_CORE > > select THERMAL_WRITABLE_TRIPS > > help
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index b5b5facb8747..ac2a53823576 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -342,7 +342,7 @@ config X86_PKG_TEMP_THERMAL config INTEL_SOC_DTS_IOSF_CORE tristate - depends on X86 + depends on X86 && PCI select IOSF_MBI help This is becoming a common feature for Intel SoCs to expose the additional @@ -352,7 +352,7 @@ config INTEL_SOC_DTS_IOSF_CORE config INTEL_SOC_DTS_THERMAL tristate "Intel SoCs DTS thermal driver" - depends on X86 + depends on X86 && PCI select INTEL_SOC_DTS_IOSF_CORE select THERMAL_WRITABLE_TRIPS help
We get a Kconfig warning when selecting this without also enabling CONFIG_PCI: warning: (X86_INTEL_LPSS && INTEL_SOC_DTS_IOSF_CORE && SND_SST_IPC_ACPI && MMC_SDHCI_ACPI && PUNIT_ATOM_DEBUG) selects IOSF_MBI which has unmet direct dependencies (PCI) This adds a new depedency. Fixes: 3a2419f865a6 ("Thermal: Intel SoC: DTS thermal use common APIs") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/thermal/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)