[v2] btrfs: preserve i_mode if __btrfs_set_acl() fails
diff mbox

Message ID 20170730021838.GA4565@debian.home
State New
Headers show

Commit Message

Ernesto A. Fernández July 30, 2017, 2:18 a.m. UTC
When changing a file's acl mask, btrfs_set_acl() will first set the
group bits of i_mode to the value of the mask, and only then set the
actual extended attribute representing the new acl.

If the second part fails (due to lack of space, for example) and the
file had no acl attribute to begin with, the system will from now on
assume that the mask permission bits are actual group permission bits,
potentially granting access to the wrong users.

Prevent this by starting the journal transaction before calling
__btrfs_set_acl and only changing the inode mode after the acl is set

Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
Changes in v2:
  - Take the code that checks if we are setting a default acl on something
    that is not a dir, remove it from the __btrfs_set_acl function, and
    place it in btrfs_set_acl instead. This should fix the issue pointed out
    by Josef Bacik, that I was sometimes updating the inode even when there
    was no change.
  - Don't call BUG_ON when the inode failed to update. Also requested by
    Josef Bacik. It should be noted that __btrfs_setxattr was already
    calling BUG_ON before my patch; that has not been changed.

 fs/btrfs/acl.c | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff mbox

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 8d8370d..f62e8ac 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -27,6 +27,7 @@ 
 #include "ctree.h"
 #include "btrfs_inode.h"
 #include "xattr.h"
+#include "transaction.h"
 struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
@@ -80,8 +81,6 @@  static int __btrfs_set_acl(struct btrfs_trans_handle *trans,
-		if (!S_ISDIR(inode->i_mode))
-			return acl ? -EINVAL : 0;
@@ -113,14 +112,38 @@  static int __btrfs_set_acl(struct btrfs_trans_handle *trans,
 int btrfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
+	struct btrfs_root *root = BTRFS_I(inode)->root;
+	struct btrfs_trans_handle *trans;
 	int ret;
+	umode_t mode = inode->i_mode;
+	if (type == ACL_TYPE_DEFAULT && !S_ISDIR(inode->i_mode))
+		return acl ? -EINVAL : 0;
 	if (type == ACL_TYPE_ACCESS && acl) {
-		ret = posix_acl_update_mode(inode, &inode->i_mode, &acl);
+		ret = posix_acl_update_mode(inode, &mode, &acl);
 		if (ret)
 			return ret;
-	return __btrfs_set_acl(NULL, inode, acl, type);
+	if (btrfs_root_readonly(root))
+		return -EROFS;
+	trans = btrfs_start_transaction(root, 2);
+	if (IS_ERR(trans))
+		return PTR_ERR(trans);
+	ret = __btrfs_set_acl(trans, inode, acl, type);
+	if (ret)
+		goto out;
+	inode->i_mode = mode;
+	inode_inc_iversion(inode);
+	inode->i_ctime = current_time(inode);
+	set_bit(BTRFS_INODE_COPY_EVERYTHING, &BTRFS_I(inode)->runtime_flags);
+	ret = btrfs_update_inode(trans, root, inode);
+	btrfs_end_transaction(trans);
+	return ret;