Patchwork dma-buf/sync_file: document flags field

login
register
mail settings
Submitter Gustavo F. Padovan
Date July 31, 2017, 7:36 p.m.
Message ID <20170731193655.6176-1-gustavo@padovan.org>
Download mbox | patch
Permalink /patch/9873067/
State New
Headers show

Comments

Gustavo F. Padovan - July 31, 2017, 7:36 p.m.
From: Gustavo Padovan <gustavo.padovan@collabora.com>

Documentation for it was missing.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
---
 include/linux/sync_file.h | 4 ++++
 1 file changed, 4 insertions(+)
Sumit Semwal - Aug. 1, 2017, 6:17 a.m.
Hi Gustavo,

On 1 August 2017 at 01:06, Gustavo Padovan <gustavo@padovan.org> wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.com>
>
> Documentation for it was missing.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>

> ---
>  include/linux/sync_file.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/sync_file.h b/include/linux/sync_file.h
> index 0ad87c4..790ca02 100644
> --- a/include/linux/sync_file.h
> +++ b/include/linux/sync_file.h
> @@ -25,8 +25,12 @@
>   * @file:              file representing this fence
>   * @sync_file_list:    membership in global file list
>   * @wq:                        wait queue for fence signaling
> + * @flags:             flags for the sync_file
>   * @fence:             fence with the fences in the sync_file
>   * @cb:                        fence callback information
> + *
> + * flags:
> + * POLL_ENABLED: whether userspace is currently poll()'ing or not
>   */
>  struct sync_file {
>         struct file             *file;
> --
> 2.9.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Best,
Sumit.
Gustavo F. Padovan - Aug. 18, 2017, 6:29 p.m.
2017-08-01 Sumit Semwal <sumit.semwal@linaro.org>:

> Hi Gustavo,
> 
> On 1 August 2017 at 01:06, Gustavo Padovan <gustavo@padovan.org> wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.com>
> >
> > Documentation for it was missing.
> >
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
> Acked-by: Sumit Semwal <sumit.semwal@linaro.org>

Thanks. Pushed to drm-misc-next.

	Gustavo

Patch

diff --git a/include/linux/sync_file.h b/include/linux/sync_file.h
index 0ad87c4..790ca02 100644
--- a/include/linux/sync_file.h
+++ b/include/linux/sync_file.h
@@ -25,8 +25,12 @@ 
  * @file:		file representing this fence
  * @sync_file_list:	membership in global file list
  * @wq:			wait queue for fence signaling
+ * @flags:		flags for the sync_file
  * @fence:		fence with the fences in the sync_file
  * @cb:			fence callback information
+ *
+ * flags:
+ * POLL_ENABLED: whether userspace is currently poll()'ing or not
  */
 struct sync_file {
 	struct file		*file;