diff mbox

[v4,15/15] exec: Consolidate pdeath_signal clearing

Message ID 1501545093-56634-16-git-send-email-keescook@chromium.org (mailing list archive)
State New, archived
Headers show

Commit Message

Kees Cook July 31, 2017, 11:51 p.m. UTC 
Instead of an additional secureexec check for pdeath_signal, just move it
up into the initial secureexec test. Neither perf nor arch code touches
pdeath_signal, so the relocation shouldn't change anything.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Serge Hallyn <serge@hallyn.com>
---
 fs/exec.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

James Morris Aug. 1, 2017, 12:52 a.m. UTC | #1 
On Mon, 31 Jul 2017, Kees Cook wrote:

> Instead of an additional secureexec check for pdeath_signal, just move it
> up into the initial secureexec test. Neither perf nor arch code touches
> pdeath_signal, so the relocation shouldn't change anything.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Serge Hallyn <serge@hallyn.com>


Reviewed-by: James Morris <james.l.morris@oracle.com>
diff mbox

Patch

diff --git a/fs/exec.c b/fs/exec.c
index cddd2a2cbc1f..5a19912a4f53 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1330,6 +1330,9 @@  void setup_new_exec(struct linux_binprm * bprm)
 	bprm->secureexec |= bprm->cap_elevated;
 
 	if (bprm->secureexec) {
+		/* Make sure parent cannot signal privileged process. */
+		current->pdeath_signal = 0;
+
 		/*
 		 * For secureexec, reset the stack limit to sane default to
 		 * avoid bad behavior from the prior rlimits. This has to
@@ -1362,10 +1365,6 @@  void setup_new_exec(struct linux_binprm * bprm)
 	 */
 	current->mm->task_size = TASK_SIZE;
 
-	if (bprm->secureexec) {
-		current->pdeath_signal = 0;
-	}
-
 	/* An exec changes our domain. We are no longer part of the thread
 	   group */
 	current->self_exec_id++;