[3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI.
diff mbox

Message ID 20170802203242.12815-3-eric@anholt.net
State New
Headers show

Commit Message

Eric Anholt Aug. 2, 2017, 8:32 p.m. UTC
drm_bridge_remove() is for unregistering a bridge driver, not for
detaching a bridge from its consumer.

Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Noralf Trønnes Aug. 3, 2017, 1:37 p.m. UTC | #1
Den 02.08.2017 22.32, skrev Eric Anholt:
> drm_bridge_remove() is for unregistering a bridge driver, not for
> detaching a bridge from its consumer.
>
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>

>   drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>   
>   	pm_runtime_disable(dev);
>   
> -	drm_bridge_remove(dsi->bridge);
>   	vc4_dsi_encoder_destroy(dsi->encoder);
>   
>   	mipi_dsi_host_unregister(&dsi->dsi_host);
Boris BREZILLON Aug. 4, 2017, 10:08 a.m. UTC | #2
On Wed,  2 Aug 2017 13:32:42 -0700
Eric Anholt <eric@anholt.net> wrote:

> drm_bridge_remove() is for unregistering a bridge driver, not for

s/driver/device/

> detaching a bridge from its consumer.
> 
> Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.")
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 13481bb6322f..d1e0dc908048 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>  
>  	pm_runtime_disable(dev);
>  
> -	drm_bridge_remove(dsi->bridge);
>  	vc4_dsi_encoder_destroy(dsi->encoder);
>  
>  	mipi_dsi_host_unregister(&dsi->dsi_host);

Patch
diff mbox

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index 13481bb6322f..d1e0dc908048 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -1636,7 +1636,6 @@  static void vc4_dsi_unbind(struct device *dev, struct device *master,
 
 	pm_runtime_disable(dev);
 
-	drm_bridge_remove(dsi->bridge);
 	vc4_dsi_encoder_destroy(dsi->encoder);
 
 	mipi_dsi_host_unregister(&dsi->dsi_host);