[2/3] drm/vc4: Don't disable DSI clocks on component unload.
diff mbox

Message ID 20170802203242.12815-2-eric@anholt.net
State New
Headers show

Commit Message

Eric Anholt Aug. 2, 2017, 8:32 p.m. UTC
The clocks are enabled/disabled at encoder enable/disable time, not at
component load.  Fixes a WARN_ON at boot if V3D fails to probe.

Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Noralf Trønnes Aug. 3, 2017, 1:37 p.m. UTC | #1
Den 02.08.2017 22.32, skrev Eric Anholt:
> The clocks are enabled/disabled at encoder enable/disable time, not at
> component load.  Fixes a WARN_ON at boot if V3D fails to probe.
>
> Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---

Acked-by: Noralf Trønnes <noralf@tronnes.org>

>   drivers/gpu/drm/vc4/vc4_dsi.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 629d372633e6..13481bb6322f 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>   
>   	mipi_dsi_host_unregister(&dsi->dsi_host);
>   
> -	clk_disable_unprepare(dsi->pll_phy_clock);
> -	clk_disable_unprepare(dsi->escape_clock);
> -
>   	if (dsi->port == 1)
>   		vc4->dsi1 = NULL;
>   }
Boris BREZILLON Aug. 4, 2017, 10:02 a.m. UTC | #2
On Wed,  2 Aug 2017 13:32:41 -0700
Eric Anholt <eric@anholt.net> wrote:

> The clocks are enabled/disabled at encoder enable/disable time, not at
> component load.  Fixes a WARN_ON at boot if V3D fails to probe.
> 
> Fixes: 4078f5757144 ("drm/vc4: Add DSI driver")
> Signed-off-by: Eric Anholt <eric@anholt.net>

Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index 629d372633e6..13481bb6322f 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master,
>  
>  	mipi_dsi_host_unregister(&dsi->dsi_host);
>  
> -	clk_disable_unprepare(dsi->pll_phy_clock);
> -	clk_disable_unprepare(dsi->escape_clock);
> -
>  	if (dsi->port == 1)
>  		vc4->dsi1 = NULL;
>  }

Patch
diff mbox

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index 629d372633e6..13481bb6322f 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -1641,9 +1641,6 @@  static void vc4_dsi_unbind(struct device *dev, struct device *master,
 
 	mipi_dsi_host_unregister(&dsi->dsi_host);
 
-	clk_disable_unprepare(dsi->pll_phy_clock);
-	clk_disable_unprepare(dsi->escape_clock);
-
 	if (dsi->port == 1)
 		vc4->dsi1 = NULL;
 }